mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-27 15:32:10 +08:00
cc166d71f4
This is a follow-up to c8a016b99d97, following the post-landing discussion at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7 base::size, and std::size that will eventually replace it when C++17 is assured, does not allow the size of non-static data members to be taken in constant expression context. The remaining uses of ArraySize are in: minidump/minidump_exception_writer.cc (×1) minidump/minidump_system_info_writer.cc (×2, also uses base::size) snapshot/cpu_context.cc (×4, also uses base::size) util/misc/arraysize_test.cc (×10, of course) The first of these occurs when initializing a constexpr variable. All others are in expressions used with static_assert. Includes: Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao f701716d9546 Add Windows ARM64 build target to mini_chromium 87a95a3d6ac2 Remove the arraysize macro 1f7255ead1f7 Placate MSVC in areas of base::size usage 737433ebade4 Add cast Bug: chromium:837308 Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19 Reviewed-on: https://chromium-review.googlesource.com/c/1396108 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
76 lines
2.1 KiB
C++
76 lines
2.1 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "util/win/ntstatus_logging.h"
|
||
|
||
#include <string>
|
||
|
||
#include "base/stl_util.h"
|
||
#include "base/strings/stringprintf.h"
|
||
|
||
namespace {
|
||
|
||
std::string FormatNtstatus(DWORD ntstatus) {
|
||
char msgbuf[256];
|
||
DWORD len = FormatMessageA(
|
||
FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS |
|
||
FORMAT_MESSAGE_MAX_WIDTH_MASK | FORMAT_MESSAGE_FROM_HMODULE,
|
||
GetModuleHandle(L"ntdll.dll"),
|
||
ntstatus,
|
||
0,
|
||
msgbuf,
|
||
static_cast<DWORD>(base::size(msgbuf)),
|
||
nullptr);
|
||
if (len) {
|
||
// Most system messages end in a period and a space. Remove the space if
|
||
// it’s there, because ~NtstatusLogMessage() includes one.
|
||
if (len >= 1 && msgbuf[len - 1] == ' ') {
|
||
msgbuf[len - 1] = '\0';
|
||
}
|
||
return msgbuf;
|
||
} else {
|
||
return base::StringPrintf("<failed to retrieve error message (0x%lx)>",
|
||
GetLastError());
|
||
}
|
||
}
|
||
|
||
} // namespace
|
||
|
||
namespace logging {
|
||
|
||
NtstatusLogMessage::NtstatusLogMessage(
|
||
#if defined(MINI_CHROMIUM_BASE_LOGGING_H_)
|
||
const char* function,
|
||
#endif
|
||
const char* file_path,
|
||
int line,
|
||
LogSeverity severity,
|
||
DWORD ntstatus)
|
||
: LogMessage(
|
||
#if defined(MINI_CHROMIUM_BASE_LOGGING_H_)
|
||
function,
|
||
#endif
|
||
file_path,
|
||
line,
|
||
severity),
|
||
ntstatus_(ntstatus) {
|
||
}
|
||
|
||
NtstatusLogMessage::~NtstatusLogMessage() {
|
||
stream() << ": " << FormatNtstatus(ntstatus_)
|
||
<< base::StringPrintf(" (0x%08lx)", ntstatus_);
|
||
}
|
||
|
||
} // namespace logging
|