8 Commits

Author	SHA1	Message	Date
Mark Mentovai	6d2d31d2d1	Use base/macros.h instead of base/basictypes.h ... This was done in Chromium’s local copy of Crashpad in 562827afb599. This change is similar to that one, except more care was taken to avoid including headers from a .cc or _test.cc when already included by the associated .h. Rather than using <stddef.h> for size_t, Crashpad has always used <sys/types.h>, so that’s used here as well. This updates mini_chromium to 8a2363f486e3a0dc562a68884832d06d28d38dcc, which removes base/basictypes.h. e128dcf10122 Remove base/move.h; use std::move() instead of Pass() 8a2363f486e3 Move basictypes.h to macros.h R=avi@chromium.org Review URL: https://codereview.chromium.org/1566713002 .	2016-01-06 12:22:50 -05:00
Scott Graham	07fcf63c21	win: fixes for Windows x64 ... Mostly size_t <-> unsigned int warnings, but I also had a mistake in PROCESS_BASIC_INFORMATION, the pids are 32-on-32 and 64-on-64. The Windows build is still x86 until https://codereview.chromium.org/981333002/. I don't think I'll bother maintaining the x86 build for now, though we will probably need it for x86 OSs in the future. It should be straightforward to revive it once we need it, and have bots to support it. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/983103004	2015-03-06 16:05:34 -08:00
Mark Mentovai	583233cf78	Add FileReaderInterface. Move StringFileWriter to StringFile and ... implement the new interface. The upcoming minidump reader will get minidump data from a FileReaderInterface. For ease of testing, a string-based implementation is provided. There wasn’t a good reason to have a separate StringFileReader and StringFileWriter, so I combined them into a single StringFile. TEST=util_test StringFile.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/936153002	2015-02-18 14:15:38 -05:00
Mark Mentovai	525de2c35a	Use exactly one of final, override, and virtual. ... This change was generated mechanically by running: find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override final/\1 final/' {} + find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override/\1 override/' {} + Additional changes were made manually based on: git grep -E '^ {3,}.*override[;{]' http://google-styleguide.googlecode.com/svn/trunk/cppguide.html?showone=The__define_Guard#Inheritance TEST=*_test BUG= R=rsesek@chromium.org Review URL: https://codereview.chromium.org/654933002	2014-10-14 11:11:57 -04:00
Mark Mentovai	6d1af6922f	Don’t use using directives (“using namespace”) in tests. ... The contents of tests are moved into the namespace crashpad::test::(anonymous namespace). https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces R=rsesek@chromium.org Review URL: https://codereview.chromium.org/635883002	2014-10-07 17:28:50 -04:00
Mark Mentovai	3b2c6d32f4	Add MinidumpMemoryWriter, MinidumpMemoryListWriter, and their test. ... TEST=minidump_test MinidumpMemoryWriter R=rsesek@chromium.org Review URL: https://codereview.chromium.org/459973002	2014-08-12 10:26:40 -07:00
Mark Mentovai	c73a97d4e3	Add MinidumpMiscInfoWriter and its test. ... TEST=minidump_test MinidumpMiscInfoWriter R=rsesek@chromium.org Review URL: https://codereview.chromium.org/454073002	2014-08-11 11:42:12 -07:00
Mark Mentovai	995012534e	Introduce MinidumpWritable, its dependencies, and their tests. ... MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005	2014-08-01 12:48:28 -04:00