crashpad

3party/crashpad

Fork 0

mirror of https://github.com/chromium/crashpad.git synced 2025-01-01 02:27:50 +08:00

Commit Graph

Author	SHA1	Message	Date
Scott Graham	4b780ba040	Tidy up to enable C4800 on Windows Fixes two incorrect usages of ssize_t/off_t being implicitly converted to bool. As such, I think it's worth the cost of the additional !! on BOOL returning Win32 functions. R=mark@chromium.org Review URL: https://codereview.chromium.org/1408123006 .	2015-10-22 14:32:13 -07:00
Mark Mentovai	d075a9eb2e	win: Add and use GET_FUNCTION() and GET_FUNCTION_REQUIRED() These wrap the GetProcAddress(LoadLibrary(), â€¦) idiom into macros that are much less wordy. TEST=crashpad_util_test GetFunction.GetFunction and all others R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1405323003 .	2015-10-19 14:32:07 -04:00
Scott Graham	d1e49bd221	Fix CRITICAL_SECTION test I thought I had confirmed that this still allocated and ignored the flag on older OSs, but I must have not had the PLOG active yet? I'm not sure what I did. (I might try to blame VMware as it has an annoying habit of caching old binaries when you use it's "Shared Folders" feature to point at the dev machine's build dir.) I confirmed that it does work on Win8 and Win10 but doesn't on Win XP and Win 7. R=mark@chromium.org BUG=crashpad:52 Review URL: https://codereview.chromium.org/1405243002 .	2015-10-16 14:55:14 -07:00

Author

SHA1

Message

Date

Scott Graham

4b780ba040

Tidy up to enable C4800 on Windows

Fixes two incorrect usages of ssize_t/off_t being implicitly converted
to bool. As such, I think it's worth the cost of the additional !! on
BOOL returning Win32 functions.

R=mark@chromium.org

Review URL: https://codereview.chromium.org/1408123006 .

2015-10-22 14:32:13 -07:00

Mark Mentovai

d075a9eb2e

win: Add and use GET_FUNCTION() and GET_FUNCTION_REQUIRED()

These wrap the GetProcAddress(LoadLibrary(), â€¦) idiom into macros that
are much less wordy.

TEST=crashpad_util_test GetFunction.GetFunction and all others
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1405323003 .

2015-10-19 14:32:07 -04:00

Scott Graham

d1e49bd221

Fix CRITICAL_SECTION test

I thought I had confirmed that this still allocated and ignored the flag
on older OSs, but I must have not had the PLOG active yet? I'm not sure
what I did. (I might try to blame VMware as it has an annoying habit of
caching old binaries when you use it's "Shared Folders" feature to point
at the dev machine's build dir.)

I confirmed that it does work on Win8 and Win10 but doesn't on Win XP
and Win 7.

R=mark@chromium.org
BUG=crashpad:52

Review URL: https://codereview.chromium.org/1405243002 .

2015-10-16 14:55:14 -07:00

3 Commits