103 Commits

Author SHA1 Message Date
Mark Mentovai
fd001f792e build: Make crashpad_dependencies="external" work in the GN build
…for macOS, at least.

Change-Id: Iba45328d957de17198180d171677a45468c9adc2
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2290842
Reviewed-by: Eric Astor <epastor@google.com>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2020-07-11 03:33:33 +00:00
Suraj Malhotra
e3c94b87f0 [fuchsia] Move //zircon/system/ulib/fdio to //sdk/lib/fdio
Bug: fuchsia:54057
Change-Id: I58e2bbf7f3a1674d5b34d4bc502b85cee0bea347
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2253148
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2020-07-10 18:43:55 +00:00
Justin Cohen
b300f76af9 Roll crashpad/third_party/edo/edo/ 243fc89ae..97121c640 (22 commits)
243fc89ae9..97121c6401

$ git log 243fc89ae..97121c640 --date=short --no-merges --format='%ad %ae %s'
2020-06-20 mobile-devx-github-bot Wrap EDOClientService::errorHandler c functions in extern "C"
2020-06-10 albertbow Add warning message to `isKindOfClass:`.
2020-05-02 sskhandp Add -Wunguarded-availability and fix availability warning
2020-04-29 mobile-devx-github-bot Fix up EDO to work with OCMock 3.6
2020-04-21 haowoo Use lightweight generics to retrieve root objects.
2020-04-18 albertbow Internal change
2020-04-16 mobile-devx-github-bot Internal change
2020-04-16 sskhandp Internal change
2020-04-09 mobile-devx-github-bot Fix up .andDo blocks to not call retainArguments that can accidentally cause retain loops in mocks.
2020-02-19 sskhandp Store queue in variable to avoid repetitive calls.
2020-02-13 mobile-devx-github-bot Make sure strongSelf and strongSelf.handlerSyncQueue is not nil.
2020-02-11 albertbow Minor fix on comments.
2020-02-03 tirodkar Fix project name
2020-01-10 albertbow Rollforward EDORemoteException for user-thrown exceptions in remote invocation.
2020-01-07 albertbow Roll forward the fallback of EDORemoteException to be the subclass of NSException.
2020-01-02 mobile-devx-github-bot Internal change
2020-01-02 albertbow Fallback EDORemoteException to be the subclass of NSException.
2019-12-18 albertbow Rollback EDORemoteException.
2019-12-17 albertbow Allow one-way blacklisting types in remote invocation.
2019-12-17 albertbow Use EDORemoteException for user-thrown exceptions in remote invocation.
2019-12-16 albertbow Expose EDORemoteException.
2019-12-12 albertbow Create EDOInvocationException class.

Created with:
  roll-dep crashpad/third_party/edo/edo

Change-Id: Id0bb660e2668c472a8ba1133822221ae100c2541
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2256583
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
2020-06-22 15:22:23 +00:00
Mark Mentovai
c7d1d2a1dd Fix googletest and googlemock in non-standalone mode after a45eea40fc81
Change-Id: I24216fd2505a31cf939ad624e355460b31f7a40f
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2189916
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2020-05-08 17:45:20 +00:00
Mark Mentovai
a45eea40fc Update gtest to e3f0319d89f4cbf32993de595d984183b1a9fc57
I’m most interested in picking up 1b3eb6ef3462, “Explicitly define copy
constructors used in googletest tests.”

This also reorganizes files and rewrites text to refer to this project
as Google Test and googletest (and Google Mock and googlemock), as it
prefers to be known. Some filenames are left at gtest_* following the
precedent set by gtest itself. For example, #include "gtest/gtest.h" is
still used, so #include "test/gtest_death.h" is retained too.
gtest_all_test OutputFileHelpersTest.GetCurrentExecutableName hard-codes
the expected executable name as gtest_all_test among other options that
do not include googletest_all_test, so test executables retain their
names as well.

fb19f57880f6 Add GTEST_BRIEF option
3549237957a1 Ensure that gtest/gmock pkgconfig requirements specify
             version
189299e957bb Merge branch 'master' into quiet-flag
5504ded3ab5c Fix a typo in .travis.yml
6ed4e7168f54 Replace the last instance of `throw()` with `noexcept`. NFC
879fd9b45299 Remove duplicate codes existed in get-nprocessors.sh
644f3a992c28 gtest-unittest-api_test - fix warning in clang build
0b6d567619fe Remove redundant .c_str()
be3ac45cf673 fix signed/unsigned comparison issue (on OpenBSD)
b51a49e0cb82 Merge pull request #2773 from Quuxplusone:replace-noexcept
c2032090f373 Merge pull request #2772 from Quuxplusone:travis
4fe5ac53337e Merge pull request #2756 from Conan-Kudo:fix-pkgconfig-reqs
373d72b6986f Googletest export
4c8e6a9fe1c8 Merge pull request #2810 from ptahmose:master
71d5df6c6b67 Merge pull request #2802 from e-i-n-s:fix_clang_warning
dcc92d0ab6c4 Merge pull request #2805 from pepsiman:patch-1
4f002f1e236c VariadicMatcher needs a non-defaulted move constructor for
             compile-time performance
9d580ea80592 Enable protobuf printing for open-source proto messages
766ac2e1a413 Remove all uses of GTEST_DISALLOW_{MOVE_,}ASSIGN_
11b3cec177b1 Fix a -Wdeprecated warning
01c0ff5e2373 Fix a -Wdeprecated warning
c7d8ec72cc4b Fix a -Wdeprecated warning
1b066f4edfd5 Add -Wdeprecated to the build configuration
4bab55dc54b4 Removed a typo in README.md
a67701056425 Googletest export
fb5d9b66c5b0 Googletest export
1b3eb6ef3462 Googletest export
b0e53e2d64db Merge pull request #2797 from Jyun-Neng:master
d7ca9af0049e Googletest export
955552518b4e Googletest export
ef25d27d4604 Merge pull request #2815 from Quuxplusone:simple
129329787429 Googletest export
b99b421d8d68 Merge pull request #2818 from inazarenko:master
472cd8fd8b1c Merge pull request #2818 from inazarenko:master
3cfb4117f7e5 Googletest export
0eea2e9fc634 Googletest export
a9f6c1ed1401 Googletest export
1a9c3e441407 Merge pull request #2830 from keshavgbpecdelhi:patch-1
e589a3371705 Merge pull request #2751 from calumr:quiet-flag

Change-Id: Id788a27aa884ef68a21bae6c178cd456f5f6f2b0
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2186009
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2020-05-07 14:56:07 +00:00
Mark Mentovai
a5a1c3b07f Add .style.yapf and reformat according to yapf, using “google” style
% yapf --in-place $(git ls-files **/*.py)
% yapf --version
yapf 0.30.0

Note that this is not using the “chromium” yapf style because Chromium
is moving to PEP-8.
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/RcJgJdkNIdg
yapf 0.30.0 no longer recognizes “chromium” as a style option.
22ef70f3c4
Since this is a mass reformatting, it might as well move things all the
way into the future all at once.

This uses the “google” style, which is a superset of “pep8”.

Change-Id: Ifa37371079ea1859e4afe8e31d2eef2cfd7af384
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2165637
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2020-04-27 13:59:09 +00:00
Francois Rousseau
6d8b196150 [fuchsia] remove handler
* Fuchsia only uses Crashpad for minidump generation, report database
  and report upload, not for the actual exception handling so it does
  not need a handler class
* the current handler class didn't have tests anyway
* Chromium on Fuchsia relies on the platform exception handling instead
  of rolling its own Crashpad exception handler
* this avoids us having to maintain an exception handler in another repo
* this removes the last FIDL dependency in Crashpad

TESTED=`fx test crashpad_test`

Change-Id: Ie3998f709e7cc4252dd551882a23b337864da85e
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2165638
Commit-Queue: Francois Rousseau <frousseau@google.com>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2020-04-24 23:20:08 +00:00
Scott Graham
a519f1bec3 fuchsia: Update build to use new "GN" SDK
This reworks the SDK pull to get the new packaging of the SDK.

Includes DEPS update to roll mini_chromium with two changes:
f7bd221 fuchsia: Remove fuchsia_sdk declare_args, add copy() tool
8ca5ea3 fuchsia: Use sdk/$host_os-amd64 for sdk path

Bug: fuchsia:7802
Change-Id: Ifcb0e90b19c7eddc32a37422e6951f214dcdfd36
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2165494
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2020-04-24 22:27:07 +00:00
Scott Graham
069fddf184 fuchsia: Remove unused sysinfo dep
This was previously used, but is no longer required. Delete the one
remaining include at the build rules.

Change-Id: If5083a4fb8a5562d3e40149976bd27fcec0fd302
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2165635
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Francois Rousseau <frousseau@google.com>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2020-04-24 20:00:17 +00:00
Mark Mentovai
1bfd7d06ed ios: Run mig with the correct SDK and architecture
mig was being invoked without any -arch argument, causing it to assume
the build system’s native architecture, which would be x86_64. This is
not correct for iOS device builds, which use arm64. The -arch argument
must be plumbed to mig for correct behavior.

When building for iOS, mig was being invoked without any -isysroot
argument, causing it to use the root for the build system, which runs
macOS and not iOS. The macOS SDK doesn’t include the ARM definitions
needed for iOS device builds.

<mach/exc.defs> and <mach/mach_exc.defs> depend on a small number of
other .defs files to provide definitions of standard types. All .defs
files are absent from the iOS SDK. These .defs files are borrowed from
xnu and placed in third_party/xnu. An additional --include argument is
added to allow mig to locate these files.

Bug: crashpad:31
Change-Id: I27154310352939ebe2fb6329bbbfda701c369289
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2159291
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2020-04-21 19:24:44 +00:00
Mark Mentovai
3e748e9c4e ios: Provide a copy of mach_exc.defs and run mig on it
This updates (and corrects) 8dbbaff2e1a5, which added exc.defs, by
adding mach_exc.defs too.

The difference betwen the exc and mach_exc subsystems is that the |code|
parameter is int[] in exc and int64_t[] in mach_exc. Many exceptions
carry the exception address in code[1], and a 32-bit int results in the
exception address being truncated in exc. No information is lost in
mach_exc, where a 64-bit int64_t is used.

In 8dbbaff2e1a5, I misremembered the type of the |code| parameter as a
type derived from uintptr_t, such as vm_address_t, an integer as wide as
a pointer. I was wrong, and mach_exc is necessary. I also noted that
Apple normally forbids mach_-prefixed interfaces in favor of the
prefix-less ones for the reasons I mentioned, and that, all else being
equal, it was desirable to adhere to the spirit of that convention.
Because neither exc nor mach_exc are available in the SDK, it’s moot
from a technical perspective, as we need to provide our own stubs either
way.

Bug: crashpad:31
Change-Id: Ied1be470e653b2bead1a283cb8b9283d210c328d
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2159286
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2020-04-21 19:23:24 +00:00
Mark Mentovai
8dbbaff2e1 ios: Provide a copy of exc.defs and run mig on it to generate exc stubs
The iOS SDK doesn’t include a copy of <mach/exc.defs>. It only provides
<mach/exc.h>, which is just the user-side header. To obtain declarations
and implementations of the server-side stubs, a current copy of
<mach/exc.defs> is added to third_party, and the mig action in util is
updated to use it on iOS.

The three other mig subsystems that Crashpad uses are not brought to
iOS:
 - mach_exc is identical to exc except it always uses 64-bit quantities
   for addresses in place of exc’s use of quantiies sized for native
   pointers. Because all iOS work is limited to a single process, there
   is no need to consider cross-process operation with variable bitness,
   so mach_exc is unnecessary. We’re also only targeting 64-bit for iOS,
   so exc will always suffice. This follows the spirit of other
   mach_-prefixed routines on iOS, where Apple forbids mach_vm_read to
   user applications but permits vm_read.
 - notify is primarily used on macOS in the Crashpad handler process to
   receive a no-senders notification, which is used to trigger handler
   shutdown when it has no more clients. This is not believed to be
   useful to Crashpad on iOS, which is restricted to single-process
   operation.
 - child_port is a Crashpad-specific subsystem used to pass Mach rights
   between processes, but is similarly useless when restricted to
   single-process operation as on iOS.

Bug: crashpad:31
Change-Id: Id4cb3cdd529814438d378c20702c82c1e89dd2be
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2154530
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
2020-04-17 21:11:57 +00:00
Mark Mentovai
e621aaa132 Make “gn check” pass
Change-Id: Ia7a215e1a2d0a3b1868b00c5d47b46ef8a675cdc
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2144917
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2020-04-13 18:29:42 +00:00
Victor Costan
380f2108df Roll crashpad/third_party/gtest/gtest/ eb78ee170..e3f0319d8 (232 commits)
eb78ee170a..e3f0319d89

This CL also removes references to gmock-generated-matchers.h, which was
removed from googletest in commit
41b5f149ab306e96b5b2faf523505d75acffd98a, and to
gmock-generated-function-mockers.h, which was removed from googletest in
commit fbf67a70d07543f40832d0cd7a58f304bc6ab1d1.

$ git log eb78ee170..e3f0319d8 --oneline --abbrev=12 --reverse
130e5aa86a7a Merge pull request #2 from google/master
6fd262ecf787 Prepare for Bazel incompatible changes
800c9b30168f Update Bazel on Windows
2c2c9e33573d remove a custom implementation of std::add_lvalue_reference
11471da7938b remove a custom implementation of std::enable_if
e2c06aa2497e remove a custom implementation of std::iterator_traits
364839ab142e remove a custom implementation of std::remove_const
da76d01b984f remove a custom implementation of std::is_reference
6a015ca1cb4e reuse IndexSequence from googletest
44de8697835d remove a dead metafunction
27e17f7851e2 Googletest export
410b52985e3d Googletest export
fcffabb5beb8 Googletest export
30e58a89a42b Merge pull request #2381 from Yannic:fix_bazel
d5e9e0c38f85 Merge pull request #2397 from kuzkry:custom-type-traits-is_reference
c9ccac7cb734 Googletest export
7bd4a7f3e9ae restore mistakenly removed iffs in their explicit form
d1ad644db4b9 Googletest export
fb49e6c16449 Merge pull request #2393 from kuzkry:custom-type-traits-remove_const
f8e9b3767ff8 remove references to autotools and combine gTest&gMock sections
9bf34ace7194 Merge pull request #2400 from kuzkry:custom-type-traits-enable_if
c6d884096ae5 Merge pull request #2401 from kuzkry:custom-type-traits-add_lvalue_reference
46525e1e5dfc Merge pull request #2394 from kuzkry:custom-type-traits-duplication-of-custom-index_sequence
db1b739943e9 Googletest export
ed2eef654373 Googletest export
38ce18e8e662 post-review to db1b7399 (#2396)
6a3d632f40a1 Googletest export
fdd6a1dc8c74 Merge pull request #2382 from kuzkry:dead-metafunction
85f059f03d56 Merge pull request #3 from google/master
d9c55a48eddb Merge pull request #2426 from kuzkry:#2396-postreview
eb56ee5a28b4 Googletest export
a648da952b79 Merge pull request #2420 from kuzkry:remove-autotools-section
565f1b848215 Merge pull request #2398 from kuzkry:custom-type-traits-iterator_traits
ab8f346b076f Googletest export
6123df929dba Googletest export
3f05f651ae36 Googletest export
c2b2cd8883f5 Googletest export
62a109a2ffe6 Googletest export
3a4503986247 Googletest export
bafa644c182e remove a dead function
838ea5cea301 remove GTEST_HAS_STD_STRING
33a0d4f6d76a Googletest export
0cd3fbc8abe6 change includes in gtest-port.h
274afe50cf57 Googletest export
ac24edd6e061 Googletest export
c7a03daa99e7 Merge pull request #2387 from kuzkry:iff
c96da8fea82e change usings
cad3bc46c2ba Googletest export
f2fb48c3b3d7 Googletest export
7c2bd3af981e square away the stuff that hasn't been merged in a manual review
3339b97c6a7f square away the stuff that hasn't been merged in a manual review
90a8ab70a1f6 mention the existing support for wide strings in string matchers
e0d16aa33662 remove GTEST_ARRAY_SIZE_
2460f97152c9 Add many missing override keywords
c78ea26f2008 Bump llvm version to 4 so brew can work again
076c46198fe1 Googletest export
bf0fe874a27b Googletest export
a783ade7c244 Googletest export
cb3f7ce1deef Googletest export
72adf7a4155b Googletest export
dc1ca9ae4c20 Googletest export
51f7396d4058 Fix typo in documents
68319c19eb01 Googletest export
4105eb726341 Googletest export
703bd9caab50 (tag: v1.10.x, tag: release-1.10.0) Googletest export
76a560c81cfe Googletest export
5126ff48d9ac Revert "Use pcfiledir for prefix in pkgconfig file"
b96832a44b49 Add documentation for pkg-config in cross-compilation settings
4360e4267c1e Merge pull request #2491 from SoapGentoo:fix-GNUInstallDirs-pkg-config
2ed2211db99a Use FormatFileLocation for streaming file and line
3f5a8c6ee6ce Merge pull request #2495 from hyukmyeong:typo
10c1d8c4faed Use the verbatim noexcept spec in MOCKED_METHOD
0eadff8a932d Fix spacing
872b9ceb6045 Avoid comma operator
7f8617a7c532 Switch to free function to avoid GCC bug
20255e6f4099 Use declval in noexcept expression
cd17fa2abda2 Merge pull request #2475 from peterbarker:pr/google-add-override
de69803b1e38 Mention Cornichon as a related open source project
cb1d5db1a104 Merge pull request #2448 from kuzkry:bad-googletest-export
5395345ca4f0 Merge pull request #2497 from thejcannon:handle_null_filename
20b5b8ecc7a8 Googletest export
58c71977611c Merge pull request #2505 from zebmason:cornichon
bc996e0817d8 Made noexcept condition more exciting
31406d79090e chore:  update version
9b9700247d46 clean-up broken paths for PlatformIO
ed78e54f38ab Googletest export
a4a5a7c768ce Googletest export
37905b9d8c8f Merge pull request #2498 from thejcannon:noexcept_spec
eafd2a91bb0c Merge pull request #2456 from kuzkry:gtest-port-clean-up_breaking-changes
a3ca5b9e0bf9 Googletest export
ba513d2c9525 Merge pull request #2498 from thejcannon:noexcept_spec
c081ceebfb6f Workaround MSVC VA_ARGS weirdness
c1e8e71aab60 Add a compile test
d935e8e3edaf Fix preprocessor tests
fe112cfee7e7 Replace compile-test with preprocessor test
5fe523361243 Removing extraneous test
40a6b9662199 feat: Add support for ESP8266 platform
c2206b05aa0f Add ESP8266 configs to PlatformIO build
f8961b99f4c3 Evaluate and cat NARG in different macros
3e813465a46b Removing extraneous parenthesis
84a5ae8b8560 Update to distinguish prelease purpose of this fork.
3cddd56e195b Add more override keywords
e1b67b07f7bd Avoid recursive macros
778733f9ecdd feat: Add ESP8266 support
9e466f1eb0fa Merge pull request #2510 from ciband:chore/update_pio_version
4c25e2b87fcb Googletest export
bdc29d5dc19d Merge pull request #2421 from kuzkry:cleanup-for-regex
cbf019de22c8 [googletest] Output skip message
2995ca563d76 Merge pull request #2507 from roblub:master
bbe4b7363bba Googletest export
1f9edcd96981 Googletest export
f966ed158177 Googletest export
5f92697d46ae Fix Issue 2418
f164a9e23c0f Remove extra space
011c4e23d525 Googletest export
8ce64c084d83 Merge pull request #2454 from kuzkry:gtest-port-clean-up_dead-function
a5216dd1a9f3 Merge pull request #2511 from kuzkry:PlatformIO-clean-up
611a321a6e64 Googletest export
de1128355464 Merge pull request #2444 from kuzkry:remove-GTEST_ARRAY_SIZE_
8c91ecef292e Merge pull request #2517 from snarkmaster:master
b11fb80e9e94 Prevent using ReturnRef on reference to temporary
f1afeaa64348 Googletest export
19a3bbce512d Added tests verifying that temporaries are accepted by ReturnRef
37590da6c08f Added more tests to verify: ReturnRef not accept temporary
aa1146da8169 Googletest export
8bab7883a676 Merge pull request #2514 from thejcannon:msvc_macro_issue
1110c471cadf Merge pull request #2522 from cloudrex:patch-1
676d0444bf95 Revert "Merge pull request #2498 from thejcannon:noexcept_spec"
37f322783175 Googletest export
6e87238c9b14 remove BiggestInt
d072682119f8 Tests simplified and names corrected (POD->scalar)
5ff72f5295f3 Apply 80chars limit
208c2f6b6076 variable names corrected (followed google coding style)
540835fa687e Merge pull request #2515 from ciband:feat/support_esp8266
eed64b5fc6c0 replace autogenerated TypesX classes by variadic ones
e3a9a567d826 replace autogenerated TemplatesX classes by variadic ones
a7083564d550 remove gtest-type-util.h.pump
002905f29fc9 move the pumping script to googlemock
1a49b67aebe9 update CONTRIBUTORS
a8b1a66cfda3 Merge pull request #2388 from kuzkry:remove-gtest-type-util.pump
a1f71dd56df4 Googletest export
b5fb5ba05cb6 Merge pull request #2527 from PiotrNycz:gmock_prevent_return_ref_to_store_temporaries_2
757d39a79bcb Googletest export
755f853c6be9 Googletest export
2bee6da24e9f Googletest export
fff8dabbf6c5 Googletest export
ba33a8876c3e Googletest export
f626deda19e5 Added special catch for std::exception in GTEST_TEST_NO_THROW_
0a03480824b4 Googletest export
e2fc3a9c9cb8 Googletest export
2db3df9c4f82 Googletest export
057ee5063d00 Merge pull request #2533 from thejcannon:noexcept_spec
e8a82dc7ede6 Merge pull request #2453 from kuzkry:gtest-port-clean-up_kMaxBiggestInt
523ad489efc3 update pump_manual.md
442f45b376f5 pump.py: add support for Python 3
f658561ef253 fix a typo
8697709e0308 Merge pull request #2453 from kuzkry:gtest-port-clean-up_kMaxBiggestInt
f9665846e405 update gen_gtest_pred_impl.py
f79ac2ce0e78 change incorrect comments
6caa879a42d9 pkg-config: Remove pthread link flag from Cflags
3e062a6efe7a Merge pull request #2373 from Youw:master
54978626b40f Merge pull request #2547 from kuzkry:typo
8aedd597af6b Merge pull request #2548 from kuzkry:update-pump-manual
e08a4602778b Merge pull request #2549 from kuzkry:pump-support-for-python-3
681454dae48f Googletest export
d5707695cb02 Googletest export
dee725b05332 add documentation for the premature-exit-file protocol
11440f27c66d Merge pull request #2556 from ienorand:avoid-pkg-config-lpthread-cflag
f73898f3ffd4 Merge pull request #2554 from kuzkry:update-gen_gtest_pred_impl
c27acebba3b3 Merge pull request #2521 from Sinclair-John:master
0c469a5a065e Fix FlatTuple compilation on older msvc.
dcdb65065f41 Fix internal memory leak in Windows _Crt report.
50cfbb726b26 Googletest export
4bf466236dbe Googletest export
200ff599496e Merge pull request #2569 from bgianfo:master
6a9d6d5c28a7 Fix compile break for Microsoft Visual Studio 2017 v141
2241be0c3f24 remove g++ 3.3 workaround: using on operator<<
e1dd49835ef2 remove g++ 2.95.0 workaround: no space after first comma in macros
a91e4e73b702 remove stale comments about older GCC versions
21d276b5c42d remove MSVC workaround: accessing namespace scope from within nested classes
a5136dbdd21e remove MSVC workaround: error C2665
ecefcbd4aa71 remove MSVC workaround: warning 4355
6748df1eab1d remove MSVC workaround: cease const dropping
e0c80b0a6e51 consistency fix for SafeMatcherCastImpl member functions
bbbc5d8a4b90 remove Nokia's Symbian compiler workaround: SafeMatcherCastImpl
298a40f023e6 remove MSVC workaround: wmain link error in the static library
a909becdc599 unify googletest and googlemock main functions
717ce7feb872 Googletest export
af71b6607f9e Merge pull request #2570 from xieyubo:1.10
679bfec6db73 Googletest export
838a32845c64 Fixed typo
5a62d400e057 README.md: added Catch2 and Google Test Explorer
51545ee515fc Googletest export
a32a20009473 Merge pull request #2588 from kuzkry:remove-workaround_g++-incorrect-comments
7a8a5bcec005 Merge pull request #2591 from kuzkry:remove-workaround_g++-using-on-operator<<
be74b4b2e0d1 Googletest export
db13ff1f0bd5 Merge pull request #2597 from kuzkry:remove-workaround_Nokia-Sybian-SafeMatcherCastImpl
0361bdf591dd Merge pull request #2596 from kuzkry:remove-workaround_msvc-wmain-link-error
39803f3c51d2 Merge pull request #2593 from kuzkry:remove-workaround_msvc-namespace-scope-from-nested-class
34e92be31cf4 Merge pull request #2604 from matepek:readme-update-with-opensource-proj
b8a92f7c86e4 Rename test case to test suite
967d8e05c2f0 Revert "unify googletest and googlemock main functions"
3957b8898b58 Revert "remove MSVC workaround: wmain link error in the static library"
b155875f32dc Merge pull request #2583 from ChristophStrehle:master
11a9482f84ac Merge pull request #2607 from oyefremov:patch-1
52825d78aac6 Merge pull request #2603 from maximilianschwab:patch-1
ae8d1fc81b14 Googletest export
cf75d4b92ecc Googletest export
1d563578c86f Merge pull request #2594 from kuzkry:remove-workaround_msvc-unneeded-const-dropping
2002f267f05b Googletest export
9ed99c6c837a Googletest export
78fdd6c00b8f Merge pull request #2609 from kuzkry:revert-2596
20b8e7a1c827 Activate GNU extensions in case of MSYS generator
6251071a20e8 Googletest export
a3097c826e4d Merge pull request #2592 from kuzkry:remove-workaround_msvc-error-C2665
88ba008c234a Merge pull request #2595 from kuzkry:remove-workaround_msvc-warning-4355
d442089d53ce Googletest export
d8eeb9760afc Googletest export
d16f86ff1cac Googletest export
5b162a79d49d Merge pull request #2589 from kuzkry:remove-workaround_g++-no-space-after-first-macro-argument
d2016469064b Workaround VS bug w.r.t empty arguments to macros
4b7809c2f523 Revert "Googletest export": Remove test for empty prefix
1800a38fb7d8 Revert "Googletest export": disallow empty prefix
0a0c82662992 Googletest export
d166e0948384 Merge pull request #2590 from kuzkry:remove-workaround_g++-stale-comments
9d8222ad6672 Disable move constructor and assignment operator for test classes.
77b3a250ea9e Review notes: Return T& from assignment operators
05701fee2896 Deleted functions as part of public interface
cc05a3ca014b Define default destructor for test classes
bf31ed376ab1 Make move operation noexcept.
6f1a8ffde934 Googletest export
d0a521255eb5 Googletest export
008629ae2163 Merge pull request #2624 from ShabbyX:master
a13a0626188b Googletest export
fbe34cecf4ff Merge pull request #2639 from trzecieu:trzeci/move_ctor_assign
153909f09633 Googletest export
0d98d87e1069 Googletest export
07ab939af757 Merge pull request #2632 from Kravlalala:cmake/mingw_msys_build
306f3754a71d Googletest export
4b9c1691c4b7 Googletest export
8417b7332210 Googletest export
c901f67ddf8a Googletest export
d854bd6acc47 Googletest export
3aa538cbfcc6 fix unit test failure on NoShortCircuitOnFailure and DetectsFlakyShortCircuit when GTEST_HAS_RTTI is 1
c7137f0b8422 Use IsReadableTypeName IsReadableTypeName in OfType function in gmock-matchers_test.cc
aa4315646b22 Remove exclusion of *-main and*-all targets
ed16134fb313 Googletest export
0b024bd91a14 Googletest export
7a8591e6e4e2 Googletest export
3e79d366e380 Googletest export
5336106b66db Googletest export
8b4817e3df37 Googletest export
18b67bfc58b1 Googletest export
c59c7bab5056 Merge pull request #2672 from ivan1993br:ivan1993br-platformio_update
9417fb401a57 Merge pull request #2665 from bysreg:fix_noshortcircuitfailure_detectsflakyshortcircuit_test
d01e356e155a Googletest export
10b1902d893e Googletest export
c378d7eb9308 remove a dead reference to the Autotools script
22397f28ef57 Googletest export
f1a6db9d4a8c Googletest export
87061810f4c7 Googletest export
7413280c52c1 Googletest export
d6ce39edf612 Googletest export
38f6608e8790 Googletest export
7bc671b8e0de Googletest export
572e261b6075 Googletest export
74b44b2d0fc2 Googletest export
4f6609129a2f Googletest export
d02e2772750f Googletest export
11d9834e98c1 Googletest export
fbf67a70d075 Googletest export
2d6d7a01c9ce Googletest export
41b5f149ab30 Googletest export
139fa202c938 Googletest export
360f5f70a3ff Googletest export
56de7cc8b554 Googletest export
d0930731d601 Googletest export
6f5fd0d7199b Googletest export
23b2a3b1cf80 Googletest export
04e52ebe7816 Fixed warnings
fd538161f484 Googletest export
909b1ccfcacc Googletest export
e588eb1ff9ff Googletest export
a1b0173df92b Make sure IsATTY does not clobber errno.
cfb5ef4e7dc0 Googletest export
878bd92e0fef Merge pull request #2716 from kuzkry:autotools-leftover
3de76551e0f0 Merge pull request #2722 from JohanMabille:warnings
0bf8ea3065f7 Googletest export
230afdb24e0f Googletest export
227faf41db5e Googletest export
c43f7100f084 Googletest export
482ac6ee6342 Googletest export
e41f31f2af3a Add tests for MockFunction deduction (#2277)
53740ebc21d5 Add support for std::function in MockFunction (#2277)
dbe804f98621 Merge pull request #2746 from Romain-Geissler-1A:master
749148f1accc Googletest export
08347d7a1604 Swap settimer and sigaction calls to avoid SIGPROF
82e5767f7812 remove dead code in googletest-output-test
acabdf65fba1 remove chapters on Autotools, Meson and plain Makefiles
1ced315a483f Googletest export
67cc66080d64 Merge pull request #2350 from adambadura:MockFunctionFromStdFunction
01e4fbf5ca60 Merge pull request #2764 from kuzkry:googletest-output-test-dead-code
dc82a33473dd Merge pull request #2765 from kuzkry:unsupported-build-systems
61f010d703b3 Googletest export
c344cb5a8d2b Googletest export
7084afda5aa3 Merge pull request #2762 from pkryger:avoid_sigprof
e3f0319d89f4 Merge pull request #2715 from kuzkry:document-premature-exit-file-protocol

Created with:
  roll-dep crashpad/third_party/gtest/gtest

Bug: 1070043
Change-Id: I39ab84ab931fa469cf8922a2d33d9b2b4e04cf4e
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2145627
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
2020-04-11 23:15:27 +00:00
Scott Graham
054f45724e Revert "fuchsia: Include reference to zx library"
This reverts commit de5bc33b8b45b197977430a0e74a37c00c6a3bc3.

Reason for revert: going to be removed back out of the SDK, transitions are hard :( https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=7802#c33

Original change's description:
> fuchsia: Include reference to zx library
> 
> "library zx" used to be built in to fidlc, but is now a standalone file
> (this is an SDK change). Update the build rules to adapt to this.
> 
> ref: https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket.appspot.com/8883567878548782112/+/steps/compile_with_ninja/0/stdout
> 
> FAILED: gen/fidl/include/fuchsia/sysinfo/c/client.cc gen/fidl/include/fuchsia/sysinfo/c/fidl.h gen/third_party/fuchsia/fidl/fuchsia.sysinfo/tables.c gen/third_party/fuchsia/fidl/fuchsia.sysinfo/intermediary_representation.json
> python ../../third_party/fuchsia/runner.py ../../third_party/fuchsia/sdk/linux-amd64/tools/fidlc --c-header gen/fidl/include/fuchsia/sysinfo/c/fidl.h --c-client gen/fidl/include/fuchsia/sysinfo/c/client.cc --tables gen/third_party/fuchsia/fidl/fuchsia.sysinfo/tables.c --json gen/third_party/fuchsia/fidl/fuchsia.sysinfo/intermediary_representation.json --name fuchsia.sysinfo --files ../../third_party/fuchsia/sdk/linux-amd64/fidl/fuchsia.sysinfo/sysinfo.fidl
> ../../third_party/fuchsia/sdk/linux-amd64/fidl/fuchsia.sysinfo/sysinfo.fidl:7:7: error: Could not find library named zx. Did you include its sources with --files?
> using zx;
>       ^~
> 
> Bug: fuchsia:7802
> Change-Id: I10c0109fd9621a19d72deb21a489c2041caeeeca
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2141019
> Commit-Queue: Scott Graham <scottmg@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>

TBR=justincohen@chromium.org,scottmg@chromium.org

Change-Id: I0328c2ff586ff733926a51d87774453cb2cf7c33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: fuchsia:7802
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2143940
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2020-04-09 23:56:21 +00:00
Scott Graham
de5bc33b8b fuchsia: Include reference to zx library
"library zx" used to be built in to fidlc, but is now a standalone file
(this is an SDK change). Update the build rules to adapt to this.

ref: https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket.appspot.com/8883567878548782112/+/steps/compile_with_ninja/0/stdout

FAILED: gen/fidl/include/fuchsia/sysinfo/c/client.cc gen/fidl/include/fuchsia/sysinfo/c/fidl.h gen/third_party/fuchsia/fidl/fuchsia.sysinfo/tables.c gen/third_party/fuchsia/fidl/fuchsia.sysinfo/intermediary_representation.json
python ../../third_party/fuchsia/runner.py ../../third_party/fuchsia/sdk/linux-amd64/tools/fidlc --c-header gen/fidl/include/fuchsia/sysinfo/c/fidl.h --c-client gen/fidl/include/fuchsia/sysinfo/c/client.cc --tables gen/third_party/fuchsia/fidl/fuchsia.sysinfo/tables.c --json gen/third_party/fuchsia/fidl/fuchsia.sysinfo/intermediary_representation.json --name fuchsia.sysinfo --files ../../third_party/fuchsia/sdk/linux-amd64/fidl/fuchsia.sysinfo/sysinfo.fidl
../../third_party/fuchsia/sdk/linux-amd64/fidl/fuchsia.sysinfo/sysinfo.fidl:7:7: error: Could not find library named zx. Did you include its sources with --files?
using zx;
      ^~

Bug: fuchsia:7802
Change-Id: I10c0109fd9621a19d72deb21a489c2041caeeeca
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2141019
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
2020-04-08 20:45:01 +00:00
Leonard Chan
8bad6f140e [UBSan] Temporarily disable UBSan for gtest and file
These should be the remaining instances of UB errors we see.

Bug: fuchsia:46805
Change-Id: Id8285386fd6cb52518f6076ddb79ac60025f9f87
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2067754
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2020-02-24 17:26:35 +00:00
Justin Cohen
75ea787a80 Adds plumbing for xcuitests with a placeholder test.
Also adds basic integration for EDO.

Change-Id: If3d193a4967a566b55d6d446585e2988dacad6e6
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2028183
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-01-31 03:39:51 +00:00
Nico Weber
2fd16e3392 Reformat all gn files
Port of chromium-side
https://chromium-review.googlesource.com/c/chromium/src/+/1997899

Bug: chromium:1041419
Change-Id: Ic7afefa0dea024da37fe4bb0f965840a160e2166
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2015428
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-01-23 13:59:00 +00:00
Scott Graham
af5d5468e0 Rename FIDL tables to .c due to use of designated initializers
Will also need https://fuchsia-review.googlesource.com/c/fuchsia/+/348593 to land in the SDK to fix the bots.

Very helpful link: https://ci.chromium.org/p/crashpad/builders/try/crashpad_try_fuchsia_arm64_dbg/728

Change-Id: Iacdbb13a72d116bd579f5f10cadbe7a0b3ed7987
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1966371
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-12-13 16:46:32 +00:00
Scott Graham
272c4bb64e fuchsia: Add missing transformer.cc to fidl_base
Fix fidl_base build, again. Fixes broken tryjobs as seen in
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1872188.

Change-Id: Iaec1613b3b335fac501227b7a86134309f52d7f3
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1899650
Reviewed-by: Francois Rousseau <frousseau@google.com>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2019-11-05 19:07:27 +00:00
Scott Graham
b2e26bc455 fuchsia: Fix fidl_init_txn_header link error
Add missing/new fidl_base/txn_header.c to fidl_base library in Fuchsia
build. However, that transitively includes files that use static_assert
via assert.h, which is a C11 feature. Per
https://fuchsia.googlesource.com/fuchsia/+/master/docs/development/api/c.md#Language-versions-C-1
Fuchsia does not aim to support C99, so change the build setting in mini_chromium as well in
https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/1876894

Includes mini_chromium roll:
2298dbe9d0b3213720ac0e5418ad0013a19aeb5d Change cflags_c from c99 to c11
63dfdbd690244c58c1595543806bafd5e5f8aabd Adds support for codesigning iOS app bundles.
ae8e6c54b9a6ea2fd4ff64aab61227d9fad1897e Adds GN rules for ios app bundles.

Change-Id: I09c93d5b2b7ae197c8dc95b83e9c467a68ee51f1
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1876893
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-10-23 20:16:37 +00:00
P.Y. Laligand
10a1d2d877 [fuchsia] Use the appropriate separator for FIDL library names.
Bug: fuchsia:35562
Change-Id: If465af3d91c418b448f837b850e10e8d12f3281b
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1776919
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2019-08-29 22:18:32 +00:00
P.Y. Laligand
1c7023875b [build] //zircon/public/fidl --> //zircon/system/fidl
Bug: fuchsia:35562
Change-Id: Ic50ae72b870fe8aa415539a93aae4eaa2647731a
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1773124
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2019-08-27 21:14:25 +00:00
Scott Graham
50aa576622 Disable implicit fallthrough warning for zlib
https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket.appspot.com/8903960674082840512/+/steps/compile_with_ninja/0/stdout

I don't understand how this lingered for so long as I can't see what
changed. mini_chromium has had -Wimplicit-fallthough enabled for a long
time (https://chromium-review.googlesource.com/899847), and zlib DEPS
hasn't changed in a long time either
(https://chromium-review.googlesource.com/438585).

The most likely would presumably be that the compiler started
not-ignoring the enabling of the warning? But that doesn't seem too
likely either.

Bug: crashpad:309
Change-Id: I57480cc3f669ef94d0234afaf980281b7ddf8c51
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1772205
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2019-08-27 19:18:05 +00:00
Vlad Tsyrklevich
6b5e30db28 Fix signed-unsigned-wchar build failure
Fix a build failure introduced by a new error diagnostic
(-Wsigned-unsigned-wchar) in clang that has been fixed in a newer
version of gtest and revert commit
a34bca8611b6263632a94d3d773df076c81d03dd which worked around it.

Change-Id: Ibe332bf65215e4722fd962540f144c435f77b2fb
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1753067
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
2019-08-16 17:00:25 +00:00
Scott Graham
a34bca8611 Disable warning when building gmock tests
On recent clang builds, some gmock tests are failing to build:

FAILED: obj/third_party/gtest/gtest/googlemock/test/gmock_all_test.gmock-actions_test.o
../../third_party/linux/clang/linux-amd64/bin/clang++ -MMD -MF obj/third_party/gtest/gtest/googlemock/test/gmock_all_test.gmock-actions_test.o.d -D_FILE_OFFSET_BITS=64 -DGUNIT_NO_GOOGLE3=1 -I../../third_party/gtest/gtest/googlemock -I../../third_party/gtest/gtest/googletest -I../../third_party/gtest/gtest/googlemock/include -I../../third_party/gtest/gtest/googletest/include -Wall -Wendif-labels -Werror -Wextra -Wextra-semi -Wno-missing-field-initializers -Wno-unused-parameter -Wsign-compare -fno-exceptions -fno-rtti -fno-strict-aliasing -fobjc-call-cxx-cdtors -fstack-protector-all -fvisibility-inlines-hidden -fvisibility=hidden -Wheader-hygiene -Wnewline-eof -Wstring-conversion -stdlib=libstdc++ -fPIC -Wimplicit-fallthrough --sysroot=../../third_party/linux/sysroot -pthread -Wexit-time-destructors -Wno-unused-private-field -std=c++14 -Wno-inconsistent-missing-override -c ../../third_party/gtest/gtest/googlemock/test/gmock-actions_test.cc -o obj/third_party/gtest/gtest/googlemock/test/gmock_all_test.gmock-actions_test.o
../../third_party/gtest/gtest/googlemock/test/gmock-actions_test.cc:109:37: error: 'wchar_t' cannot be signed or unsigned [-Wsigned-unsigned-wchar]
  EXPECT_EQ(0U, BuiltInDefaultValue<unsigned wchar_t>::Get());
                                    ^
...

Disable this warning for now.

Change-Id: Ibd41a6fc12d1f13eca5227775e2559ccf3baf229
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1754722
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-08-14 21:50:03 +00:00
Francois Rousseau
8b8066297c [fuchsia] remove obsolete FIDL string.cc include
the code moved to string.h and the SDK no longer includes that source file

TESTED=fix the broken Fuchsia bots

Change-Id: I2ad39e6bc4d90e7a79ab380899bd20a84d0df465
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1724907
Reviewed-by: Francois Rousseau <frousseau@google.com>
Commit-Queue: Francois Rousseau <frousseau@google.com>
2019-07-30 17:57:45 +00:00
Scott Graham
b1dbfc65be Fuchsia: Update SDK build from cpp to cc
Fuchsia recently globally renamed all .cpp to .cc and some of that leaks
out into the SDK.

Change-Id: Id04c7e18cde77674dc6c1a40f9e378bb182951c8
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1682767
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2019-06-28 21:31:44 +00:00
Roland McGrath
bc9104541f [fidl] Convert from - to . names for //zircon/public/fidl
This is part of a soft transition to replace fuchsia-foo-bar names
with fuchsia.foo.bar names for the directory and GN target names for
FIDL libraries defined in //zircon/system/fidl and accessed in legacy
GN via //zircon/public/fidl.  After the transition, the directory and
GN target names will exactly match the FIDL library names everywhere.
 1. Make //zircon/public/fidl/a.b.c alias //zircon/public/fidl/a-b-c
 2. Convert all //zircon/public/fidl uses outside fuchsia.git & integrate
 3. Convert all //zircon/public/fidl uses inside fuchsia.git
 4. Remove transition hacks
 5. Enforce naming conventions in GN templates
This is step 2.

Bug: ZX-3365 #comment //third_party/crashpad references converted
Change-Id: Ief90c6f9fa1da51dea7dbbd5b58741cbb7e06891
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1608163
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Roland McGrath <mcgrathr@chromium.org>
2019-05-16 23:49:37 +00:00
Francois Rousseau
77b2b2f1d0 [fuchsia] change attachments from filepaths to VMOs
* we start with VMOs in Fuchsia so this avoids a temporary file before writing the files in the database
* in order to do a soft transition, we add the new type and leave the old one until the caller in Fuchsia has been updated.

Bug: fuchsia:DX-1270

Change-Id: I3c77c775a186801dbcc7379e84ad5795f41780e7
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1554011
Commit-Queue: Francois Rousseau <frousseau@google.com>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2019-04-10 19:29:17 +00:00
Francois Rousseau
83f6f43d81 [fuchsia] allow generation of C++ bindings for FIDL dependencies
Bug: fuchsia/DX-1270
Change-Id: I99edcfcc96baa00affd129f9249fe6e3c565812b
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1560311
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
2019-04-09 21:03:52 +00:00
Francois Rousseau
0c618f8317 [fuchsia] define zx and fidl_base in their own source_set
ideally these source_set would be create programmatically from the corresponding meta.json

Change-Id: I4374aef5614c75603132dcdf8d32a687fb9cbadc
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1560077
Commit-Queue: Francois Rousseau <frousseau@google.com>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2019-04-09 20:24:52 +00:00
Francois Rousseau
7411c8354b [fuchsia] use source_set for C FIDL library
this makes it easier to depend on what we want (the C bindings) rather than having to maintain two lists in sync (sources and deps)

Change-Id: Ib3c7715cf8e54658ab44e4de04d04acedf13d09c
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1558821
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
2019-04-09 17:24:12 +00:00
Joshua Peraza
cc0c2f90df Add lss to third_party and use sys_getpid()
More syscalls to come.

Bug: crashpad:265
Change-Id: Ib139e638b0356426f922650249632132fd613f6f
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1540403
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-04-09 00:53:01 +00:00
Francois Rousseau
c8dc08b719 [fuchsia] clean up third_party/fuchsia/BUILD.gn
Change-Id: I5c5f03ea5882592008d11e2819962e8781954ca2
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1555833
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
2019-04-08 16:13:29 +00:00
Francois Rousseau
0730f0c60c [fuchsia] rename gn group to fuchsia
now that we import fuchsia-sysinfo and fdio, this isn't really just zx anymore

Change-Id: Ic42359ce3d230e214ebdbbefb880ccb021434a0f
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1555533
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
2019-04-05 23:33:12 +00:00
Mark Mentovai
2a47ea4663 Obtain the Fuchsia SDK from the correct (updated) location
Since a mac-amd64 SDK is now published in addition to linux-amd64, use
it on macOS instead of repurposing linux-amd64.

Many thanks to Scott Graham <scottmg@chromium.org> for helping out at
https://chromium-review.googlesource.com/c/1506419.

Bug: crashpad:279
Change-Id: I4f108222ec2e75dea93fe32053ab470ac7ce48b9
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1503688
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2019-03-06 22:29:08 +00:00
Mark Mentovai
3332ae3546 compat: Provide <elf.h> and <mach-o/loader.h> for everyone
I’m working on something that I’m not ready to share, but maintaining
these compat headers in my local branch is becoming annoying because
“git cl format” keeps reformatting them since they were added since my
local branch point.

Because these headers are non-trivial, they’re brought nearly unmodified
from upstream into third_party, with forwarding from the appropriate
locations in compat.

<elf.h> comes from glibc 2.29 (2019-01-31) and was modified to remove
the #include of <features.h> and to replace the use of __BEGIN_DECLS and
__END_DECLS with the proper conditional extern "C" construct.

<mach-o/loader.h> comes from xnu 4903.221.2 (macOS 10.14.1, 2018-10-30)
and was modified to remove the unused #includes of
<mach/machine/thread_status.h> and <architecture/byte_order.h>. Rather
than taking <mach/machine.h> and <mach/vm_prot.h> with a spider web of
other dependencies from xnu, compat has cut-back versions of these
headers that provide only the required typedefs.

This also includes an update of apple_cf to 1153.18 (OS X 10.10.3,
2015-04-08), the last public release of CF-Lite. The change doesn’t do
much for our purposes, but it restores the file to an Apple-shipped
state, trailing whitespace and all.

This also canonically formats BUILD.gn. 48ee086ca4c4c didn’t format it.

Change-Id: Ib4f28ad53d9757bd0eed838e148c51172bfe30b1
Reviewed-on: https://chromium-review.googlesource.com/c/1489795
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2019-02-26 22:48:14 +00:00
Mark Mentovai
2271f00fe0 Add missing BUILD.gn for third_party/apple_cf
apple_cf is just a header, but we’ve got a BUILD.gn for
third_party/cpp-httplib, which is also just a header.

Change-Id: Ib42c25657b5964678d14682a0a802ebef0e4cb2f
Reviewed-on: https://chromium-review.googlesource.com/c/1489182
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2019-02-26 16:39:24 +00:00
Mark Mentovai
8694cbf33e Update gtest to 9518a57428ae0a7ed450c1361768e84a2a38af5a
4665eee10a1d test, please ignore
826656b25f62 Remove workarounds for unsupported MSVC versions
c43603f288f4 Remove GTEST_HAS_HASH_SET/MAP check
a3a42514f1a9 Define GTEST_DISABLE_MSC_WARNINGS_PUSH/POP for all
             compilers
48021336904c Add back warning suppression that shouldn't have been
             removed
1454f301c554 Update README.md
09beafcd1d54 Merge branch 'master' into patch-1
7a0680dc2230 Merge pull request #1959 from robinlinden:remove-msvc-
             workarounds
d5932506d6ee Merge pull request #1961 from coppered/patch-1
c5f08bf91944 Googletest export
e46e87bb1f76 Googletest export
aac18185ebb4 Googletest export
8e86f6726164 Googletest export
45d66d81bec9 Googletest export
5dab7be70d62 Googletest export
c2989fe29b6a Googletest export
b49266606875 Googletest export
bb7c0ecbdf47 Googletest export
64368e0584e0 Googletest export
f7779eb3cb5d Googletest export
a3013cceffbe Googletest export
3cf8f514d859 Update build badge
ce526b87007a Issue #1955: Remove THREADS_PREFER_PTHREAD_FLAG
28a3261fdf94 Create CODE_OF_CONDUCT.md
87589af5ba5a Update .travis.yml
2f126c74d264 Update .travis.yml
5404fd7d06a8 Update .travis.yml
915f6cfef369 Update .travis.yml
fca458cab75b Googletest export
191f9336bc92 Merge pull request #1977 from

             lukasm91:issue_1955_remove_pthread_flags
b22d23667b60 Googletest export
8fbf9d16a63a Googletest export
775a17631217 Fixed typo
a42cdf2abdc0 Googletest export
26743363be8f Googletest export
ba344cbc405f Googletest export
10e82d01d94c Update README.md
a28a71ae41fa Update README.md
214521a1486d Update WORKSPACE
3fd66989bb5c Googletest export
067aa4c28bb1 Do not define GTEST_IS_THREADSAFE within GTEST_HAS_SEH
3d71ab4c37de Googletest export
fe14e3030737 Merge pull request #1995 from siddhanjay/patch-1
2c8ab3f18b2e feat:  Add initial support for PlatformIO and Arduino
695cf7c96249 Merge pull request #1997 from gpakosz:GTEST_IS_THREADSAFE
39c09043b83e chore:  Add initial library.json config
d9251df84951 fix: Remove global chmod from Travis
31eb5e9b873a chore:  Update version to latest release
b5c08cb9f4f1 Cache gcc and clang APT packages
06bb8d4d6dcf Googletest export
6cbd3753dc19 Googletest export
ea5e941d8470 Change directory ownership earlier
fc0f92676865 Don't cache APT packages on OS X/macOS
3b1f43c2e7a5 Use if statements
b545089f5117 Merge pull request #2004 from cotsog/patch-1
6ef591381372 Googletest export
3949c403c0ed Update README.md
81f00260668d Googletest export
c6cb7e033591 Googletest export
b5f5c596a991 Merge pull request #2000 from
             ciband:feat/add_support_platformio
1496f73cc4c3 fix:  correct JSON syntax
0f698c830f79 chore:  Add .vs to .gitignore for Visual Studio
096fb37a1976 Googletest export
1ec20f87e390 Googletest export
b7dd66519f4a Googletest export
ed3f9bb22960 Googletest export
85c4172ed66e Update README.md
7515e399436a Googletest export
9ab640ce5e51 Googletest export
e26a3fa13ca2 Googletest export
9494c45e75a5 Googletest export
a83cc11abe48 Googletest export
b93a13ec4db4 Improvements have been made to the example/sample makefiles
             for both googlemock and googletest. Library files are now
             created and named like versions produced by Cmake
34a99e547ab7 Googletest export
4160336cb433 Merge pull request #2013 from ciband:chore/fix_library_json
150613166524 Update README.md
c0ef2cbe42df fix:  Correct GitHub paths
16269ae2f857 Merge pull request #2027 from ciband:chore/fix_library_json
77004096e850 Update README.md
6729a1361150 Merge #2002
0cf2130c0b59 Update Xcode project file
3bedb5a9fc36 Merge pull request #2035 from syohex/update-xcode-project-
             file
6d5ce40d4c27 fix:  Add additional source and include directories
de99386b67a3 Merge branch 'chore/fix_library_json' of
             https://github.com/ciband/googletest into
             chore/fix_library_json
25905b9f9a45 Merge branch 'master' of
             https://github.com/google/googletest
2ace910a3580 Revert "test, please ignore"
8ed34e0f6b4e Remove outdated scripts
933e5df28372 Merge pull request #2039 from gennadiycivil/master
f8b1c1af1775 Googletest export
14c2fba7349e Googletest export
1bcbd5871e34 Merge pull request #2037 from ciband:chore/fix_library_json
bfcc47fc2f61 Merge pull request #2026 from
             justin6case/example_makefile_improvements
8a27d164cbc7 Update README.md
6e410a3ae965 Update README.md
ac8c102dae66 Update README.md
3a460a26b7a9 Googletest export
827515f8a092 Googletest export
5d3a2cd9c854 Update docs, TestCase->TestSuite
58e62f7a989c Merge branch 'master' of
             https://github.com/google/googletest
3880b13e4c0b Merge pull request #2042 from gennadiycivil/master
ade8baa7d213 clang-tidy: modernize-deprecated-headers
8369b5bbd0dd fixing build errors for unused parameter
b6cd405286ed Googletest export
644319b9f06f Merge pull request #2048 from ciband:chore/clang_tidy
216c37f057ae Googletest export
f31bf1d362af Googletest export
50f1a77955bd Merge pull request #2051 from enptfb55:master
7a7e2bba1d62 Googletest export
bc1023b4131c Googletest export
6693e85b0402 Merge branch 'master' of github.com:google/googletest
2edadcedf350 Workaround homebrew issue
0599a7b8410d Googletest export
097407fd3cfb Googletest export
9acd065a905a Googletest export
eb9225ce361a Googletest export
0adeadd28302 Googletest export
9518a57428ae Googletest export

Change-Id: I2029f907549bed52816fd3660be5b77ad19e73c9
Reviewed-on: https://chromium-review.googlesource.com/c/1427241
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2019-01-22 20:57:37 +00:00
Scott Graham
25048d37f8 fuchsia: Remove log.cpp and log.h
zx_log_ is being removed in favour of zx_debuglog_, and so log.h/cpp
will also be going.

Bug: fuchsia:ZX-2184
Change-Id: I4f342d05716745d1248fe1de6e7cd2f92ff1dea3
Reviewed-on: https://chromium-review.googlesource.com/c/1407534
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2019-01-11 23:27:14 +00:00
Tom Tan
761c6fe8be Add Windows ARM64 support to Chromium crashpad
Bug: chromium:893460
Change-Id: Ifbeb6f937a6b96c77b02dcf8afe492c5bc617435
Reviewed-on: https://chromium-review.googlesource.com/c/1347773
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2018-12-12 21:54:55 +00:00
Francois Rousseau
3ca0713430 roll googletest to b18d39
* 71d4fc is the change fixing death tests on Fuchsia where the exception was still caught by the system exception handler
* we need up to b18d39 to make Windows happy

Change-Id: Ic938caabe3dde93ebda520b389b166d78c4460a6
Reviewed-on: https://chromium-review.googlesource.com/c/1350931
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
2018-11-26 23:52:28 +00:00
Joshua Peraza
dc0052bd43 Fuchsia: Use SDK manifest for CC prebuilt and source packages
Upstreams:
https://chromium-review.googlesource.com/c/chromium/src/+/1292570

Change-Id: I366651f57076dd0e854daa6f23a6dfa47babf60d
Reviewed-on: https://chromium-review.googlesource.com/c/1315432
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-11-02 17:30:22 +00:00
Braden Kell
5dd094381c [sysinfo] Convert sysinfo ioctls to FIDL calls
Bug: fuchsia:ZX-2842

Change-Id: Ib84b4319d3bb07a2c68bc2ff0d63e49fa65eb2b5
Reviewed-on: https://chromium-review.googlesource.com/c/1292237
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-10-29 20:24:55 +00:00
Vyacheslav Egorov
bf327d8ceb Introduce "dart" dependencies configuration for embedding into Dart VM.
This configuration has the following dependencies layout:

* gtest should be pulled from //third_party/googletest
* zlib from //third_party/zlib
* base from //third_party/mini_chromium/mini_chromium/base
* Windows build configs come from //build/config/win:*.

Bug: crashpad:
Change-Id: I22b44d4f85349383063bf3785a321e3c23d88853
Reviewed-on: https://chromium-review.googlesource.com/c/1291378
Commit-Queue: Vyacheslav Egorov <vegorov@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-10-22 17:35:35 +00:00
Wez
bc50af15a2 Migrate from ScopedZxHandle to libzx containers.
Bug: chromium:852541
Change-Id: Ie05c70f249e6f843183a02ec61fd09f6a0607598
Reviewed-on: https://chromium-review.googlesource.com/1148923
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
2018-08-01 17:38:19 +00:00
Charly Delay
3072b4059f zlib.gyp: support the "external" dependency mode
This CL implements support for the external model for Crashpad's zlib
dependency, in which the dependencies and Crashpad are checked out as
sibling in the same directory.

Bug: crashpad:
Change-Id: I0ca640e0be9b6a4fd8379026dfc8eb061b40badf
Reviewed-on: https://chromium-review.googlesource.com/1124778
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-07-06 17:28:08 +00:00
Scott Graham
bff3594594 fuchsia: Update includes for new fdio header location
Also includes a gtest roll, which includes a change in gtest to do the
same thing. This also removes the link against launchpad which is no
longer necessary, and will be removed from the SDK soon.

Bug: crashpad:196, chromium:848028, chromium:850757
Change-Id: Ica8632a6157b585d6b44073e05bf7aa43253e305
Reviewed-on: https://chromium-review.googlesource.com/1096353
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-06-12 16:47:21 +00:00