3 Commits

Author	SHA1	Message	Date
Scott Graham	74a34e9c4b	win: Resolve zero-length array errors on MSVC ... In some cases, it's sufficient to move the zero-length array to the end of the structure. When the struct is used inside a class that is derived from however, this fails. In that case, switch to holding the object in a scoped_ptr. Longer winded version: https://groups.google.com/a/chromium.org/d/msg/crashpad-dev/NGZ6LwRMORM/nKcXKQ7inIEJ R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/896663006	2015-02-04 17:34:43 -08:00
Mark Mentovai	9386a054e2	minidump: Use the crashpad::internal namespace more appropriately. ... MinidumpLocationDescriptorListWriter and MinidumpRVAListWriter are implementation details and should be in the crashpad::internal namespace. MinidumpUTF16StringListWriter and MinidumpUTF8StringListWriter are accessible to outside code and should not be in this namespace. TEST=minidump_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/699313007	2014-11-07 11:45:44 -05:00
Mark Mentovai	a980409288	Add MinidumpRVAListWriter and test. ... This will be used as the foundation for writing a list of MinidumpUTF8String objects. MinidumpUTF8String (and UTF-16 MINIDUMP_STRING) objects are never referenced by MINIDUMP_LOCATION_DESCRIPTOR because they carry their own lengths. Instead, they are always referenced by RVA. The list of MinidumpUTF8String objects will be used for the module annotations vector. TEST=minidump_test MinidumpRVAListWriter.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/704333002	2014-11-07 09:44:09 -05:00