crashpad

3party/crashpad

Fork 0

mirror of https://github.com/chromium/crashpad.git synced 2025-01-04 12:45:26 +08:00

Commit Graph

Author	SHA1	Message	Date
Mark Mentovai	bb13efbda7	Add and use scoped-right-returning wrappers for Mach bootstrap routines This wraps bootstrap_check_in() in BootstrapCheckIn(), and bootstrap_look_up() in BootstrapLookUp(). The wrappers make it more difficult to accidentally leak a returned right. They’re easier to use, encapsulating common error checking and logging, simplifying all call sites. TEST=crashpad_util_test MachExtensions.BootstrapCheckInAndLookUp R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1383283003 .	2015-10-05 17:07:15 -04:00
Scott Graham	0b022d72a2	Include implicit_cast.h at all users of it. The implicit_cast in base will be no more, make sure we have a reference to the crashpad version at all callsites. BUG=529769, 472900, crashpad:51 R=mark@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/1344683002 .	2015-09-14 14:51:05 -07:00
Mark Mentovai	809ea8158d	test: Move util/test to its own top-level directory, test. After 9e79ea1da719, it no longer makes sense for crashpad_util_test_lib to “hide” in util/util_test.gyp. All of util/test is moved to its own top-level directory, test, which all other test code is allowed to depend on. test, too, is allowed to depend on all other non-test code. In a future change, when crashpad_util_test_lib gains a dependency on crashpad_client, it won’t look so weird for something in util (even though it’s in util/test) to depend on something in client, because the thing that needs to depend on client will live in test, not util. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1051533002	2015-03-31 17:44:14 -04:00

Author

SHA1

Message

Date

Mark Mentovai

bb13efbda7

Add and use scoped-right-returning wrappers for Mach bootstrap routines

This wraps bootstrap_check_in() in BootstrapCheckIn(), and
bootstrap_look_up() in BootstrapLookUp(). The wrappers make it more
difficult to accidentally leak a returned right. They’re easier to use,
encapsulating common error checking and logging, simplifying all call
sites.

TEST=crashpad_util_test MachExtensions.BootstrapCheckInAndLookUp
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1383283003 .

2015-10-05 17:07:15 -04:00

Scott Graham

0b022d72a2

Include implicit_cast.h at all users of it.

The implicit_cast in base will be no more, make sure we have a reference
to the crashpad version at all callsites.

BUG=529769, 472900, crashpad:51
R=mark@chromium.org, scottmg@chromium.org

Review URL: https://codereview.chromium.org/1344683002 .

2015-09-14 14:51:05 -07:00

Mark Mentovai

809ea8158d

test: Move util/test to its own top-level directory, test.

After 9e79ea1da719, it no longer makes sense for crashpad_util_test_lib
to “hide” in util/util_test.gyp. All of util/test is moved to its own
top-level directory, test, which all other test code is allowed to
depend on. test, too, is allowed to depend on all other non-test code.

In a future change, when crashpad_util_test_lib gains a dependency on
crashpad_client, it won’t look so weird for something in util (even
though it’s in util/test) to depend on something in client, because the
thing that needs to depend on client will live in test, not util.

BUG=crashpad:33
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1051533002

2015-03-31 17:44:14 -04:00

3 Commits