Mark Mentovai
|
8d36e3581c
|
minidump: Use variable names in tests that match parallel array indices.
Inspired by
https://codereview.chromium.org/637503006/diff/20001/minidump/minidump_thread_writer_test.cc#newcode409
TEST=minidump_test MinidumpMemoryWriter.*:MinidumpModuleWriter.*
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/643683003
|
2014-10-09 15:21:05 -04:00 |
|
Mark Mentovai
|
22350bd676
|
In tests, use ASSERT_NO_FATAL_FAILURE() instead of checking
testing::Test::HasFatalFailure() after calling functions that could fail
fatally.
Inspired by
https://codereview.chromium.org/637503006/diff/20001/minidump/minidump_thread_writer_test.cc#newcode437
TEST=client_test, minidump_test, util_test
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/640383002
|
2014-10-09 15:08:54 -04:00 |
|
Mark Mentovai
|
9c76cc60db
|
Pull test utilities from MinidumpMemoryWriter’s test out into their own file.
These utilities are also useful to MinidumpThreadWriter’s test.
TEST=minidump_test MinidumpMemoryWriter.*
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/639513002
|
2014-10-07 17:58:43 -04:00 |
|
Mark Mentovai
|
6d1af6922f
|
Don’t use using directives (“using namespace”) in tests.
The contents of tests are moved into the namespace
crashpad::test::(anonymous namespace).
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/635883002
|
2014-10-07 17:28:50 -04:00 |
|
Mark Mentovai
|
e0a79bec5e
|
MinidumpMemoryWriter test: Don’t suffix uint64_t constants.
It’s not necessary.
TEST=minidump_test MinidumpMemoryWriter
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/467323003
|
2014-08-13 15:27:33 -07:00 |
|
Mark Mentovai
|
0ba9d2b065
|
Add MinidumpModuleWriter, MinidumpModuleListWriter, related classes, and
their test.
TEST=minidump_test MinidumpModuleTest
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/460933004
|
2014-08-13 15:26:21 -07:00 |
|
Mark Mentovai
|
3b2c6d32f4
|
Add MinidumpMemoryWriter, MinidumpMemoryListWriter, and their test.
TEST=minidump_test MinidumpMemoryWriter
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/459973002
|
2014-08-12 10:26:40 -07:00 |
|