6 Commits

Author	SHA1	Message	Date
Mark Mentovai	22cf9e28d5	util_test: Don’t crash when run from the wrong location. ... When run from the wrong location and test data or other test programs can’t be found, the tests should fail with gtest assertions. The test executable should not crash. BUG=crashpad:4 TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/799083003	2014-12-15 16:40:16 -05:00
Mark Mentovai	525de2c35a	Use exactly one of final, override, and virtual. ... This change was generated mechanically by running: find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override final/\1 final/' {} + find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override/\1 override/' {} + Additional changes were made manually based on: git grep -E '^ {3,}.*override[;{]' http://google-styleguide.googlecode.com/svn/trunk/cppguide.html?showone=The__define_Guard#Inheritance TEST=*_test BUG= R=rsesek@chromium.org Review URL: https://codereview.chromium.org/654933002	2014-10-14 11:11:57 -04:00
Mark Mentovai	5d74f120fc	Convert NULL to nullptr. ... This change was generated mechanically by running: find . \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* \ -exec sed -i '' -E -e 's/(^|[^_])NULL/\1nullptr/g' {} + Further manual fix-ups were applied to remove casts of nullptr to other pointer types where possible, to preserve the intentional use of NULL (as a short form of MACH_PORT_NULL) in exception_port_tool, and to fix 80-column violations. https://groups.google.com/a/chromium.org/d/topic/chromium-dev/4mijeJHzxLg/discussion TEST=*_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/656703002	2014-10-14 11:10:45 -04:00
Mark Mentovai	6d1af6922f	Don’t use using directives (“using namespace”) in tests. ... The contents of tests are moved into the namespace crashpad::test::(anonymous namespace). https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces R=rsesek@chromium.org Review URL: https://codereview.chromium.org/635883002	2014-10-07 17:28:50 -04:00
Mark Mentovai	eeaf460f82	Add and use CheckedReadFD(), CheckedWriteFD(), and CheckedReadFDAtEOF(). ... TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/577333002	2014-09-18 15:03:49 -04:00
Mark Mentovai	52064fdd1b	Add the MultiprocessExec test and its test. ... TEST=util_test MultiprocessExec.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/531203002	2014-09-03 18:24:29 -04:00