4 Commits

Author	SHA1	Message	Date
Mark Mentovai	22350bd676	In tests, use ASSERT_NO_FATAL_FAILURE() instead of checking ... testing::Test::HasFatalFailure() after calling functions that could fail fatally. Inspired by https://codereview.chromium.org/637503006/diff/20001/minidump/minidump_thread_writer_test.cc#newcode437 TEST=client_test, minidump_test, util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/640383002	2014-10-09 15:08:54 -04:00
Mark Mentovai	6d1af6922f	Don’t use using directives (“using namespace”) in tests. ... The contents of tests are moved into the namespace crashpad::test::(anonymous namespace). https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces R=rsesek@chromium.org Review URL: https://codereview.chromium.org/635883002	2014-10-07 17:28:50 -04:00
Mark Mentovai	9168ba47ac	Fix minidump_module_writer_test 32-bit x86 build. ... time_t is a typedef for long on Mac OS X. In 32-bit x86 (ILP32), long is a signed 32-bit quantity, and its range does not contain the range of uint32_t, used to store times in time_t fashion in minidump files. A cast is necessary to make these EXPECT_* macros do the right thing. This is not a problem in x86_64 (LP64) where long is a signed 64-bit quantity, which does contain the range of uint32_t. clang’s error was “error: comparison of integers of different signs: 'const long' and 'const unsigned int' [-Werror,-Wsign-compare]” BUG= R=rsesek@chromium.org Review URL: https://codereview.chromium.org/491023005	2014-08-20 18:32:06 -04:00
Mark Mentovai	0ba9d2b065	Add MinidumpModuleWriter, MinidumpModuleListWriter, related classes, and ... their test. TEST=minidump_test MinidumpModuleTest R=rsesek@chromium.org Review URL: https://codereview.chromium.org/460933004	2014-08-13 15:26:21 -07:00