9 Commits

Author	SHA1	Message	Date
Mark Mentovai	b8cbfff0d3	test::Multiprocess: exit cleanly from children with _exit(). ... Child exits were using exit(), which caused crashes on 10.10 for Multiprocess-based tests that ran after HTTPTransport tests. The crashes occurred while running exit-time destructors. exit() was never correct in this situation, this should have used _exit() all along. TEST=crashpad_util_test BUG=crashpad:17 R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1000653002	2015-03-11 13:59:46 -04:00
Scott Graham	d77461acd0	Missed change in http://crrev.com/880763002, remove const from info() ... Oops, forgot to do this before landing. R=mark@chromium.org TBR=mark@chromium.org BUG=crashpad:7 Review URL: https://codereview.chromium.org/885663004	2015-01-28 15:00:46 -08:00
Scott Graham	892c29e8ba	Reorganize Multiprocess and implement for Windows ... - Various "FD" to "Handle" - Existing Multiprocess implementation moves to _posix. - Stub implementation for _win. At the moment, multiprocess_exec_win.cc contains implementations of both Multiprocess methods and MultiprocessExec functions. This will need more work in the future, but reflects the idea that all tests should be in terms of MultiprocessExec eventually. Currently, this works sufficiently to have util_test succeed (including multiprocess_exec_test, and the recently ported HTTPTransport tests.) R=mark@chromium.org BUG=crashpad:1, crashpad:7 Review URL: https://codereview.chromium.org/880763002	2015-01-28 14:49:42 -08:00
Mark Mentovai	525de2c35a	Use exactly one of final, override, and virtual. ... This change was generated mechanically by running: find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override final/\1 final/' {} + find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override/\1 override/' {} + Additional changes were made manually based on: git grep -E '^ {3,}.*override[;{]' http://google-styleguide.googlecode.com/svn/trunk/cppguide.html?showone=The__define_Guard#Inheritance TEST=*_test BUG= R=rsesek@chromium.org Review URL: https://codereview.chromium.org/654933002	2014-10-14 11:11:57 -04:00
Mark Mentovai	22350bd676	In tests, use ASSERT_NO_FATAL_FAILURE() instead of checking ... testing::Test::HasFatalFailure() after calling functions that could fail fatally. Inspired by https://codereview.chromium.org/637503006/diff/20001/minidump/minidump_thread_writer_test.cc#newcode437 TEST=client_test, minidump_test, util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/640383002	2014-10-09 15:08:54 -04:00
Mark Mentovai	c93fcf8278	In MachMultiprocess-based tests, the child must wait for the parent to ... finish. It was possible for the child process to exit before the parent had a chance to complete the pid_for_task() portion of its verification. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/586053002	2014-09-22 13:06:12 -04:00
Mark Mentovai	7fdc7f277e	Add Multiprocess::SetExpectedChildTermination(). ... An expectation of the child’s termination reason can now be specified. It is now possible to test with children that do not exit cleanly, if they are not expected to exit cleanly. TEST=util_test Multiprocess.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/553153002	2014-09-09 17:04:47 -04:00
Mark Mentovai	52064fdd1b	Add the MultiprocessExec test and its test. ... TEST=util_test MultiprocessExec.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/531203002	2014-09-03 18:24:29 -04:00
Mark Mentovai	ff26ea6db9	Refactor MachMultiprocess into a Multiprocess base class without any ... knowledge of Mach. MachMultiprocess builds on this new base class. TEST=util_test MachMultiprocess.*:Multiprocess.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/506143002	2014-08-26 17:10:19 -04:00