5 Commits

Author	SHA1	Message	Date
Mark Mentovai	26804a0be1	Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures. ... Likewise for EXPECT_DEATH_CHECK() and EXPECT_DEATH(). In the in-Chromium build configured for official builds in Release mode, CHECK() throws away its condition string and stream parameters without ever printing them, although it still evaluates the condition and triggers death appropriately. {ASSERT,EXPECT}_DEATH(statement, regex) will not work correctly for any regex that attempts to match what CHECK() prints. In these build configurations, {ASSERT,EXPECT}_DEATH_CHECK() use a match-all regex (""). In other build configurations, they transparently wrap {ASSERT,EXPECT}_DEATH(). BUG=crashpad:12 R=rsesek@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/992693003	2015-03-09 18:02:14 -04:00
Mark Mentovai	de0979b930	C++11: Use type aliases instead of typedefs. ... This replaces all occurrences of “typedef Y X;” with “using X = Y;”. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/700143004	2014-11-05 14:09:01 -05:00
Mark Mentovai	5d74f120fc	Convert NULL to nullptr. ... This change was generated mechanically by running: find . \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* \ -exec sed -i '' -E -e 's/(^|[^_])NULL/\1nullptr/g' {} + Further manual fix-ups were applied to remove casts of nullptr to other pointer types where possible, to preserve the intentional use of NULL (as a short form of MACH_PORT_NULL) in exception_port_tool, and to fix 80-column violations. https://groups.google.com/a/chromium.org/d/topic/chromium-dev/4mijeJHzxLg/discussion TEST=*_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/656703002	2014-10-14 11:10:45 -04:00
Mark Mentovai	6d1af6922f	Don’t use using directives (“using namespace”) in tests. ... The contents of tests are moved into the namespace crashpad::test::(anonymous namespace). https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces R=rsesek@chromium.org Review URL: https://codereview.chromium.org/635883002	2014-10-07 17:28:50 -04:00
Mark Mentovai	b980a5984b	Add SimpleStringDictionary and its test. ... TEST=client_test SimpleStringDictionary*.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/489993002	2014-08-22 13:52:28 -04:00