4 Commits

Author	SHA1	Message	Date
Mark Mentovai	38aeadc1c1	minidump: Use forward declarations in more places. ... TEST=minidump_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/679443002	2014-10-23 18:47:27 -04:00
Mark Mentovai	44a839614b	minidump: Annotate existing virtual destructors that override a base ... class virtual destructor with “override”. TEST=minidump_test MinidumpContextWriter.*:MinidumpModuleWriter.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/675783006	2014-10-23 18:42:26 -04:00
Mark Mentovai	525de2c35a	Use exactly one of final, override, and virtual. ... This change was generated mechanically by running: find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override final/\1 final/' {} + find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override/\1 override/' {} + Additional changes were made manually based on: git grep -E '^ {3,}.*override[;{]' http://google-styleguide.googlecode.com/svn/trunk/cppguide.html?showone=The__define_Guard#Inheritance TEST=*_test BUG= R=rsesek@chromium.org Review URL: https://codereview.chromium.org/654933002	2014-10-14 11:11:57 -04:00
Mark Mentovai	cb2288d174	Add MinidumpContext (X86 and AMD64 variants) and their writers. ... These are fairly simple classes and it’s not valuable to test them individually. They will be tested as part of MinidumpThreadWriter and MinidumpExceptionWriter. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/593583004	2014-09-24 13:34:45 -04:00