3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-29 08:39:44 +08:00
Code Issues Projects Releases Wiki Activity
764 Commits 4 Branches 0 Tags 18 MiB
Commit Graph

3 Commits

Author SHA1 Message Date
Mark Mentovai
5be8ce4ea0 Get module versions and types from in-memory images 
Don't call GetFileVersionInfo(), which calls LoadLibrary() to be able to
access the module's resources. Loading modules from the crashy process
into the handler process can cause trouble. The Crashpad handler
definitely doesn't want to run arbitrary modules' module initializer
code.

Since the VS_FIXEDFILEINFO needed is already in memory in the remote
process' address space, just access it from there.

BUG=crashpad:78
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1475023004 .
 2015-12-01 17:06:37 -05:00
Mark Mentovai
116e1087f0 win: Don't warn when no VERSIONINFO resource is present in a module 
Modules will work without a VERSIONINFO resource. This happens in some
of Crashpad's tests.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1467993003 .
 2015-11-23 16:17:50 -05:00
Scott Graham
b0889f61ee win: Retrieve module version/type information 
Refactor version retrieval from system snapshot to use when
retrieving the module version information.

Follows https://codereview.chromium.org/1133203002/.

R=cpu@chromium.org, rsesek@chromium.org
TBR=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/1126273003
 2015-05-14 17:43:49 -07:00