4 Commits

Author	SHA1	Message	Date
Scott Graham	6865865773	Change 'bool world_readable' to an enum ... More clear at callsites, and relatively important not to accidentally choose the wrong one. R=mark@chromium.org Review URL: https://codereview.chromium.org/821483002	2014-12-19 15:35:30 -08:00
Scott Graham	384497475a	Add LoggingSeekFile ... As the whence values are "helpfully" available in windows.h as well ( http://msdn.microsoft.com/en-us/library/windows/desktop/dd757336(v=vs.85).aspx ) don't bother inventing a new enum. Add implementations for POSIX and Win32. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/812593005	2014-12-19 10:45:22 -08:00
Scott Graham	4034d30023	Add LoggingOpenFileFor{Read|Write} ... I started (https://codereview.chromium.org/812403002/) emulating oflag values on Windows in FileWriter, but it seemed awkward. On the assumption that we're only likely to need "read a file" and "write a file" this seemed simpler, and sufficient (but I don't know if that's necessarily true). Users of open are not yet switched. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/818433002	2014-12-18 16:29:33 -08:00
Scott Graham	10165ce449	Cross platform low level file IO wrappers ... Rename fd_io to file_io, and ReadFD to ReadFile, etc. file_io.cc is the higher level versions that call the basic ReadFile/WriteFile and then file_io_posix.cc and file_io_win.cc are the implementations of those functions. The Windows path is as yet untested, lacking the ability to link the test binary. R=cpu@chromium.org, mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/811823003	2014-12-17 14:35:18 -08:00