20 Commits

Author SHA1 Message Date
Mark Mentovai
a5a1c3b07f Add .style.yapf and reformat according to yapf, using “google” style
% yapf --in-place $(git ls-files **/*.py)
% yapf --version
yapf 0.30.0

Note that this is not using the “chromium” yapf style because Chromium
is moving to PEP-8.
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/RcJgJdkNIdg
yapf 0.30.0 no longer recognizes “chromium” as a style option.
22ef70f3c4
Since this is a mass reformatting, it might as well move things all the
way into the future all at once.

This uses the “google” style, which is a superset of “pep8”.

Change-Id: Ifa37371079ea1859e4afe8e31d2eef2cfd7af384
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2165637
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2020-04-27 13:59:09 +00:00
Rohit Rao
6b81e8173f Removes the obsolete cq.cfg file.
The authoritative version of this config now lives in "commit-queue.cfg"
on the origin/infra/config branch.

This config was migrated in:
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1436767

BUG=916292

Change-Id: Ie49028d043775e789fb948b24485c45d168720c3
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1953363
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
2019-12-05 17:52:14 +00:00
Scott Graham
a008d8a151 Make Windows bots non-experimental
In the transition from Buildbot to LUCI, the Windows bots were
temporarily marked experimental. They should not be and should block the
CQ if failing.

Bug: crashpad:264
Change-Id: I781d70b323fb34209916f46c0dcf2235a95876fa
Reviewed-on: https://chromium-review.googlesource.com/c/1318386
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-11-05 19:20:53 +00:00
Scott Graham
2951fbde52 Remove cq_name from cq.cfg, no longer required/allowed
Also add cq PRESUBMIT to validate future changes.

TBR=iannucci@chromium.org
Bug: chromium:892712
Change-Id: Ia2b3fe9550857939843fda738068aabec26942e2
Reviewed-on: https://chromium-review.googlesource.com/c/1289715
Reviewed-by: Scott Graham <scottmg@chromium.org>
2018-10-18 22:33:43 +00:00
Scott Graham
196897eb08 Remove win buildbot bots from cq config
TBR=iannucci@chromium.org

Bug: chromium:892712
Change-Id: I11af294ec2d088dc6e846291102077a9fa74d663
Reviewed-on: https://chromium-review.googlesource.com/c/1289714
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-10-18 22:15:38 +00:00
Ryan Tseng
42b57efa55 CQ: Flip all builders except Windows to LUCI
Bug: 865729
Change-Id: I73ed47339c3374d86ee82609a18a4e728c601ab1
Reviewed-on: https://chromium-review.googlesource.com/1153610
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
2018-07-27 20:59:17 +00:00
Ryan Tseng
1e662c2fcb [cq.cfg] Add all luci trybots as experimental
Bug: 865729
Change-Id: I5236736803de19cf242a3ae9657b99a03420b08c
Reviewed-on: https://chromium-review.googlesource.com/1150905
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
2018-07-27 00:06:05 +00:00
Scott Graham
17dff19b21 fuchsia: Re-enable the trybots in compile-only config; enable arm64
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1111016
makes the bots compile-only which is better than not having them on at
all, until we have a reliable way to run the tests.

Additionally, flip on the arm64 builders.

Bug: crashpad:219
Change-Id: If61fe9d3e569996119c09499599d197070b8c358
Reviewed-on: https://chromium-review.googlesource.com/1111020
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-06-21 22:55:27 +00:00
Scott Graham
71d9060882 Add Linux trybots to CQ
Bug: crashpad:220
Change-Id: I46e470ba6966f4b07165fc30828f2a0387444a29
Reviewed-on: https://chromium-review.googlesource.com/941510
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-02-28 21:30:44 +00:00
Scott Graham
8a12f58930 fuchsia: Take bots off CQ pending flake investigation
Bug: crashpad:219
Change-Id: I98c4edbff5e5739aa3f4bb89e2e0ecf2f79206bf
Reviewed-on: https://chromium-review.googlesource.com/937809
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-02-26 17:41:58 +00:00
Scott Graham
4a9d422652 Turn fuchsia trybots on by default
All currently compiled-in/enabled tests should be reliably passing now,
so add Fuchsia bots to the CQ. (Of course, there's a lot of
functionality still compiled out).

Bug: crashpad:196
Change-Id: I1544798afefd6a505200c9ae38253d73eb6497ef
Reviewed-on: https://chromium-review.googlesource.com/923425
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-02-16 22:16:18 +00:00
Scott Graham
a483e2c599 Fix names of Windows trybots after server-side rename
Bug: crashpad:79
Change-Id: I1836b1e5aec8e772e9ff48a52b0ad755bb1894ab
Reviewed-on: https://chromium-review.googlesource.com/909861
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-02-08 22:43:16 +00:00
Mark Mentovai
20e5aba1af URL cleanups: switch to HTTPS, fix dead ones, use canonical ones
Change-Id: I4b247d7fae1a212350f8ffcf2bf5ba1fa730f5c1
Reviewed-on: https://chromium-review.googlesource.com/780339
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-11-20 22:23:39 +00:00
Dirk Pranke
c9319008b6 Disable the win x86 tests in the CQ until they are swarmed.
R=mark@chromium.org
BUG=743139

Change-Id: I1c50807b31bbb3136b28407a4853ff6950df8c88
Reviewed-on: https://chromium-review.googlesource.com/585413
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-07-29 22:14:51 +00:00
Dirk Pranke
1d443b8223 Revert "Switch CQ to use the new swarmbucket (LUCI) builders."
This reverts commit a06ca92083f517843b05a0047d14c57002f417c1.

Reason for revert: Roll back to buildbot for now.

Original change's description:
> Switch CQ to use the new swarmbucket (LUCI) builders.
> 
> This updates the crashpad CQ config to use the builders
> configured in https://chromium-review.googlesource.com/c/580607/.
> 
> TBR=mark@chromium.org
> BUG=743139
> 
> Change-Id: I29ae95f9d29630ba4522467efefe058548da623b
> Reviewed-on: https://chromium-review.googlesource.com/592849
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

TBR=dpranke@chromium.org,mark@chromium.org

Change-Id: I7ea1d019f47c6cc3065fcbc7eed68f834a4f2b35
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 743139
Reviewed-on: https://chromium-review.googlesource.com/592792
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
2017-07-29 21:54:44 +00:00
Dirk Pranke
a06ca92083 Switch CQ to use the new swarmbucket (LUCI) builders.
This updates the crashpad CQ config to use the builders
configured in https://chromium-review.googlesource.com/c/580607/.

TBR=mark@chromium.org
BUG=743139

Change-Id: I29ae95f9d29630ba4522467efefe058548da623b
Reviewed-on: https://chromium-review.googlesource.com/592849
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
2017-07-29 21:03:11 +00:00
Mark Mentovai
d9ca2ad21f Give group project-crashpad-tryjob-access access to the commit queue
Bug: chromium:717982
Change-Id: I826f7520409656f5f549a110895e46de111d17f4
Reviewed-on: https://chromium-review.googlesource.com/494666
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-05-03 16:00:30 +00:00
Sigurdur Asgeirsson
440b7e2374 Additional setup required for Gerrit projects.
BUG=crashpad:162

Change-Id: I9150af280a22e10cecad093bb6a798f79834f50e
Reviewed-on: https://chromium-review.googlesource.com/448758
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-03-02 18:21:37 +00:00
Sigurdur Asgeirsson
622e8dd1b5 Specify gerrit, as it's mandatory to specify either or both of gerrit/rietveld.
BUG=crashpad:162

Change-Id: Ic737a7d04ad57bfa358529ea8fd5e4729ba31fbd
Reviewed-on: https://chromium-review.googlesource.com/448625
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-03-02 17:23:53 +00:00
Sigurdur Asgeirsson
ae8fe2d1f5 Add CQ configuration to Crashpad.
BUG=crashpad:162

Change-Id: Iebde2e89a18ff4f6e6fc728f137ca8f5aae040b2
Reviewed-on: https://chromium-review.googlesource.com/448624
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-03-02 15:20:13 +00:00