Mark Mentovai
b666bcbe98
win: Use signed int as the integer representation of HANDLEs
...
HandleToInt() and IntToHandle() use int, a signed type, for the 32-bit
integer representation of HANDLE values. For opaque values, an unsigned
type would normally be used, but in this case, signed was chosen for
sign extension to work correctly. INVALID_HANDLE_VALUE is defined as
((HANDLE)(LONG_PTR)-1), and this needs to round-trip through the chosen
integer representation back to the same HANDLE value. Sign extension is
also recommended by
https://msdn.microsoft.com/en-us/library/windows/desktop/aa384203 .
As suggested in
https://codereview.chromium.org/1422503015/diff/1/util/win/handle.cc#newcode24
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/1422023010 .
2015-11-06 15:03:13 -05:00
Scott Graham
e75e8c800f
win: Lower integrity level of connection pipe
...
This is necessary to be able to connect to crashpad_handler from a
Chrome renderer.
R=jschuh@chromium.org , mark@chromium.org
BUG=chromium:546288
Review URL: https://codereview.chromium.org/1405093013 .
2015-11-06 10:43:39 -08:00
Mark Mentovai
2eeaa3ac54
win: Add HandleToInt() and IntToHandle()
...
This consolidates all of the twisted casts and comments that discuss how
HANDLEs are really only 32 bits wide even in 64-bit processes on 64-bit
operating systems into a single location.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/1422503015 .
2015-11-05 14:00:26 -05:00
Scott Graham
6082aed2f2
win: Get Crashpad compiling under VS2015
...
R=mark@chromium.org
BUG=crashpad:1, chromium:440500
Review URL: https://codereview.chromium.org/1357833002 .
2015-09-21 10:51:15 -07:00
Scott Graham
754cc3609c
win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32
...
(CL to add x86 bots to waterfall in progress too.)
R=mark@chromium.org
BUG=crashpad:49
Review URL: https://codereview.chromium.org/1325173002 .
2015-09-02 18:35:19 -07:00
Erik Wright
263582c2d0
Refactor multiprocess test code to allow multiple child processes to be launched.
...
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/1164453003 .
2015-07-31 12:31:58 -04:00
