Mark Mentovai
|
22350bd676
|
In tests, use ASSERT_NO_FATAL_FAILURE() instead of checking
testing::Test::HasFatalFailure() after calling functions that could fail
fatally.
Inspired by
https://codereview.chromium.org/637503006/diff/20001/minidump/minidump_thread_writer_test.cc#newcode437
TEST=client_test, minidump_test, util_test
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/640383002
|
2014-10-09 15:08:54 -04:00 |
|
Mark Mentovai
|
6d1af6922f
|
Don’t use using directives (“using namespace”) in tests.
The contents of tests are moved into the namespace
crashpad::test::(anonymous namespace).
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/635883002
|
2014-10-07 17:28:50 -04:00 |
|
Mark Mentovai
|
8fe32b7b9c
|
Add mac_util, including MacOSXMinorVersion(), MacOSXVersion(), and
MacModelAndBoard(), along with their tests.
TEST=util_test MacUtil.*
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/473023002
|
2014-08-15 22:33:14 -07:00 |
|