3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-01-01 10:50:29 +08:00
Code Issues Projects Releases Wiki Activity
983 Commits 4 Branches 0 Tags 18 MiB
Commit Graph

4 Commits

Author SHA1 Message Date
Scott Graham
6b09b08a22 Update util/file/string_file.cc for new base/numerics API 
The code was not incorrect before, but this expression is simpler.
Upstream of change made at https://codereview.chromium.org/2528243002.

R=mark@chromium.org
BUG=chromium:668713

Change-Id: Idae36bd8312666a3254eda02713869776fec0248
Reviewed-on: https://chromium-review.googlesource.com/417981
Reviewed-by: Mark Mentovai <mark@chromium.org>
 2016-12-07 22:59:35 +00:00
Scott Graham
3d598cdbcd Change file op |ssize_t|s to FileOperationResult 
R=mark@chromium.org

Review URL: https://codereview.chromium.org/1416493006 .
 2015-10-22 16:14:18 -07:00
Scott Graham
0b022d72a2 Include implicit_cast.h at all users of it. 
The implicit_cast in base will be no more, make sure we have a reference
to the crashpad version at all callsites.

BUG=529769, 472900, crashpad:51
R=mark@chromium.org, scottmg@chromium.org

Review URL: https://codereview.chromium.org/1344683002 .
 2015-09-14 14:51:05 -07:00
Mark Mentovai
583233cf78 Add FileReaderInterface. Move StringFileWriter to StringFile and 
implement the new interface.

The upcoming minidump reader will get minidump data from a
FileReaderInterface. For ease of testing, a string-based implementation
is provided. There wasn’t a good reason to have a separate
StringFileReader and StringFileWriter, so I combined them into a single
StringFile.

TEST=util_test StringFile.*
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/936153002
 2015-02-18 14:15:38 -05:00