Scott Graham
8272a4cefe
Use LockFile/UnlockFile for Settings to port to Windows
...
Adds LoggingOpenFileForReadAndWrite, LoggingTruncateFile, and UUID::GenerateFromSystem
in support.
R=mark@chromium.org , rsesek@chromium.org
BUG=crashpad:13
Review URL: https://codereview.chromium.org/999953002
2015-04-20 14:21:48 -07:00
Mark Mentovai
58c7519598
Add a magic number to settings.dat for better identification.
...
“1” is probably one of the more common things for files to begin with.
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/1007433003
2015-03-12 19:34:05 -04:00
Robert Sesek
995e762a45
Use new ScopedGeneric move support.
...
BUG=crashpad:14
R=mark@chromium.org
Review URL: https://codereview.chromium.org/1001713002
2015-03-12 09:47:55 -04:00
Mark Mentovai
bdcc1e7625
Return a FilePath from Settings::file_path().
...
This makes it possible to #include "client/settings.h" for the interface
even on Windows. Although Settings is not currently implemented on
Windows (bug crashpad:13), it’s easier to have the interface declaration
available without having to have it be guarded.
TEST=crashpad_client_test SettingsTest.*
BUG=
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/987383002
2015-03-10 14:26:24 -04:00
Robert Sesek
e4c8b6cc72
Fix Settings::OpenForReadingAndWriting using O_CREAT with no mode.
...
R=mark@chromium.org
Review URL: https://codereview.chromium.org/997613002
2015-03-10 13:52:19 -04:00
Robert Sesek
1a635e3a79
Define the Settings interface for a CrashReportDatabase and provide a Mac implementation.
...
R=mark@chromium.org
Review URL: https://codereview.chromium.org/988063003
2015-03-09 18:47:52 -04:00
