9 Commits

Author	SHA1	Message	Date
Mark Mentovai	45993a6959	minidump: Fix InitializeFromSnapshot() comments for module lists. ... These classes don’t really have “mutators” other than their singular AddModule() methods, and the documentation is clearer when revised in this way. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/691853002	2014-10-30 17:26:56 -04:00
Mark Mentovai	4299ab3c4c	Add MinidumpMemoryListWriter::AddFromSnapshot(), everything downstream, ... and its test. TEST=minidump_test MinidumpMemoryWriter.AddFromSnapshot R=rsesek@chromium.org Review URL: https://codereview.chromium.org/641603006	2014-10-30 17:15:49 -04:00
Mark Mentovai	f7b38a9dd9	minidump: Fix InitializeFromSnapshot() comments for module lists. ... These classes don’t really have “mutators” other than their singular AddModule() methods, and the documentation is clearer when revised in this way. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/691853002	2014-10-30 14:51:40 -04:00
Mark Mentovai	84b44610cf	minidump: Add InitializeFromSnapshot() for MinidumpModuleWriter and ... MinidumpModuleListWriter. TEST=minidump_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/682263002	2014-10-29 11:38:49 -04:00
Mark Mentovai	0a4ea0b52d	minidump: Change the ownership model. ... All minidump objects now own their all of their children, rather than having them maintain weak pointers and requiring callers to maintain ownership. The only weak object in the entire tree now is the “extra memory” added to a MinidumpMemoryListWriter by its AddExtraMemory() method. Extra memory aliases objects owned elsewhere in the tree, typically by a MinidumpThreadWriter as stack memory. Non-“extra” memory added to a MinidumpMemoryListWriter by its AddMemory() method is strongly owned. Many objects are now deleted through base pointers, and in those cases, the base classes now have public virtual destructors. The ultimate base, MinidumpWritable, is still protected to guard against direct instantiation and deletion, and thus its destructor does not need to be virtual. This updates mini_chromium to eeb3b6a4f020 specifically for that revision, which includes necessary updates to scoped_ptr. It also picks up: eeb3b6a4f020 Update base/move.h and base/memory/scoped_ptr.h to match 67ad2efafaba More porting to Windows be27a006421e AUTHORS: Fix link post-git migration flag day. 05f5b1503230 Add codereview.settings to mini_chromium. a32c2b199811 Beginnings of Windows support in mini_chromium TEST=minidump_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/674153002	2014-10-27 15:01:39 -04:00
Mark Mentovai	38aeadc1c1	minidump: Use forward declarations in more places. ... TEST=minidump_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/679443002	2014-10-23 18:47:27 -04:00
Mark Mentovai	44a839614b	minidump: Annotate existing virtual destructors that override a base ... class virtual destructor with “override”. TEST=minidump_test MinidumpContextWriter.*:MinidumpModuleWriter.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/675783006	2014-10-23 18:42:26 -04:00
Mark Mentovai	525de2c35a	Use exactly one of final, override, and virtual. ... This change was generated mechanically by running: find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override final/\1 final/' {} + find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override/\1 override/' {} + Additional changes were made manually based on: git grep -E '^ {3,}.*override[;{]' http://google-styleguide.googlecode.com/svn/trunk/cppguide.html?showone=The__define_Guard#Inheritance TEST=*_test BUG= R=rsesek@chromium.org Review URL: https://codereview.chromium.org/654933002	2014-10-14 11:11:57 -04:00
Mark Mentovai	0ba9d2b065	Add MinidumpModuleWriter, MinidumpModuleListWriter, related classes, and ... their test. TEST=minidump_test MinidumpModuleTest R=rsesek@chromium.org Review URL: https://codereview.chromium.org/460933004	2014-08-13 15:26:21 -07:00