Mark Mentovai
bcae4d94d5
Create snapshot/mac and move some files from snapshot and util to there.
...
TEST=snapshot_test, util_test CheckedMachAddressRange.*
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/666483002
2014-10-17 13:41:45 -04:00
Mark Mentovai
525de2c35a
Use exactly one of final, override, and virtual.
...
This change was generated mechanically by running:
find . \
\( -name \*.cc -or -name \*.mm -or -name \*.h \) \
-and -not -path ./third_party/\* -and -not -path ./out/\* -exec \
sed -i '' -E -e 's/virtual (.*) override final/\1 final/' {} +
find . \
\( -name \*.cc -or -name \*.mm -or -name \*.h \) \
-and -not -path ./third_party/\* -and -not -path ./out/\* -exec \
sed -i '' -E -e 's/virtual (.*) override/\1 override/' {} +
Additional changes were made manually based on:
git grep -E '^ {3,}.*override[;{]'
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html?showone=The__define_Guard#Inheritance
TEST=*_test
BUG=
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/654933002
2014-10-14 11:11:57 -04:00
Mark Mentovai
5d74f120fc
Convert NULL to nullptr.
...
This change was generated mechanically by running:
find . \( -name \*.cc -or -name \*.mm -or -name \*.h \) \
-and -not -path ./third_party/\* -and -not -path ./out/\* \
-exec sed -i '' -E -e 's/(^|[^_])NULL/\1nullptr/g' {} +
Further manual fix-ups were applied to remove casts of nullptr to other
pointer types where possible, to preserve the intentional use of NULL
(as a short form of MACH_PORT_NULL) in exception_port_tool, and to fix
80-column violations.
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/4mijeJHzxLg/discussion
TEST=*_test
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/656703002
2014-10-14 11:10:45 -04:00
Mark Mentovai
d7eb23c93e
Add ExceptionSnapshotMac.
...
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/650303002
2014-10-13 18:09:07 -04:00
Mark Mentovai
356a2db147
Add ThreadSnapshotMac.
...
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/652003002
2014-10-13 18:06:43 -04:00
Mark Mentovai
6d1af6922f
Don’t use using directives (“using namespace”) in tests.
...
The contents of tests are moved into the namespace
crashpad::test::(anonymous namespace).
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/635883002
2014-10-07 17:28:50 -04:00
Mark Mentovai
d0294f3bb8
Fix collision between 49c03db12965 and 56503fef865d.
...
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/628403002
2014-10-06 19:02:57 -04:00
Mark Mentovai
49c03db129
Add snapshot/cpu_context_mac*, including InitializeCPUContextX86() and
...
InitializeCPUContextX86_64(), and their tests.
TEST=snapshot_test CPUContextMac.*
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/630513003
2014-10-06 18:46:04 -04:00
Mark Mentovai
56503fef86
Use the correct fxsave type for x86_64.
...
No functional change.
TEST=snapshot_test SystemSnapshotMacTest.CPUX86SupportsDAZ
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/623343004
2014-10-06 13:47:10 -04:00
Mark Mentovai
0ff46a4e60
Improve SystemSnapshotMac::TimeZone()’s computation of UTC offsets.
...
In locations that observe daylight saving time, this method now probes
different times to determine the offset when DST observance is (or is
not) in effect. This replaces a hard-coded one-hour offset, accounting
for Lord Howe Island, Australia, which is at a 30-minute offset.
TEST=snapshot_test SystemSnapshotMacTest.TimeZone
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/626093005
2014-10-03 18:40:09 -04:00
Mark Mentovai
6b451ea32a
Add MemorySnapshotMac.
...
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/623163004
2014-10-03 14:57:07 -04:00
Mark Mentovai
3f81599848
Add SystemSnapshotMac and its test.
...
TEST=snapshot_test SystemSnapshotMac.*
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/626013002
2014-10-03 14:55:54 -04:00
Mark Mentovai
7b2e7efcc2
Add the Snapshot interface.
...
These are all of the abstract base classes used in the Snapshot series,
discussed in the thread at
https://groups.google.com/a/chromium.org/d/topic/crashpad-dev/4pACgjhIz-I .
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/597673004
2014-10-02 17:09:37 -04:00
