240 Commits

Author SHA1 Message Date
Mark Mentovai
50ed179e9a Use BUILDFLAG for OS checking
Use BUILDFLAG(IS_*) instead of defined(OS_*).

This was generated mostly mechnically by performing the following steps:
 - sed -i '' -E -e 's/defined\(OS_/BUILDFLAG(IS_/g' \
                -e 's%([ !])OS_([A-Z]+)%\1BUILDFLAG(IS_\2)%g' \
       $(git grep -l 'OS_'
         '**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
 - sed -i '' -e 's/#ifdef BUILDFLAG(/#if BUILDFLAG(/' \
       $(git grep -l '#ifdef BUILDFLAG('
         '**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
 - gsed -i -z -E -e \
       's%(.*)#include "%\1#include "build/buildflag.h"\n#include "%' \
       $(git grep -l 'BUILDFLAG(IS_'
         '**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
 - Spot checks to move #include "build/buildflag.h" to the correct parts
   of files.
 - sed -i '' -E -e \
       's%^(#include "build/buildflag.h")$%#include "build/build_config.h"\n\1%' \
       $(grep -L '^#include "build/build_config.h"$'
         $(git grep -l 'BUILDFLAG(IS_'
           '**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'))
 - Add “clang-format off” around tool usage messages.
 - git cl format
 - Update mini_chromium to 85ba51f98278 (intermediate step).
   TESTING ONLY).
 - for f in $(git grep -l '^#include "build/buildflag.h"$'
              '**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'); do \
       grep -v '^#include "build/buildflag.h"$' "${f}" > /tmp/z; \
       cp /tmp/z "${f}"; done
 - git cl format
 - Update mini_chromium to 735143774c5f (intermediate step).
 - Update mini_chromium to f41420eb45fa (as checked in).
 - Update mini_chromium to 6e2f204b4ae1 (as checked in).

For ease of review and inspection, each of these steps is uploaded as a
new patch set in a review series.

This includes an update of mini_chromium to 6e2f204b4ae1:

f41420eb45fa Use BUILDFLAG for OS checking
6e2f204b4ae1 Include what you use: string_util.h uses build_config.h

Bug: chromium:1234043
Change-Id: Ieef86186f094c64e59b853729737e36982f8cf69
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3400258
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2022-01-19 20:21:19 +00:00
Avi Drissman
b560edd484 Remove ALLOW_UNUSED_LOCAL from Crashpad
Bug: 1286390
Change-Id: I9755258960c55bef84e01812a14067ffaf89d2b1
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3388879
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2022-01-14 23:11:32 +00:00
Avi Drissman
23375ab37c Use std::ignore rather than ignore_result in Crashpad
Bug: 1285085
Change-Id: I02f1eb608a704fe58b72c094b96af6c7577be4bf
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3373171
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
2022-01-07 22:38:52 +00:00
Mark Mentovai
7aec285110 Update mini_chromium to 0243b40af70e34c81fc8a30d9b15cd276b2d49ba
0243b40af70e win: Actually compile C++ as C++17, and fix __cplusplus
             macro

Change-Id: If430b97d1cf846746a5226638e04b3a2cdb5efce
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3372325
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2022-01-07 19:04:12 +00:00
Mark Mentovai
4a539c714d Update mini_chromium to 6562d2d0b2a86026a0c8bfc89d95c0a547ed9e5e
6562d2d0b2a8 Compile as C++17 by using -std=c++17 (and /std:c++17 on
             Windows)

Change-Id: I10c209e8147425af77392e7649210ab68a5d27a7
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3371781
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2022-01-07 01:36:02 +00:00
Nathan Mulcahey
821d265ea9 [lss] Roll lss and update Fuchsia location
Fuchsia is currently pulling in lss twice, this rolls crashpad up to
HEAD and redirects the Fuchsia build to use the existing copy in our
dependencies.

Change-Id: Ib698ee72d3d1881d22128bc94a1f6f17185a0755
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3364805
Reviewed-by: Francois Rousseau <frousseau@google.com>
Commit-Queue: Francois Rousseau <frousseau@google.com>
2022-01-06 17:01:52 +00:00
Alex Gough
ff50a9e8c4 Reland x7 "Bump Windows SDK to 10.0.19041.0"
This is a reland of a8683138db568ad89052587d081d280682439bc4

x86 env var VSINSTALLDIR=path\.\ was interpolated into a gn
vars file with a trailing slash. mini_chromium has been updated
to account for this[0].

[0] https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/3338622

Original change's description:
> Reland x6 "Bump Windows SDK to 10.0.19041.0"
>
> Reland of cfb5c846745a3f3f28c63a1d74345fc965d2bac9.
>
> CL configures crashpad builders to use cipd packaged Windows SDK
> version 10.0.19041 and updates mini_chromium to account for new
> SDK layout[0].
>
> [0] https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/3328284
>
> Bug: 1250098
> Change-Id: Ie8ea11497e31d51478041829c872b47f5c982ab8
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3334271
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Alex Gough <ajgo@chromium.org>

Bug: 1250098
Change-Id: Ie8145d498f4f3f10fd6195d8e0ad5a82bf25933b
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3339382
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-12-14 17:44:28 +00:00
Alex Gough
3e234dfe96 Revert "Reland x6 "Bump Windows SDK to 10.0.19041.0""
This reverts commit a8683138db568ad89052587d081d280682439bc4.

Reason for revert: https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket/8827866127654006481/+/u/generate_build_files_x86/stdout?format=raw

Original change's description:
> Reland x6 "Bump Windows SDK to 10.0.19041.0"
>
> Reland of cfb5c846745a3f3f28c63a1d74345fc965d2bac9.
>
> CL configures crashpad builders to use cipd packaged Windows SDK
> version 10.0.19041 and updates mini_chromium to account for new
> SDK layout[0].
>
> [0] https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/3328284
>
> Bug: 1250098
> Change-Id: Ie8ea11497e31d51478041829c872b47f5c982ab8
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3334271
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Alex Gough <ajgo@chromium.org>

Bug: 1250098
Change-Id: Icef5e7a8c475c06274c935481df22fae1c6cdc3a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3338854
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-12-14 13:25:58 +00:00
Alex Gough
a8683138db Reland x6 "Bump Windows SDK to 10.0.19041.0"
Reland of cfb5c846745a3f3f28c63a1d74345fc965d2bac9.

CL configures crashpad builders to use cipd packaged Windows SDK
version 10.0.19041 and updates mini_chromium to account for new
SDK layout[0].

[0] https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/3328284

Bug: 1250098
Change-Id: Ie8ea11497e31d51478041829c872b47f5c982ab8
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3334271
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-12-14 12:24:10 +00:00
Joshua Seaton
05e4aedfb3 [googletest] Roll pin
googletest is rolled to 5bcd8e3bb929714e031a542d303f818e5a5af45d to pick
up changes that affect how process information is read on fuchsia. The
existing pin is from April 26 2021 and the new one is from June 8: this
is a conservative roll - and the new pin matches that of other fuchsia
SDK partners.

Bug: fuchsia:30751
Change-Id: Ie1c4d075cfc2968c0984671c3afd0bc50fe00d3f
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3335589
Reviewed-by: Francois Rousseau <frousseau@google.com>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
2021-12-13 23:35:19 +00:00
Alex Gough
c1a7d9baea Revert "Reland "Reland "Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0""""""
This reverts commit cfb5c846745a3f3f28c63a1d74345fc965d2bac9.

Reason for revert: https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket/8828456030785338865/+/u/generate_build_files_x86/stdout?format=raw

Original change's description:
> Reland "Reland "Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0"""""
>
> This is a reland of e5e47bc277532ae109a444cbb3646977c93fc077
>
> Previous attempt failed as depot_tools win_sdk helper did not allow
> the updated path selection for Windows SDKs. This should be fixed by:
> https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3296663
> "[windows_sdk] allow env json to not be relative"
>
> > > > > Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> > > > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > > > > Commit-Queue: Mark Mentovai <mark@chromium.org>
> > > >
> > > > Change-Id: I9e8d14415c12c28b6a230b689d3b791a086d7a06
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260604
> > > > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > >
> > > Change-Id: Iafb40bd8799dbfea9308f19e3c6e7568bcba82df
> > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260757
> > > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > > Bug: crashpad:
> >
> > Change-Id:
> > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3286783
>
> Change-Id: Idadfe861b64e6c3361e98ca690230f30d113cdab
> Bug: 1250098
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3321428
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Alex Gough <ajgo@chromium.org>

Bug: 1250098
Change-Id: I346ee73d690f3102b28df10d4cd2a9a7273608fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3321436
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-12-08 01:06:33 +00:00
Alex Gough
cfb5c84674 Reland "Reland "Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0"""""
This is a reland of e5e47bc277532ae109a444cbb3646977c93fc077

Previous attempt failed as depot_tools win_sdk helper did not allow
the updated path selection for Windows SDKs. This should be fixed by:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3296663
"[windows_sdk] allow env json to not be relative"

> > > > Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> > > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > > > Commit-Queue: Mark Mentovai <mark@chromium.org>
> > >
> > > Change-Id: I9e8d14415c12c28b6a230b689d3b791a086d7a06
> > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260604
> > > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> >
> > Change-Id: Iafb40bd8799dbfea9308f19e3c6e7568bcba82df
> > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260757
> > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > Bug: crashpad:
>
> Change-Id:
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3286783

Change-Id: Idadfe861b64e6c3361e98ca690230f30d113cdab
Bug: 1250098
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3321428
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-12-08 00:08:38 +00:00
Alex Gough
70e4327a73 Revert "Reland "Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0"""""
This reverts commit 6383b8d2a71bc5825bb0d294fab59985fa460d9d.

Reason for revert: https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket/8830178135765256705/+/u/RECIPE_CRASH__Uncaught_exception_/logging

Seem like later stages are not ready for the json, or we need to massage a path somewhere. Will investigate.

Original change's description:
> Reland "Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0""""
>
> https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3290913
> should now correctly locate the new json environments that this SDK cipd
> package introduces (I have manually downloaded old and new packages
> and verified).
>
> This is a reland of e5e47bc277532ae109a444cbb3646977c93fc077
>
> Original change's description:
> > Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0"""
> >
> > This is a reland of 3dc913b12b4853ef620495a74081dd15fca8dc5e
> >
> > Previous attempt failed as the recipe helper in depot tools did not
> > understand the new cipd win sdk layout and failed at the
> > 'SetEnv.target.json' step.
> > https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket/8831436994854248129/+/u/read_SetEnv.x86.json/stdout
> >
> > This should be addressed once
> > https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3283800
> > is rolled into the bot infrastructure.
> >
> > > This is a reland of 44f566832da48b25c09ee83d4221a9c57f359a82
> > >
> > > The proper format for this sort of property is:
> > >
> > >     properties["$depot_tools/windows_sdk"] = {
> > >         "version": "uploaded:2021-04-28",
> > >     }
> > >
> > > rather than the nested version we had before.
> > >
> > > Original change's description:
> > > > Reland "Bump Windows SDK to 10.0.19041.0"
> > > >
> > > > This is a reland of 020da53ac84de675c8adae5b512f4257adc9dfe3
> > > >
> > > > Original change's description:
> > > > > Bump Windows SDK to 10.0.19041.0
> > > > >
> > > > > Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> > > > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > > > > Commit-Queue: Mark Mentovai <mark@chromium.org>
> > > >
> > > > Change-Id: I9e8d14415c12c28b6a230b689d3b791a086d7a06
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260604
> > > > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > >
> > > Change-Id: Iafb40bd8799dbfea9308f19e3c6e7568bcba82df
> > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260757
> > > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > > Bug: crashpad:
> >
> > Bug: 1250098
> > Change-Id: Ia3fa460e7054c85456bca37478b03c60906b36a9
> > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3286783
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > Commit-Queue: Alex Gough <ajgo@chromium.org>
>
> Bug: 1250098
> Change-Id: I6f278db20c440b5dd9952281411723706aa0af2b
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3292209
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Alex Gough <ajgo@chromium.org>

Bug: 1250098
Change-Id: I58ca7c64541832cc00690729b907b210eb583895
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3292345
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-11-19 01:01:25 +00:00
Alex Gough
6383b8d2a7 Reland "Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0""""
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3290913
should now correctly locate the new json environments that this SDK cipd
package introduces (I have manually downloaded old and new packages
and verified).

This is a reland of e5e47bc277532ae109a444cbb3646977c93fc077

Original change's description:
> Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0"""
>
> This is a reland of 3dc913b12b4853ef620495a74081dd15fca8dc5e
>
> Previous attempt failed as the recipe helper in depot tools did not
> understand the new cipd win sdk layout and failed at the
> 'SetEnv.target.json' step.
> https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket/8831436994854248129/+/u/read_SetEnv.x86.json/stdout
>
> This should be addressed once
> https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3283800
> is rolled into the bot infrastructure.
>
> > This is a reland of 44f566832da48b25c09ee83d4221a9c57f359a82
> >
> > The proper format for this sort of property is:
> >
> >     properties["$depot_tools/windows_sdk"] = {
> >         "version": "uploaded:2021-04-28",
> >     }
> >
> > rather than the nested version we had before.
> >
> > Original change's description:
> > > Reland "Bump Windows SDK to 10.0.19041.0"
> > >
> > > This is a reland of 020da53ac84de675c8adae5b512f4257adc9dfe3
> > >
> > > Original change's description:
> > > > Bump Windows SDK to 10.0.19041.0
> > > >
> > > > Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> > > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > > > Commit-Queue: Mark Mentovai <mark@chromium.org>
> > >
> > > Change-Id: I9e8d14415c12c28b6a230b689d3b791a086d7a06
> > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260604
> > > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> >
> > Change-Id: Iafb40bd8799dbfea9308f19e3c6e7568bcba82df
> > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260757
> > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > Bug: crashpad:
>
> Bug: 1250098
> Change-Id: Ia3fa460e7054c85456bca37478b03c60906b36a9
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3286783
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Alex Gough <ajgo@chromium.org>

Bug: 1250098
Change-Id: I6f278db20c440b5dd9952281411723706aa0af2b
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3292209
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-11-19 00:21:51 +00:00
Alex Gough
801e7e7021 Revert "Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0""""
This reverts commit e5e47bc277532ae109a444cbb3646977c93fc077.

Reason for revert: depot_tools winapi recipe needs another minor change.

https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket/8830288168302335601/+/u/read_SetEnv_json/stdout?format=raw

https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket/8830288168302335601/+/u/read_SetEnv_json/stdout?format=raw

Original change's description:
> Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0"""
>
> This is a reland of 3dc913b12b4853ef620495a74081dd15fca8dc5e
>
> Previous attempt failed as the recipe helper in depot tools did not
> understand the new cipd win sdk layout and failed at the
> 'SetEnv.target.json' step.
> https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket/8831436994854248129/+/u/read_SetEnv.x86.json/stdout
>
> This should be addressed once
> https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3283800
> is rolled into the bot infrastructure.
>
> > This is a reland of 44f566832da48b25c09ee83d4221a9c57f359a82
> >
> > The proper format for this sort of property is:
> >
> >     properties["$depot_tools/windows_sdk"] = {
> >         "version": "uploaded:2021-04-28",
> >     }
> >
> > rather than the nested version we had before.
> >
> > Original change's description:
> > > Reland "Bump Windows SDK to 10.0.19041.0"
> > >
> > > This is a reland of 020da53ac84de675c8adae5b512f4257adc9dfe3
> > >
> > > Original change's description:
> > > > Bump Windows SDK to 10.0.19041.0
> > > >
> > > > Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> > > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > > > Commit-Queue: Mark Mentovai <mark@chromium.org>
> > >
> > > Change-Id: I9e8d14415c12c28b6a230b689d3b791a086d7a06
> > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260604
> > > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> >
> > Change-Id: Iafb40bd8799dbfea9308f19e3c6e7568bcba82df
> > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260757
> > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > Bug: crashpad:
>
> Bug: 1250098
> Change-Id: Ia3fa460e7054c85456bca37478b03c60906b36a9
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3286783
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Alex Gough <ajgo@chromium.org>

Bug: 1250098
Change-Id: If183131c20b15ec87a956fccee2dcbcf0c551091
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3290110
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-11-17 20:24:13 +00:00
Alex Gough
e5e47bc277 Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0"""
This is a reland of 3dc913b12b4853ef620495a74081dd15fca8dc5e

Previous attempt failed as the recipe helper in depot tools did not
understand the new cipd win sdk layout and failed at the
'SetEnv.target.json' step.
https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket/8831436994854248129/+/u/read_SetEnv.x86.json/stdout

This should be addressed once
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3283800
is rolled into the bot infrastructure.

> This is a reland of 44f566832da48b25c09ee83d4221a9c57f359a82
>
> The proper format for this sort of property is:
>
>     properties["$depot_tools/windows_sdk"] = {
>         "version": "uploaded:2021-04-28",
>     }
>
> rather than the nested version we had before.
>
> Original change's description:
> > Reland "Bump Windows SDK to 10.0.19041.0"
> >
> > This is a reland of 020da53ac84de675c8adae5b512f4257adc9dfe3
> >
> > Original change's description:
> > > Bump Windows SDK to 10.0.19041.0
> > >
> > > Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > > Commit-Queue: Mark Mentovai <mark@chromium.org>
> >
> > Change-Id: I9e8d14415c12c28b6a230b689d3b791a086d7a06
> > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260604
> > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
>
> Change-Id: Iafb40bd8799dbfea9308f19e3c6e7568bcba82df
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260757
> Commit-Queue: Alex Gough <ajgo@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Bug: crashpad:

Bug: 1250098
Change-Id: Ia3fa460e7054c85456bca37478b03c60906b36a9
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3286783
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-11-17 04:22:34 +00:00
Peter Boström
bede7bb29e Rename "base/macros.h" => "base/ignore_result.h"
This pulls in "base/ignore_result.h" from mini_chromium through DEPS and
updates existing uses of "base/macros.h" to use "base/ignore_result.h".

Bug: chromium:1010217
Change-Id: I283e2bcfb2775de420d7e767b3b4a639dbba9e20
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3286105
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
2021-11-16 21:21:28 +00:00
Alex Gough
5225da1232 Revert "Reland "Reland "Bump Windows SDK to 10.0.19041.0"""
This reverts commit 3dc913b12b4853ef620495a74081dd15fca8dc5e.

Reason for revert: while the SDK is now being fetched, the step
Read SetEnv.platform.json is now failing.

https://logs.chromium.org/logs/crashpad/buildbucket/cr-buildbucket/8831436994854248129/+/u/read_SetEnv.x86.json/stdout

Original change's description:
> Reland "Reland "Bump Windows SDK to 10.0.19041.0""
>
> This is a reland of 44f566832da48b25c09ee83d4221a9c57f359a82
>
> The proper format for this sort of property is:
>
>     properties["$depot_tools/windows_sdk"] = {
>         "version": "uploaded:2021-04-28",
>     }
>
> rather than the nested version we had before.
>
> Original change's description:
> > Reland "Bump Windows SDK to 10.0.19041.0"
> >
> > This is a reland of 020da53ac84de675c8adae5b512f4257adc9dfe3
> >
> > Original change's description:
> > > Bump Windows SDK to 10.0.19041.0
> > >
> > > Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> > > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> > > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > > Commit-Queue: Mark Mentovai <mark@chromium.org>
> >
> > Change-Id: I9e8d14415c12c28b6a230b689d3b791a086d7a06
> > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260604
> > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
>
> Change-Id: Iafb40bd8799dbfea9308f19e3c6e7568bcba82df
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260757
> Commit-Queue: Alex Gough <ajgo@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>

Change-Id: If7d29c2d95491eb7df23b21383deef7a85f9192f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260758
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-11-05 03:28:55 +00:00
Alex Gough
3dc913b12b Reland "Reland "Bump Windows SDK to 10.0.19041.0""
This is a reland of 44f566832da48b25c09ee83d4221a9c57f359a82

The proper format for this sort of property is:

    properties["$depot_tools/windows_sdk"] = {
        "version": "uploaded:2021-04-28",
    }

rather than the nested version we had before.

Original change's description:
> Reland "Bump Windows SDK to 10.0.19041.0"
>
> This is a reland of 020da53ac84de675c8adae5b512f4257adc9dfe3
>
> Original change's description:
> > Bump Windows SDK to 10.0.19041.0
> >
> > Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > Commit-Queue: Mark Mentovai <mark@chromium.org>
>
> Change-Id: I9e8d14415c12c28b6a230b689d3b791a086d7a06
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260604
> Commit-Queue: Alex Gough <ajgo@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>

Change-Id: Iafb40bd8799dbfea9308f19e3c6e7568bcba82df
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260757
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2021-11-05 02:55:24 +00:00
Alex Gough
197d037cfd Revert "Reland "Bump Windows SDK to 10.0.19041.0""
Infra failures continue:

https://ci.chromium.org/ui/p/crashpad/builders/try/crashpad_win_x64_rel/114/overview

This reverts commit 44f566832da48b25c09ee83d4221a9c57f359a82.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Bump Windows SDK to 10.0.19041.0"
>
> This is a reland of 020da53ac84de675c8adae5b512f4257adc9dfe3
>
> Original change's description:
> > Bump Windows SDK to 10.0.19041.0
> >
> > Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > Commit-Queue: Mark Mentovai <mark@chromium.org>
>
> Change-Id: I9e8d14415c12c28b6a230b689d3b791a086d7a06
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260604
> Commit-Queue: Alex Gough <ajgo@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>

Change-Id: I4b0629bccdb7586146f1775d20bfdc7d66348d2c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260756
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
2021-11-04 23:42:23 +00:00
Alex Gough
44f566832d Reland "Bump Windows SDK to 10.0.19041.0"
This is a reland of 020da53ac84de675c8adae5b512f4257adc9dfe3

Original change's description:
> Bump Windows SDK to 10.0.19041.0
>
> Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Mark Mentovai <mark@chromium.org>

Change-Id: I9e8d14415c12c28b6a230b689d3b791a086d7a06
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3260604
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2021-11-04 23:15:23 +00:00
Justin Cohen
4bafdbc211 Revert "Bump Windows SDK to 10.0.19041.0"
This reverts commit 020da53ac84de675c8adae5b512f4257adc9dfe3.

Reason for revert: Speculative revert, as trybots are failing:
https://ci.chromium.org/ui/p/crashpad/builders/try/crashpad_win_x64_rel/103/overview

Original change's description:
> Bump Windows SDK to 10.0.19041.0
>
> Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Mark Mentovai <mark@chromium.org>

Change-Id: Ibd534e55fd81279e4d0f4df0f387fdaaa2475845
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3259422
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2021-11-04 20:38:10 +00:00
Alex Gough
020da53ac8 Bump Windows SDK to 10.0.19041.0
Change-Id: Id0c308a838a8b94ce7d24369ffd168a10730a30a
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3256822
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2021-11-03 03:16:42 +00:00
Justin Cohen
0118cc44aa Roll mini_chromium to 461b416.
461b416: ios: Add ios_test_runner_xcuitest.

Change-Id: Ibc070d38aeb2f6396c1f51e9f2b6aa0212ae1ded
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3245733
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
2021-10-26 16:10:07 +00:00
Peter Boström
be2a8a47c1 Roll mini_chromium into crashpad
This brings in the removal of DISALLOW_ macros from crashpad's
base/macros.h.

Bug: chromium:1010217
Change-Id: Ieae1ad702be54fda7069fa72efe7d39b81a96d04
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3173473
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2021-09-21 19:52:50 +00:00
Justin Cohen
7b64a33b24 Roll mini_chromium to 8f7a60f.
8f7a60f: [ios/mac] Use clonefile instead of hardlink to populate bundles

Bug: crashpad: 31
Change-Id: I42cdd892fb5c80a737864e2ce268666ca449eb02
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3081861
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
2021-08-09 14:31:38 +00:00
Joshua Peraza
3ae82cd30a Remove gyp
Standalone Crashpad for Android can now be built with gn.

Change-Id: I0ee7f8e1af8c2bc0edb88e93b345abd7d739f33c
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3034984
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2021-07-16 17:09:48 +00:00
Justin Cohen
3b0ebc29cd Cleanup some diffs between Chromium and Crashpad.
Some header changes (page_size), formatting and exception processor
cast changes.

Change-Id: Id1d2dd99ee6d82b5322692894e4e12e96fcac030
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2936663
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
2021-06-28 14:25:39 +00:00
Francois Rousseau
b7cf20f171 Roll mini_chromium to 2470faf
2470faf fuchsia: implement LOG_TO_SYSTEM_DEBUG_LOG

Bug: fuchsia:76645
Change-Id: Ia03cce001be41859f5e07428a04fae3e968457e5
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2920723
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
2021-05-27 00:39:55 +00:00
Francois Rousseau
e58fde685b Roll mini_chromium to 47e19cc
47e19cc fuchsia: remove timestamp, pid and tid from log message

Bug: fuchsia:76645
Change-Id: I430db2dbdf2b0ebface13a053d6218e0c11671c7
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2919504
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
2021-05-26 19:01:45 +00:00
Lei Zhang
d8f60c8112 Swap from base/stl_util.h to cxx17_backports.h.
Chromium moved base::size() to base/cxx17_backports.h, so do the same in
mini_chromium and update the users in Crashpad.

Roll mini_chromium to 2f06f83f to make the new base header available.

Bug: chromium:1210983
Change-Id: Ie3dc4c189dcdfcac030b95fe285f94abb29a27bf
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2917779
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2021-05-25 21:44:52 +00:00
Scott Graham
0ac2a18ece Roll mini_chromium to c0c965a
c0c965a fuchsia: Re-enable logging

Bug: fuchsia:76641
Change-Id: I43818096344f4e7898acec1cbb9483696e15592f
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2894944
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2021-05-13 21:45:16 +00:00
Jay Zhuang
0c3d6e5fa1 [roll] mini_chromium
ccb1989 [build] Replace response file with write_file

Change-Id: If03dc6004e61d98d0ddf20fd4d795c831aa2e485
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2877798
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2021-05-06 22:56:28 +00:00
Justin Cohen
b8d3be9b78 Roll crashpad/third_party/googletest/googletest/ e589a3371..11da093e0 (288 commits)
e589a33717..11da093e04

$ git log e589a3371..11da093e0 --date=short --no-merges --format='%ad %ae %s'
2021-04-20 github Use URL instead of git-repo
2021-04-15 sebkraemer Apply missing suggestions from code review for GTEST_SKIP
2021-04-15 sebkraemer Apply suggestions from code review for GTEST_SKIP documentation
2020-12-15 sebkraemer Add subsection for GTEST_SKIP documentation
2021-04-15 jbampton chore: fix spelling
2021-04-14 github Mention to explicitely set the option to it's default.
2021-04-14 github Changes like Requested.
2021-03-17 77407429+a-sully Update nicestrictnaggy gmock cook_book links
2021-03-11 absl-team Internal change
2021-03-14 zekewarren Use @platforms instead of @bazel_tools for windows constraint
2021-03-13 github Use Fetchcontent instead of ExternalProject
2018-05-01 lantw44 Avoid using environ on FreeBSD
2020-02-17 krystian.kuzniarek remove a duplicated include
2020-06-10 rharrison Fix build issue for MinGW
2020-05-30 eli fix compilation on OpenBSD 6.7
2020-03-07 krystian.kuzniarek make UniversalPrinter<std::any> support RTTI
2020-03-07 krystian.kuzniarek specialize UniversalPrinter<> for std::any (without support for RTTI)
2020-03-07 krystian.kuzniarek specialize UniversalPrinter<> for std::optional
2020-03-07 krystian.kuzniarek specialize UniversalPrinter<> for std::variant
2020-05-25 invalid_ms_user Use count function instead of handwritten loop
2020-05-10 mate.pek README.dm: Renamed related open source project name: Catch2 and Google Test Explorer -> C++ TestMate
2020-05-08 martin Remove an explicit include of debugapi.h
2020-05-05 igor.n.nazarenko Detect proto messages based on presense of DebugString.
2020-03-26 mvoorsluys Fix test with stack.
2020-03-29 verdoialaurent Fix --gtest_print_time coloring
2020-03-26 mvoorsluys Fixed xml unit-tests and added extra tests
2020-03-26 mvoorsluys Fix multiple \n characters in xml file when using GTEST_SKIP.
2020-03-26 mvoorsluys Only write ">\n" once when there is failure and skipped tests.
2020-03-26 mvoorsluys Output skipped information in the xml file.
2020-03-21 ngompa13 Set the version for the libraries
2020-02-21 nini16041988-gitbucket Add missing call for gtest_list_output_unittest_ unitTest. Add unitTest for fixed TEST_P line number. Use CodeLocation TestInfo struct.
2020-02-18 nini16041988-gitbucket Fix: shadow member
2020-02-18 nini16041988-gitbucket Add correct line number to TEST_P test cases for gtest_output.
2020-02-06 59134746+aribibek fix a link to documentation
2020-01-17 hgsilverman Fix always false condition and clean function body
2020-01-22 mjvk Fixes extensions missing for QNX

Created with:
  roll-dep crashpad/third_party/googletest/googletest

Change-Id: Ie3358be72e398be40fd32efe03d2011832e88309
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2854039
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
2021-04-29 18:37:27 +00:00
Jan Wilken Dörrie
d5c8ee5fff Roll crashpad/third_party/mini_chromium/mini_chromium/ 0dcac3bf0..329ca82f7 (1 commit)
0dcac3bf03..329ca82f73

$ git log 0dcac3bf0..329ca82f7 --date=short --no-merges --format='%ad %ae %s'
2021-03-15 jdoerrie Remove base::char16 and base::string16

Created with:
  roll-dep crashpad/third_party/mini_chromium/mini_chromium

Bug: chromium:1184339
Change-Id: I414217a880a9267bf2693fd80f3097c208d2aeaf
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2760344
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
2021-03-15 17:52:02 +00:00
Jan Wilken Dörrie
d8c4d3adee Roll crashpad/third_party/mini_chromium/mini_chromium/ 0e081e6a0..0dcac3bf0 (2 commits)
0e081e6a0a..0dcac3bf03

$ git log 0e081e6a0..0dcac3bf0 --date=short --no-merges --format='%ad %ae %s'
2021-03-08 jdoerrie Fix breakages introduced by std::u16string switch
2021-03-08 jdoerrie Change string16 to std::u16string everywhere

Created with:
  roll-dep crashpad/third_party/mini_chromium/mini_chromium

Bug: chromium:911896
Change-Id: Icac88b97b459b06ef86b292b1c5a785734d8f829
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2742824
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2021-03-08 20:45:54 +00:00
Jay Zhuang
186e542db6 Roll mini_chromium 12ea507..0e081e6
2 commits:
0e081e6 Wrap python build script in __main__ guard
919fe9b Change non-Windows base::string16 to std::u16string

Change-Id: I1a9aba56271a811559fe29c4741100aaf6642f0d
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2728775
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2021-03-02 15:25:01 +00:00
Joshua Peraza
2e066d2e56 Use chromeos buildflags
This CL upstreams changes made in chromium to use buildflags:
https://chromium-review.googlesource.com/c/chromium/src/+/2494261
https://chromium-review.googlesource.com/c/chromium/src/+/2594831

and alters the  buildflags in handler_main.cc to allow LaCrOS to use
/sbin/crash_reporter

Bug: chromium:1159628
Change-Id: Iae9f39f9bc61106cb0056bee010ee7eaa7ac1713
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2622766
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2021-01-12 22:22:03 +00:00
Joshua Peraza
121d92ca3f Roll crashpad/third_party/mini_chromium/mini_chromium/ cb82d7129..c748b289b (2 commits)
cb82d71291..c748b289b8

$ git log cb82d7129..c748b289b --date=short --no-merges --format='%ad %ae %s'
2020-11-24 jperaza x86,linux: set flags for current_cpu
2020-10-29 jperaza android: link liblog in base

Created with:
  roll-dep crashpad/third_party/mini_chromium/mini_chromium

Change-Id: I2d5bbcfdc4e009c0f1c4c571b785a4cfcc8d58f0
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2570142
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2020-12-03 02:10:34 +00:00
Joshua Peraza
bccb9504d1 Roll crashpad/third_party/edo/edo/ 97121c640..6ffbf8331 (19 commits)
97121c6401..6ffbf83317

$ git log 97121c640..6ffbf8331 --date=short --no-merges --format='%ad %ae %s'
2020-11-10 albertbow Fix Swift Array objectAtIndex: failure on eDO since iOS 13.4.
2020-11-02 albertbow Fix eDO TSAN issue caused by __block variable.
2020-10-14 albertbow Enable ASAN and TSAN Travis tests in external CI.
2020-10-14 albertbow Fix eDO ASAN issue captured by Xcode 10.
2020-10-06 albertbow Fix TSAN warning on EDOListenSocket.
2020-10-03 haowoo Remove the unneeded cancel block.
2020-09-01 albertbow Added 1.0.1 patch release for respectful code.
2020-08-31 albertbow Rename EDOBlacklistedType to EDOBlockedType per go/respectful-code.
2020-08-19 albertbow Fix ASAN breakage on eDO device unit test.
2020-08-19 albertbow Internal Change.
2020-08-15 albertbow Comments for ${POD_TARGET_SRCROOT} in podspec.
2020-08-14 albertbow Upgrade podspec for Cocoapods 1.0.0 release.
2020-08-12 albertbow Second improvement of TSAN flakiness on channel tests.
2020-08-11 albertbow Fix part of the TSAN flakiness of ChannelTests.
2020-07-29 albertbow Fix Tsan for eDO channel tests.
2020-07-28 albertbow Fix clang-tidy complaint on OCMock imports in unit tests.
2020-07-14 haowoo Trivial clean-ups.
2020-07-14 albertbow Fix a test failure that happens with TSAN enabled.
2020-07-14 albertbow Allow EDOExecutorMessage to be waited multiple times.

Created with:
  roll-dep crashpad/third_party/edo/edo

Change-Id: I45e23ceb4f5c4dceb39ad8d3b5b070874c74f8ac
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2532682
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2020-11-11 19:41:19 +00:00
Justin Cohen
ae8d0a2481 Roll mini_chromium to cb82d71291
cb82d71291 ios: PRODUCT_BUNDLE_IDENTIFIER required in Xcode 12 for device builds.

Change-Id: I8467b9e9868d62f9ee14d504ff86a545f17a6dd5
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2507849
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
2020-10-29 16:28:24 +00:00
Justin Cohen
1d2fd9464d Roll mini_chromium to 9e179291
9e179291 ios: gtest bundle is now named googletest.

Change-Id: I297a325dbead727acd780c1d2a41c9e949379421
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2505596
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
2020-10-28 17:34:31 +00:00
Joshua Peraza
71e8ec7987 Initialize logging
Depends on https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/2424890

Although logging to files is not yet supported by mini_chromium, it is
the default behavior for OS_WIN in chromium. This change should
cause crashpad to log via OutputDebugString() on Windows, instead of
debug.log files. Future work (crbug.com/crashpad/26) should arrange for
logs to be uploaded with reports, embedded in associated minidumps or as
file attachments.

Bug: chromium:711159
Change-Id: I0f9004f7de94dd29d555cc7d23c48a63da6b4bba
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2425108
Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-10-21 19:45:30 +00:00
Leonard Chan
0b240a5347 Update mini_chromium to 1dbeb82e0452bc1b65f09f767a102cc4648135a4
1dbeb82e0452 [icu] Fix implicit int conversion error

Change-Id: I38c20bcb4afc7616d8fcc4ff24a9a97e33ff3a3c
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2443369
Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-10-01 18:37:54 +00:00
Shai Barack
74b38694fa Roll mini_chromium to 2b6cfa3
2b6cfa3 fuchsia: fix implicit conversion issue

Change-Id: Idbcebe4c3b464c9758b61e3b21848b24b7b7317e
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2437943
Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-09-30 12:24:43 +00:00
Scott Graham
f3aad49216 Roll mini_chromium to 71a7fdb
71a7fdb Pull include_dirs into config depended on by 'build' and 'base'

Change-Id: I6244e766eb67b73a2c230e934eae55d2aeb8492c
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2427150
Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-09-24 05:12:00 +00:00
Scott Graham
e6b525a4be Update config adjustments for moved build config in mini_chromium
Includes DEPS roll of mini_chromium:
f0bd14b Pull build_config.h source set into separate build file
65fb5c9 Update path to win_helper after moving to build/config

Change-Id: Ic9f5c68e2cebd8bf86492766684bdb422da1aa9e
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2426989
Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-09-23 22:12:16 +00:00
Joshua Peraza
36d4bb83b3 Remove base dependency from no_cfi_icall
crashpad_handler_trampoline needs to use NoCfiIcall, but does not link
libstdc++ in order to remain small. A dependency on base causes link
errors in ASAN builds:

https://ci.chromium.org/p/chromium/builders/ci/android-asan/7791?

This CL depends on
https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/2405651
in order to include "build/build_config.h".

Change-Id: Ie0344b7ead9c019cdda8a6e37ea8ec9cd5bf72b0
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2405650
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-09-21 21:25:08 +00:00
Scott Graham
1c77abe909 fuchsia: Centralize disabling of Wconversion
Because of the multiple-worlds building of the Crashpad code in the
Fuchsia tree (with the Fuchsia BUILDCONFIG.gn in particular) there's no
good location to globally disable Wconversion for all of crashpad.

This can be somewhat-improved by using a GN template
crashpad_static_library() similar to the existing crashpad_executable()
template.

Includes mini_chromium DEPS roll:
68da43e Fix a couple trucation warnings
88ce866 build: set include dirs

Bug: fuchsia:58162
Change-Id: I638fcf858c35b9a858ca2c410636f8c99603aed2
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2411131
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
2020-09-16 22:25:10 +00:00
Shai Barack
90344b24ed fuchsia: suppress -Wconversion warnings
Bug: fuchsia:56258
Bug: fuchsia:58162
Change-Id: I0b74e1786c169bef4e44ab54a19ffba79063474a
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2405375
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-09-11 22:00:00 +00:00