3 Commits

Author	SHA1	Message	Date
Scott Graham	2d87606bb5	win: Start crashpad_handler by inheriting connection data to it ... Previously, StartHandler() launched the handler process, then connected over a pipe to register for crash handling. Instead, the initial client can create and inherit handles to the handler and pass those handle values and other data (addresses, etc.) on the command line. This should improve startup time as there's no need to synchronize with the process at startup, and allows avoiding a call to CreateProcess() directly in StartHandler(), which is important for registration for crash reporting from DllMain(). Incidentally adds new utility functions for string/number conversion and string splitting. Note: API change; UseHandler() is removed for all platforms. BUG=chromium:567850,chromium:656800 Change-Id: I1602724183cb107f805f109674c53e95841b24fd Reviewed-on: https://chromium-review.googlesource.com/400015 Reviewed-by: Mark Mentovai <mark@chromium.org>	2016-10-21 20:35:58 +00:00
Mark Mentovai	7f939285de	win: Rename CrashpadClient::SetHandler() to SetHandlerIPCPipe() ... In https://codereview.chromium.org/1414533006/, I'm adding a few Mac-specific SetHandler() variants, so it makes sense to name each SetHandler() variant for what it does. I'm also making it take a wstring argument, which seems like a more natural fit for what it does. There should be fewer string conversions this way. R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1406993008 .	2015-11-02 17:00:06 -05:00
Scott Graham	475ac81cce	win: Implement CRASHPAD_SIMULATE_CRASH() ... Windows requires the connection to the handler to do anything, so it can't really be implemented or tested without CrashpadClient and the connection machinery. R=mark@chromium.org BUG=crashpad:53 Review URL: https://codereview.chromium.org/1356383002 .	2015-09-25 13:45:32 -07:00