Robert Sesek
977a7a8052
Add HTTPBodyStream interface, three concrete implementations, and their tests.
...
BUG=415544
R=mark@chromium.org
Review URL: https://codereview.chromium.org/669153006
2014-10-24 15:04:25 -04:00
Mark Mentovai
525de2c35a
Use exactly one of final, override, and virtual.
...
This change was generated mechanically by running:
find . \
\( -name \*.cc -or -name \*.mm -or -name \*.h \) \
-and -not -path ./third_party/\* -and -not -path ./out/\* -exec \
sed -i '' -E -e 's/virtual (.*) override final/\1 final/' {} +
find . \
\( -name \*.cc -or -name \*.mm -or -name \*.h \) \
-and -not -path ./third_party/\* -and -not -path ./out/\* -exec \
sed -i '' -E -e 's/virtual (.*) override/\1 override/' {} +
Additional changes were made manually based on:
git grep -E '^ {3,}.*override[;{]'
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html?showone=The__define_Guard#Inheritance
TEST=*_test
BUG=
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/654933002
2014-10-14 11:11:57 -04:00
Mark Mentovai
6d1af6922f
Don’t use using directives (“using namespace”) in tests.
...
The contents of tests are moved into the namespace
crashpad::test::(anonymous namespace).
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/635883002
2014-10-07 17:28:50 -04:00
Scott Graham
d198c50abe
Convert COMPILE_ASSERT to static_assert
...
(Perhaps I should have just left it in mini_chromium, but anyway.)
R=mark@chromium.org
BUG=crashpad:1
Review URL: https://codereview.chromium.org/615923004
2014-10-01 12:29:01 -07:00
Mark Mentovai
eeaf460f82
Add and use CheckedReadFD(), CheckedWriteFD(), and CheckedReadFDAtEOF().
...
TEST=util_test
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/577333002
2014-09-18 15:03:49 -04:00
Mark Mentovai
01f9e396b8
Include <limits.h> in util/file/file_writer.cc because it uses IOV_MAX.
...
This also updates mini_chromium to abd6e3792f4f.
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/469093002
2014-08-14 09:58:31 -07:00
Mark Mentovai
6e720f1421
Fix StringFileWriter::Seek().
...
The final range check needs to check that the value fits in a size_t,
because that’s what StringFileWriter uses for its offset_.
TEST=util_test StringFileWriter.SeekInvalid
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/434103003
2014-08-01 13:30:27 -04:00
Mark Mentovai
995012534e
Introduce MinidumpWritable, its dependencies, and their tests.
...
MinidumpWritable is the base class for all minidump-writing operations.
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
