5 Commits

Author	SHA1	Message	Date
Mark Mentovai	222f91f5c6	Add WeakFileHandleFileWriter, a FileWriterInterface implementation that ... deals solely with a weak FileHandle. CrashReportDatabase::PrepareNewCrashReport() provides its caller with both a FileHandle and a FilePath. While it’s possible to create a FileWriter from the FilePath, it’s not necessary to have two FileHandles open to the same file. Also, there’s no FileWriteMode::kReuseOrFail option because it didn’t seem necessary[1], and although it would actually be the most desirable option for a FileWriter here, allowing the FileHandle to be used directly without reopening the file sidesteps the problem entirely. FileWriter is adapted to use WeakFileHandleFileWriter to minimize duplication. [1] https://codereview.chromium.org/818433002/diff/80001/util/file/file_io.h#newcode138 R=rsesek@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/871193010	2015-02-04 17:26:16 -05:00
Scott Graham	6865865773	Change 'bool world_readable' to an enum ... More clear at callsites, and relatively important not to accidentally choose the wrong one. R=mark@chromium.org Review URL: https://codereview.chromium.org/821483002	2014-12-19 15:35:30 -08:00
Scott Graham	5f5e342584	Switch [String]FileWriter to use new file_io.h functions/types ... Also add ScopedFileHandle as cross-platform version of ScopedFD/ScopedFileHANDLE. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/815053004	2014-12-19 13:33:01 -08:00
Mark Mentovai	525de2c35a	Use exactly one of final, override, and virtual. ... This change was generated mechanically by running: find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override final/\1 final/' {} + find . \ \( -name \*.cc -or -name \*.mm -or -name \*.h \) \ -and -not -path ./third_party/\* -and -not -path ./out/\* -exec \ sed -i '' -E -e 's/virtual (.*) override/\1 override/' {} + Additional changes were made manually based on: git grep -E '^ {3,}.*override[;{]' http://google-styleguide.googlecode.com/svn/trunk/cppguide.html?showone=The__define_Guard#Inheritance TEST=*_test BUG= R=rsesek@chromium.org Review URL: https://codereview.chromium.org/654933002	2014-10-14 11:11:57 -04:00
Mark Mentovai	995012534e	Introduce MinidumpWritable, its dependencies, and their tests. ... MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005	2014-08-01 12:48:28 -04:00