284 Commits

Author SHA1 Message Date
Mark Mentovai
58aac1bd87 Set FD_CLOEXEC on file descriptors obtained from open() and fopen()
Includes an update of mini_chromium to 3a2d52d74c9a:

3a2d52d74c9a Use O_CLOEXEC (and O_NOCTTY) when calling open()

BUG=chromium:688362

Change-Id: I2bdf86efe4e6559ecb77492ac5bdc728aa035889
Reviewed-on: https://chromium-review.googlesource.com/447999
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-02-28 21:16:41 +00:00
Mark Mentovai
c73aebc7da Download clang-format and gn tools for Linux build hosts from DEPS hooks
This will make “git cl format” work in Crashpad on Linux.

BUG=crashpad:30

Change-Id: I3f356b46d93707419a229ae40b1387bb7629bb39
Reviewed-on: https://chromium-review.googlesource.com/448056
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-02-28 20:29:50 +00:00
Mark Mentovai
0c322ecc3f Use zlib to gzip-compress uploads
This adds zlib to Crashpad. By default in standalone Crashpad builds,
the system zlib will be used where available. A copy of Chromium’s zlib
(currently a slightly patched 1.2.11) is checked out via DEPS into
third_party for use on Windows, which does not have a system zlib.

zlib is used to produce gzip streams for HTTP upload request bodies sent
by crashpad_handler by default. The Content-Encoding: gzip header is set
for these compressed request bodies. Compression can be disabled for
upload to servers without corresponding decompression support by
starting crashpad_handler with the --no-upload-gzip option.

Most minidumps compress quite well with zlib. A size reduction of 90% is
not uncommon.

BUG=crashpad:157
TEST=crashpad_util_test GzipHTTPBodyStream.*:HTTPTransport.*

Change-Id: I99b86db3952c3685cd78f5dc858a60b54399c513
Reviewed-on: https://chromium-review.googlesource.com/438585
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-02-16 16:26:19 +00:00
Sigurdur Asgeirsson
6af23a933a Use best-effort allocation in ProcessInfo::BuildHandleVector.
BUG=crashpad:158

Change-Id: If8666140a7fc5315eeb791d0998226de89a22cc3
Reviewed-on: https://chromium-review.googlesource.com/438791
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-02-08 20:20:46 +00:00
Mark Mentovai
88442dd578 Merge Chromium 294442c0ce05 upstream to Crashpad
Remove stl_util from Crashpad. This also updates mini_chromium to
4f3cfc8e7c2b7d77f94f41a32c3ec84a6920f05d to remove stl_util from there
as well.

4f3cfc8e7c2b Remove stl_util from mini_chromium

BUG=chromium:555865

Change-Id: I8ecb1639a258dd233d524834ed205a4fcc641bac
Reviewed-on: https://chromium-review.googlesource.com/438865
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-02-07 21:04:42 +00:00
Mark Mentovai
35020d8010 Update buildtools, mini_chromium, gtest, and gyp
Update buildtools to a7cc7a3e21a061975b33dcdcd81a9716ba614c3c

adb8bf4e8fc9 Roll gn 4838fe571d..2eb03fab2b (r411399:r411754)
347c89790b42 Roll gn 2eb03fab2b..71c9ade4e9 (r411754:r415392)
82d2a28e425b Roll gn 2eb03fab2b..fe79dde87a (r411754:r415725)
b97d6c93a3e8 Roll gn 2eb03fab2b..764c7362bc (r411754:r417994)
6115afa0ea5e Roll gn 764c7362bc..668b150d14 (r417994:r419236)
f8088e3792a7 Roll gn 668b150d14..6a1c8d418d (r419236:r419720)
57649e5e2001 Roll gn 6a1c8d418d..65f3a42b24 (r419720:r419871)
86f7e41d9424 roll clang-format 258123:282138
3d2e47bf14e4 Fix repo url, remove recursion reference in DEPS
5fd66957f08b Roll gn 65f3a42b24..82dfb24218 (r419871:r421311)
39b1db2ab4aa Roll gn b6c1d4353b..bdc8e1e447 (r421341:r422996)
1f985091a586 Roll clang-format 0ed791d..6a413e9
991f459071f9 Roll gn bdc8e1e447..000b1184a0 (r422996:r432866)
102c16366d8b libc++: Don't pass -pthread to link.
64e38f0cebdd Roll gn 000b1184a0..78660e873f (r432866:r436326)
55ad626b08ef Roll gn 78660e873f..8897c835c2 (r436326:r436733)
0ef801087682 Roll gn 8897c835c2..c99acd6557 (r436733:r439377)
8932ecfa420a Roll gn c99acd6557..b1f498915e (r439377:r441559)
7e08d331f188 Roll gn c99acd6557..5c18ca83ce (r439377:r442253)
005cae407b97 Roll gn c99acd6557..7a3be23857 (r439377:r442631)
9a947138bc58 Roll gn 5c18ca83ce..7c0e0135f9 (r442253:r443802)
cb12d6e8641f Roll gn 7c0e0135f9..b4dbf044c5 (r443802:r443809)
8e94621c369e Roll gn b4dbf044c5..f13158d3c5 (r443809:r445411)
a7cc7a3e21a0 Roll gn f13158d3c5..d8754536ca (r445411:r446079)

Update mini_chromium to e504d59673e56887a4e837cbeb44b32ec21974f9

cae485daae70 win: Initial version of toolchain for GN
57f426502e00 Enable thread-safe statics when building with GCC and clang
e504d59673e5 Remove now-unused LazyInstance

Update gtest to d62d6c6556d96dda924382547c54a4b3afedb22c

9759dcda3c2f Fix compilation on MinGW with native threads
a138385e48ee Don't use pthread when on MinGW even if available
3429113886a9 Fix a test to compile when tuple isn't available
ed9d1e1ff92c Merge pull request #721 from ilmagico/fix-mingw-threads
d8fe70f477d8 Fix build with MinGW-w64
48ee8e98abc9 Merge pull request #856 from KindDragon/mingw-appveyor
10ff7f946863 Fixing relative links
16d6af7d414a Relative links
51b290d41e5d One works
9cb03aa70223 Fixing ForDummies link
f5c0130e88a3 Broken relative links fixed
995db996dee6 Fixing KnownIssues and FrequentlyAskedQuestions links
960a511f45be Fixing relative links
0e0ff5c3410f blob vs tree
32b4a9b39079 Fixed broken links
8ce0b5907cd9 Cookbok: fix broken relative link
ecd530865cef Merge pull request #876 from marco-m/patch-1
4eafafbde585 Fix detection of GTEST_HAS_CLONE for Android
3447fc31b4ee Merge pull request #728 from DanAlbert/tuple-stlport
a2b8a8e07628 Merge pull request #918 from
             DanAlbert/fix-android-GTEST_HAS_CLONE
cb502b7ad15c Added CMake configure-time download instructions to docs
c0059a79f82d 2.6.4 is the minimum CMake version, so enforce it (#656)
5e7fd50e17b6 Merge pull request #658 from
             audiofanatic/ExternalProject_at_configure_time
06a81e9357b6 Add GTEST_ATTRIBUTE_UNUSED_ to REGISTER_TYPED_TEST_CASE_P
3134af23d713 Merge pull request #1 from google/master
9ae086a9ebaf Merge pull request #874 from sejr/master
d62d6c6556d9 Merge pull request #982 from mbjorge/unused-variable-fix

Update gyp to a7055b3989c1074adca03b4b4829e7f0e57f6efd

702ac58e4772 Add new target type called windows_driver. * Modify GYP to
             set the PlatformToolset, the DriverType and the
             TargetVersion * Add msvs_target_version configuration
5dc5a5b1718e fix common "NameError"s
920ee58c3d31 Hash intermediate file name to avoid ENAMETOOLONG
ef2f29a7311b msvs: Allow target platform version without WinRT
940a15ee3f1c Update shared library extension on AIX to .a.
9733aa652da4 Set up a CQ for gyp
a7055b3989c1 Make Gerrit the default code review system for gyp

Change-Id: I11d8139b0f533911692dc7a11bb9edaddac78060
Reviewed-on: https://chromium-review.googlesource.com/438885
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-02-07 19:35:41 +00:00
Scott Graham
f9b3a18f3f Use DEPS hooks to get gn binaries from buildtools
Otherwise:
  [2d68949...]D:\src\crashpad\crashpad>gn gen out\Debug
  gn.py: Could not find gn executable at: D:\src\crashpad\buildtools\win\gn.exe

I have no idea why these binaries aren't just checked into buildtools,
but anyway.

BUG=crashpad:79

Change-Id: If2f21a7e7f795910809de7d3595ab6a5ffee9dc7
Reviewed-on: https://chromium-review.googlesource.com/424847
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-01-05 21:48:13 +00:00
Scott Graham
2d68949f7f Pull LLVM/Clang/LLDB into third_party
This might feel a bit premature, but I feel fairly confident that basing
a lot of the processing on LLDB is the way to go, so I plan to start by
integrating it into our build process.

(I think probably moving from gyp to GN first makes sense, so I can defer
landing this until after that's farther along if you like.)

BUG=crashpad:29

Change-Id: I85ee44f4e777f9d7ce521c4caf10ead21ffd8818
Reviewed-on: https://chromium-review.googlesource.com/424910
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-01-05 02:57:42 +00:00
Scott Graham
f66d5df30c Roll mini_chromium to de1afb0
> git log 414d596..de1afb0 --oneline
de1afb0 Update base/numerics from Chromium
ca7f42a Improve the Win32/x64 configuration when generating MSVS projects
c1f7a2c Create initial GN configuration for mini_chromium.

R=mark@chromium.org

Change-Id: I309fe722c18764c9a85e9c6e212f39bf07fe3b02
Reviewed-on: https://chromium-review.googlesource.com/417770
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-12-07 22:52:56 +00:00
Mark Mentovai
3830e4e5c1 Update the link to mini_chromium’s README
Also, update mini_chromium to 414d59602ac38e24f1e93929fda3d79d72cea139

7bfe6cd9579b README→README.md; convert plain text to Markdown
414d59602ac3 Fix mailto: link in README.md

BUG=crashpad:138

Change-Id: Ibd3c054a3e7f08a740fe6aca408cf23797d992ae
Reviewed-on: https://chromium-review.googlesource.com/408316
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2016-11-04 21:53:31 +00:00
Mark Mentovai
d5a759c900 Update mini_chromium to 8e8d3cc9a245f1bf63296e97fb6ac1c90f6d86f5
9f129335dbe5 Add Android and ARM support to mini_chromium base
1d3e5ef89ad0 Link Linux/Android executables with -pie for position
             independence
8e8d3cc9a245 Add Android to filename_rules.gypi

BUG=crashpad:30

Change-Id: Idace661e0ffa598f5c2a2a4af2d578355c101c56
Reviewed-on: https://chromium-review.googlesource.com/405567
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2016-10-31 17:42:54 +00:00
Scott Graham
b48e9bfbab Add UMA to exception handler exception catching
Includes mini_chromium DEPS roll for:
88e0a3e Add stub of sparse_histogram.h

R=mark@chromium.org
BUG=crashpad:100

Change-Id: I4c541a33be0f7f47e972af638d4765bd06682acf
Reviewed-on: https://chromium-review.googlesource.com/386385
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-09-19 18:10:31 +00:00
Scott Graham
27aeb2c9da Upstream Chromium UMA integration
Unmodified from https://codereview.chromium.org/2308763002/ other than
to add empty arguments to test code (that doesn't build in Chrome).

Requires https://chromium-review.googlesource.com/c/386236/.

Rolls mini_chromium to include:
438bd4f4 Add stub of persistent_histogram_allocator.h

R=mark@chromium.org
BUG=crashpad:100

Change-Id: Ibc88338ae2fd40a5a4ade7ff098be2bc19511543
Reviewed-on: https://chromium-review.googlesource.com/386084
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-09-16 20:23:06 +00:00
Mark Mentovai
0c29022090 Update mini_chromium to 7800285e83df4286981bb933e3335edade7c8308
7800285e83df Don't #undef UMA_HISTOGRAM_UNUSED

Change-Id: I6a694ae17dcafb2663485a0fecc551dad661449c
Reviewed-on: https://chromium-review.googlesource.com/384031
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-09-09 22:18:52 +00:00
Scott Graham
afc177ee21 Pull metrics instrumentation out to central file
Solves two problems with having the macros inline:

1. Deduplicates some of the logic (in this case, the name of the
   histogram, and whether it should be divided by 1024);

2. More useful check for compilation. As the macros are no-ops in
   Crashpad, it was easy to use the wrong name for a variable in the
   arguments to the macros (see .mm!)

This way, we have some better chance of at least having code that
compiles when built in Chromium if all the arguments are passed to
Metrics::Something() in a standalone build.

Also rolls mini_chromium DEPS to include:
99213eb Mark histogram arguments as unused to avoid warnings

R=mark@chromium.org
BUG=crashpad:100

Change-Id: I9f7fc3b85854fd61c1ebdf0084d728a7b690c2f1
Reviewed-on: https://chromium-review.googlesource.com/380445
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-09-02 19:13:00 +00:00
Scott Graham
5f42313ed5 Test first integration of UMA plumbing
Add a first example of a UMA entry to have it available to try to plumb
through to Chromium.

Adds LoggingFileSizeByHandle() to util/file/file_io.* to retrieve the
size of on disk file to report to UMA.

Also rolls DEPS for mini_chromium to include:
b5ec9ce Add stub versions of histogram_macros.h

R=mark@chromium.org
BUG=crashpad:100

Change-Id: Ib8e96ad4b7d715b46d2c71810c95c92965a89821
Reviewed-on: https://chromium-review.googlesource.com/338821
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-09-02 00:04:29 +00:00
Mark Mentovai
c822792095 Update buildtools to f8fc76ea5ce4a60cda2fa5d7df3d4a62935b3113
The only thing relevant to Crashpad in the window is:

222bd42ce39d roll clang-format 242086:r258123

Change-Id: Ia175470c12f61ef4dac0e1417143d3cac9d16765
Reviewed-on: https://chromium-review.googlesource.com/368690
Reviewed-by: Scott Graham <scottmg@chromium.org>
2016-08-12 17:31:55 +00:00
Mark Mentovai
e8650f4729 Update googletest to ec44c6c1675c25b9827aacd08c02433cccde7780
30846f31c5e5 Fix typo in googlemock/README.md
a7964a3fbd41 Implement GetThreadCount for AIX
bf7e9e8c2bb3 Add include of sys/types.h
554ca00ff706 Update DevGuide.md
c81cf6b7efde Update .travis.yml
58b543535a57 Update .travis.yml
231af5ddc81a Try to use clang-3.6 in travis
c76f9e0cdd49 Update .travis.yml
e8193fe6e064 Adding llvm toolchain repo
b8f9b2b540d9 Update clang version
bbbc025d2e84 More docs in travis config
6705b9adeabc Override clang++ name on Linux only
4a0b77ff7253 Create CMakeLists.txt
98d988deac06 Add CMake install rules for gtest libraries and headers
c4c23548a19a Merge pull request #614 from DukeXar/master
884dd08d73d7 Merge pull request #628 from fjunqueira/patch-1
93c37d59b013 Merge pull request #632 from nocnokneo/add-cmake-install-
             rules
f44190f2c432 Fix missing-field-initializers GCC/Clang warning (issue
             433)
ffce1a857856 Merge pull request #633 from plopresti/master
3aef7d7ddd3a Update README URLs based on HTTP redirects
83b93eac3b2b Update FAQ.md
25409abfe7a3 Fixing some table error in file
ccd0f94e8217 Merge pull request #592 from Ferenc-/master
96bba4d5c1e9 Merge pull request #638 from KindDragon/patch-1
3c3a4ac2c2fa Merge pull request #640 from Ali-Se/patch-2
6fe019e6b73e Merge pull request #607 from google/BillyDonahue-patch-1
2f93e2d8085e Merge pull request #636 from ReadmeCritic/master
16b9bbc3efb1 Fix AdvancedGuide link in FAQ.md
1f8fe13618a5 Merge pull request #647 from mithro/patch-1
7c8ac4886a7a Added CMake install rules for GMock
ebd1d0887cdb Fix link to FAQ in Primer.md
35fb11efbe1a Merge pull request #654 from cmorse/doc_fix
f601ee162e23 Add include dirs to targets if CMake version supports it
a470862dbe80 fixed link in googlemock documentation
57b376a9cb8b Merge pull request #660 from waynix/FixLinks
c1cd9c2b05d5 Merge pull request #650 from jpuigcerver/master
0162ff72e80e Merge pull request #657 from
             audiofanatic/issue655-targetHeaderDeps
ddb8012eb48b Merge pull request #602 from mtbrandy/threadcount_aix
ac35fe735984 Update GTEST_PROJECT_URL_ in internal/gtest-port.h
13206d6f53aa Merge pull request #670 from dawikur/master
d8df1fb4884c Add link to Google Test Primer docs in README.md
d404af0d987a add python 3 support to tests
456fc2b5c4e9 add python 3 support to fuse_gtest_files script
82b11b8cfcca Merge pull request #678 from pjaytycy/master
340c6b337518 Add tmux and tmux-256color to the colored terminal list
a9b73f8139a9 Merge pull request #699 from achimnol/master
ff5ffd457e03 Merge pull request #688 from tamland/python3
f364e188372e Change error message of EXPECT_EQ to treat lhs and rhs
             equivalently
b648a3072161 Add build artifacts to git ignore
d4aa34b05d72 Fix link that's returned when running tests. #714
f5acf22268d6 Merge pull request #716 from jacob-
             meacham/feature/gitignore
5909d44d348f Merge pull request #715 from jacob-meacham/bugfix/expect-
             call
77d6b1733803 Merge pull request #713 from DarthGandalf/expect
83d3b47acf8a Fix formatting in AdvancedGuide.md
ff07a5de0e81 Merge pull request #719 from paul-
             wilkinson/docs_formatting_fix
d6790f26cae2 Read Bazel's $XML_OUTPUT_FILE environment variable
12b2f23e8e6b Fix inconsistent style
5db9cbbc2332 Restructure $XML_OUTPUT_FILE logic
6991f422b65a Fix env_var_test to ignore XML_OUTPUT_FILE if already set
d23cf2b15701 Restructure test so each scenario is independent
62700bdf5689 Fixed typo ('XCode' -> 'Xcode')
f7248d80eae1 Merge pull request #731 from mattrajca/patch-1
0098be394ad5 Fix typo (Inovke -> Invoke)
eba179631078 Merge pull request #735 from phad/patch-1
72416fab75f0 Merge pull request #724 from duggelz/master
207147495c80 Fix whitespace in paragraph
d225acc90bc3 Merge pull request #741 from mbinna/patch-1
2746b57f78a0 Changed the GTestDir marco value to reflect the new dir of
             googletest
01f3d09f9f6c Updated the value of GTEST_DIR to reflect the googletest
             dir
5bae126d663e Added VS 2015 project support
0a439623f75c Merge pull request #773 from mazong1123/master
e35015f53904 fix to operator precedence in GTEST_TEST_BOOLEAN_ with
             expressions that implement operator bool
2489c3074748 Fix to tests that return object which implement operator
             bool
faee7d1fbcf1 Merge pull request #808 from djmott/master
ce7ec96edab7 Rollback change #808
10799abad25a Merge pull request #810 from google/rollback_808
43c0ae337536 Support running MSVC build on AppVeyour
81345850725f Merge pull request #723 from KindDragon/master
e51026e5d15e Add Appveyor badge to Readme.md
d406cb18c3d7 Merge pull request #814 from google/BillyDonahue-patch-2
531bf5c41071 Fixed issue #775
dc2dbf1fbf1d Reformatted the Unprintable operator== code style
ec44c6c1675c Merge pull request #821 from mazong1123/master

Change-Id: I40169adab6ea260334089b08bf4a51d4a65d6e08
Reviewed-on: https://chromium-review.googlesource.com/368680
Reviewed-by: Scott Graham <scottmg@chromium.org>
2016-08-12 17:30:52 +00:00
Sami Kyostila
e45024b083 Use stl utilities from the base namespace
The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

Change-Id: I059d5d6299f947b1135672da170427d23ac4775e
Reviewed-on: https://chromium-review.googlesource.com/368640
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-08-12 14:31:53 +00:00
Mark Mentovai
18a839c810 Update GYP to 93cc6e2c23e4d5ebd179f388e67aa907d0dfd43d
7904ce96fd01 Make the ninja generator handle symlinked paths correctly
741b7f1d257b Add support for a CPPFLAGS_host environment variable, and
             update the cflags test to verify it
265f495cc3a3 Fix infinite loop on empty variable name
c3d861c8bca4 ninja win: Suppress noisy messages from link.exe when LTCG
             is enabled
8f3918d7408f Promote documents in md-pages branch
b3cef028a51a AIX's cp command does not support -af which is the default,
             so use -RPf which achives something similar
427a0406159c Adding framework path mapping for 'copies' action in gyp
             files
3f21260b4340 Change analyzer to search for build_targets from supplied
             targets
e2e928bacd07 Add support for Xcode LastUpgradeCheck project attributes,
             allowing suppression of Xcode project configuration
             warnings
68f268008844 Add support for kernel-extensions in GYP
ae2d73840216 Set optional LastSwiftUpdateCheck to Xcode project
             attributes
f2c3cfc3b1df win: Fix missing loadable_module dependency in ULDI mode
2c1e6cced235 Revert of e2e928bacd07
0f5bae131e58 Change CMAKE_SOURCE_DIR to CMAKE_CURRENT_LIST_DIR
2dd620e10329 Attempt again to upstream Xcode project version warning
             suppression, from 1416453003 and 1430573009, and rolled
             back in 1423583004
f54bd199e717 Adds back lookup of 'all' targets
70fa8bbeb292 Changes semantics of analyzer
33b351b2eda8 Fix bug in analyze were empty invalid_targets was
             incorrectly written
e1133480da78 Changes analyzer to include test_targets in compile_targets
f06a5a0e46ce Remove deprecated code path from analyzer.py
567d084f2cb1 Add support for NetBSD (OS = netbsd)
c385ad654b30 Copy files with `cp -pPRf` on OpenBSD
f4d65e35719c Generate response files out of the source tree with xcode &
             xcode-ninja
e2313c02ad7b Fix CalculateGeneratorInputInfo for "xcode-ninja" generator
6fb8bd829f0c Derive default for ar_host from ar
70ee80e82bac Error checking to clarify SYSTEMROOT errors
863d9a4f4119 Make ninja work with XCTests for iOS
b85ad3e578da ninja: Correctly handle copies steps in sourceless
             shared_library targets
b362bbfbc877 mac: Extend libtool filter to also match fat builds
2b086540aeed Peter Kasting <pkasting@chromium.org>
4ff48eb18307 Switch the dependencies to their Git mirror
54b7dfc03f74 mac ninja&make: Use xcrun instead of xcodebuild where
             possible
9e2ceaef5352 GYP: Make GYP build deterministic
6f83895e9622 Stop copying deprecated ResourceRules.plist
aa0301be5a24 Allow converting resource plists to binary
87ac4d0e63fc Add limited support for Mac to CMake generator
7ab6f482e87a [iOS] Preserve global symbols when calling strip (-x) on
             today extensions
32cb1709adc3 Add timestamp=none to codesign flags
57190fa27868 [iOS] Update today_extension link flags
18ce4ecf6cf2 [iOS] Set --auto-activate-custom-fonts for ibtool compile
a230124f3834 Avoid gyp_chromium failures when vcvarsall.bat was run
66bbdf4c6b45 Revert "[iOS] Set --auto-activate-custom-fonts for ibtool
             compile."
5170bfd38fe7 [Mac/iOS] Add custom fonts, target device and minimum
             deployment target to _CopyXIBFile
51383232066a Update Xcode emulation extra plist items
7d29c3de1f5e Revert "Update Xcode emulation extra plist items."
b25bbc1f942d Re-land update Xcode emulation extra plist items for Xcode
             7.2
2f9ffdc96135 Support sdk_version of None
ed163ce233f7 Don't recompute environment for mac bundles unnecessarily
0cd47bf6960e Make login.keychain and 'Provisioning Profiles' symlinks
d84fed246cd4 Fix tests with Xcode 7
1950f6761bdf Xcode-ninja: Add excluded files to the project
             sources_for_indexing.xcodeproj
61259d585ce9 ninja/win: Use qualified paths for precompiled headers
5874a3cf9bac Adjust pretty_gyp to align comments with the appropriate
             braces
fbcb317c7513 ninja: Add target_rpath generator flag
133eaf70b372 Add support for iOS Frameworks with header maps
8e8c3178d9d2 Detect and warn on missing vcvarsall.bat
28340b46df65 Support DEVELOPER_DIR in gyp-ninja for mac
3fa0c6038873 [GN] Use hard-link if possible when copying to bundle
697933c2e3b3 Fix mac_tool.py copy-bundle-resource errors
4ec6c4e3a94b [iOS/OS X] Copy file instead of hard-linking them
f9ac7a9ba1c4 gyp-win-tool: Let LinkWrapper only transmogrify / when the
             host platform is Windows
34d3fba9d167 gyp-win-tool: Fix regression from my last change
6ea68631cdab gyp-win-tool: Don't use shell=True on non-Windows hosts
db72e9fcf55b Fix header map nextPowerOf2 method
4cf07e8d6167 [ios-ninja] Support xctests in devices in release
e24c83726b72 Adds support for a new target spec: 'mac_xcuitest_bundle'
             This allows us to create UI testing bundles
02b145a1a4f4 Enabling /ZW (CompileAsWinRT) option for msvs
bce1c7793010 ninja/mac: Add horrible workaround for horrible Xcode 7.3
             ld bug
c61b0b35c839 [gyp-ninja] Set simulator and device SDKROOT for iOS
35eafcd93951 Ignore more Xcode stderr logging information
bac4680ec9a5 Only call CopyStringsFile if convert_to_binary is False
e7079f0e0e14 Fix :rfc1034identifier when the value contains underscore
1f989f652a30 Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py
93cc6e2c23e4 Make the ninja backend transitively check for C++ sources
             to use the C++ compiler for linking

Change-Id: Ifdb705cee07aa0d158b9b1952875041d9f2a14e5
Reviewed-on: https://chromium-review.googlesource.com/367490
Reviewed-by: Scott Graham <scottmg@chromium.org>
2016-08-10 01:02:30 +00:00
Mark Mentovai
26c9d3fa6d Update mini_chromium to 9c5463b4d4b3ad2540c718b7c87809ef4c1ea5c7
09f74a2cf068 Import StringPieceHash from chromium
9c5463b4d4b3 mac: Use Unified Logging when the deployment target is
             10.12 or higher

Change-Id: I2675f07f3e136dfcc2948928543bd2bff07809ea
Reviewed-on: https://chromium-review.googlesource.com/366780
Reviewed-by: Scott Graham <scottmg@chromium.org>
2016-08-05 16:39:03 +00:00
Scott Graham
00d458adaf Roll mini_chromium to 964ee49aa24e8bfb4823cd9034a3b32ec3cb09e9
964ee49a Add HAS_FEATURE to base/compiler_specific.h
6d65ac85 Remove base/memory/scoped_ptr.h

Change-Id: Ia3d31daf515585df049485408438047b4d2db1bc
Reviewed-on: https://chromium-review.googlesource.com/340499
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2016-04-25 19:35:02 +00:00
Scott Graham
a4649789a5 Roll mini_chromium to 0a9dc1c4feeabee38f81bcb5ff9c925697755c35
0a9dc1c4 Add base/memory/ptr_util.h for https://codereview.chromium.org/1911823002/
ec5d4571 Add base/bit_cast.h to follow https://codereview.chromium.org/399313006

Change-Id: I28ef61f8951c9fa64aaeb497ae11d0288a57111d
Reviewed-on: https://chromium-review.googlesource.com/340467
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2016-04-25 18:55:15 +00:00
Scott Graham
b6089da2bf Roll mini_chromium to 783fdf3ccc1ce1e054e50f6c75bbd97af8503141
783fdf3c: Add base::debug::Alias from Chromium base

Change-Id: Ibd2347cd35b09b171b355e5671c47df62e413534
Reviewed-on: https://chromium-review.googlesource.com/340259
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-04-22 18:16:14 +00:00
Mark Mentovai
82af299823 Update mini_chromium to 7c5b0c1ab44a4264b02f4c825a5b73d9173253e4
7c5b0c1ab44a Use Gerrit (Polygerrit) for mini_chromium code review

Change-Id: I883672b91dac5387031e913dd62a1802d2163e9f
Reviewed-on: https://chromium-review.googlesource.com/323140
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2016-01-27 16:45:44 +00:00
Mark Mentovai
b7e4564ff2 Update mini_chromium to a43fee120b10ed71df4e55a370948ca461d78232
a43fee120b10 Sync Mac scopers with upstream Chromium

This adapts to updated Mac scopers from Chromium cfd6ed5600d8, including
the changes from that commit and Chromium f39d4ffc6c32.

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1565873002 .
2016-01-06 12:31:59 -05:00
Mark Mentovai
6d2d31d2d1 Use base/macros.h instead of base/basictypes.h
This was done in Chromium’s local copy of Crashpad in 562827afb599. This
change is similar to that one, except more care was taken to avoid
including headers from a .cc or _test.cc when already included by the
associated .h. Rather than using <stddef.h> for size_t, Crashpad has
always used <sys/types.h>, so that’s used here as well.

This updates mini_chromium to 8a2363f486e3a0dc562a68884832d06d28d38dcc,
which removes base/basictypes.h.

e128dcf10122 Remove base/move.h; use std::move() instead of Pass()
8a2363f486e3 Move basictypes.h to macros.h

R=avi@chromium.org

Review URL: https://codereview.chromium.org/1566713002 .
2016-01-06 12:22:50 -05:00
Mark Mentovai
c60ec9beeb Update gtest to 786564fa4a3c8e0f908acca32cce481de5481b9f
8b085f0d2168 Fix warnings encountered in MSVC build of gtest/gmock tests
322a4914a309 Better use of character constants
cbce23fb8670 Leave decltype(max_ulps_) alone and cast, not sure this is
             better
cfe466a0a753 Use a templated helper to wrap the cast
4a8e54401e49 Name the helper AsBits()
786564fa4a3c Merge pull request #627 from mark-chromium/tests_msvs

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1467283002 .
2015-11-23 13:17:11 -05:00
Mark Mentovai
e1dc5d6dbe Update mini_chromium to 43f04e7299621f708801bf475c84d9f294826ff9
43f04e729962 win: Compile with /bigobj

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1465083003 .
2015-11-23 12:52:06 -05:00
Mark Mentovai
6e89d45d7d Switch googletest and googlemock to pull from the GitHub git repository
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1404033002 .
2015-11-11 11:13:37 -05:00
Mark Mentovai
97b0f86d0c Update mini_chromium to ea8d8de53f9407d57cab716fef2a36b6bf1b78b2
985372e5da14 win: Send log messages to a debugger via
             OutputDebugString()
06e0fa1309a0 win: Use FormatMessage[W]() instead of FormatMessageA() for
             logging
ea8d8de53f94 mac: Log messages to the system log via ASL

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1417803006 .
2015-11-10 17:03:09 -05:00
Mark Mentovai
20045d3867 Add buildtools to make depot_tools-wrapped clang-format work
Crashpad is mostly friendly with clang-format and has its own
.clang-format file. Adding buildtools makes it possible to use the
depot_tools clang-format wrapper.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1414903006 .
2015-11-05 13:48:27 -05:00
Scott Graham
ba0e7de07b win: Disable more warnings when not building with Crashpad's common.gypi
Roll mini_chromium deps to remove disabling of those warnings in common.gypi:
  8e12d3d win: Remove disabling some warnings

R=mark@chromium.org
BUG=chromium:546288, crashpad:1

Review URL: https://codereview.chromium.org/1430523002 .
2015-10-27 16:03:26 -07:00
Scott Graham
63916623cd roll mini_chromium to 8d42e2439aa0bd677dca64ba3070f3fa2353b7f2
8d42e24 win: Enable C4800, implicit bool conversion
82060c1 mac: Make Mach port scopers better ScopedGenerics
d7270da Fix base::RandDouble()

R=mark@chromium.org

Committed: 26b6913512

Review URL: https://codereview.chromium.org/1424463002 .
2015-10-22 15:02:48 -07:00
Scott Graham
26b6913512 roll mini_chromium to 744f209e621224b703cc897581c8d7bf4416f49b
744f209 win: Enable C4800, implicit bool conversion
82060c1 mac: Make Mach port scopers better ScopedGenerics
d7270da Fix base::RandDouble()

R=mark@chromium.org

Review URL: https://codereview.chromium.org/1424463002 .
2015-10-22 14:49:50 -07:00
Mark Mentovai
f059c21048 Update mini_chromium to c9625ad5d23c25fbb477e7dbb4c1c8b9a9360f41
c9625ad5d23c Update base/numerics/* and base/template_util.h

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1407603002 .
2015-10-13 13:19:19 -07:00
Scott Graham
7942b87fcb Roll mini_chromium to 133a8c61c2567da9e72d4551a7cd5d5d2836e25c
Pulls in:

133a8c61c: win: Turn on ASLR by default

R=mark@chromium.org

Review URL: https://codereview.chromium.org/1380163002 .
2015-10-01 11:38:34 -07:00
Mark Mentovai
70b60d7a19 Update mini_chromium to 928f9c45fe2d0823ff1f734adb448e672e21d9af
928f9c45fe2d win: Allow frame pointer omission (FPO, /Oy)

BUG=crashpad:53
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1375153003 .
2015-09-30 14:22:45 -04:00
Scott Graham
5d026ea68b Roll mini_chromium to f39aac9cec3c70fe7ea1c6b6176a6678ab47d4d4
Pulls in:

win: Update iterator debug settings to match VS default, and be explicit about which runtime library

R=mark@chromium.org
TBR=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/1362043003 .
2015-09-23 10:39:52 -07:00
Mark Mentovai
00a422357d Update GYP to 01528c7244837168a1c80f06ff60fa5a9793c824
8c31354f5e0c Fix mixed line endings warning
4f4c7cb5a63e Add TestGypXcodeNinja to run tests against the xcode-ninja
             generator
f1dc682b70a6 Fix: xcode-ninja should generate Xcode workspace into
             generator_output
cdf037c1edc0 Fix: xcode-ninja should copy the product extension to the
             wrapper project
82b08049cc0b Set ZERO_AR_DATE=1 when running libtool.
8b69f7d23df5 Add support for generating an Eclipse .classpath file (bug
             fix)
789a019a8320 Don't serialize linking for the make generator by default
194ec65a55ed Revert 2011 'Fixed Gyp Xcode generator for libraries with
             identical names.'
91a89564da3d Add 'depfile' option to actions.
3dde7bfb50a6 don't assume bash is installed
28384e55a5c8 msvs/ninja win: Fix support for
             ImageHasSafeExceptionHandlers
adb7d24b9fc1 Revert "msvs/ninja win: Fix support for
             ImageHasSafeExceptionHandlers"
b28bd7ddd143 win: 'EnableEnhancedInstructionSet': '5' now enables
             /arch:AVX2.
104e21ecf6f2 mac: Followup to ZERO_AR_DATE, touch the -o archive,
             rather than expecting only one
4d7c139b1820 win: Add NoImportLibrary flag for ninja generator
67000714d51e Reland "msvs/ninja win: Fix support for
             ImageHasSafeExceptionHandlers"
16f9f4566f5d msvs: Prefer x64 toolset if we are running on 64-bit
6194e32f7fcb Make msvs-ninja work for target-arch=x64
34640080d08a ninja/posix: Introduce support for arflags variable.
7cd601835636 Updating gyp repo for git, preparing for cq.
dd831fd86e7a Fix script url.
a5bd08f28629 Adds the ability for 'copies' in Xcode project files to
             specify the 'Code Sign on Copy' option.
002ebe4420a3 Fixed version of https://codereview.chromium.org/748793002
50ab31edc847 Fix typo in ternary operator.
4a9b712d5cb4 Fix gyp analyzer generator on mac.
d9823985797f Convert plist and strings to binary for iOS.
28c00336a403 Bump Xcode compatibility version from 45 (Xcode 2.4-3.1) to
             46 (Xcode 3.2).
2cd9d0633c96 [ninja-xcode] Include action inputs in hybrid builds.
d174d75bf69c Export generator flavor to gyp scripts
2b44e5987d5a Add missing identity variables to gypd generator.
e1c8fcf74b68 Assert when source is an absolute path
c5859a298166 Migrate GYP docs over from the wiki.
69dfb493a22f LLVM_LTO support for make / ninja
2889664b9fa8 Address scottmg comments from
             https://codereview.chromium.org/1003273007/.
2a5511bd901f Improve generated Makefile rules for rules several outputs.
2f66a3f94953 Whitespace change to test the new GYP waterfalls.
3601f26003c6 Make dump_dependency_json.py write <| list files to the
             output directory rather than the source tree.
8866260996c0 win: prefer amd64_x86 compiler on >= 2013, not just 2013
0bb67471bca0 Slightly better docs for git instead of svn
f34b9aa7c9d6 Remove the Android generator.
9f594095c5b1 Added msvs_application_type_revision for winrt compilation
c0cf1f22eb42 Revert "Stop checking for duplicate basenames"
4dd5d3c614fb Update shared_library test after c0cf1f22eb
29e94a3285ee Avoid lint presubmit error in dump_dependency_json
08429da7955a Update cmake generator to handle Skia Android build.
aa537916dcb5 msvs: Make sure stdout/stderr from rule commands get logged
fdc7b812f99e Makes analyzer always output static_libraries that have
             changed
79de4031069f Fix gyp->make translation of rules with several outputs.
9b2b25aececd Correct braces in input format reference doc.
b4781fc38236 MSVS: Normalize paths against gyp directory.
127b311bf61d Adds some debugging output to analyzer
fdcd8bc10c93 More debugging for analyzer
acfc10d29072 Revert "MSVS: Normalize paths against gyp directory."
5122240c5e5c Fix support for iOS today extensions on latest Xcode beta.
ae276266d580 Make DependencyGraph.DeepDependencies() depth-first.
25ed9ac4ac2a Do not remote duplicate entries from ldflags when
             generating ninja files as it changes behavior
6ee91ad86598 Reduce DefaultConcurrentLinks from phys/4GB to phys/5GB.
658f3a81995b Disable currently failing gyp tests on win to make the bots
             green.
479dacf7be5f Disable GYP tests currently failing on the Mac bot
36d99ff23099 Disable test/win/gyptest-link-defrelink.py
d6adc48df899 Fix the default tryserver lists in PRESUBMIT.py.
81c2e5ff92af Added msvs_target_platform_version and
             msvs_target_platform_minversion for winrt compilation
010fb9d696e7 msvs_emulation: Add support for StackReserveSize and
             StackCommitSize
edccc7bad7da Analyzer didn't match correctly targets that defined path
             to inputs with '.' relative path values. So let normalize
             path before matching.
bae26e800c7f Inject pylib first in the path. This ensures that test load
             the version of pylib in this repo, not elsewhere on the
             system.
008cf1c04393 Improve error messages when <!(commands) fail
121d89dfcd4f Make RelativePath use abspath rather than realpath for the
             'path' variable. This allows gyp to work correctly in
             symlink-heavy environments. Basically, this is because gyp
             paths need to be in a consistent tree, so we need to
             compute a path to the target within the *stated* tree, even
             if it is not the real underlying path to the target. The
             'relative_path' variable does need to be resolved using
             realpath, since gyp or the underlying build system might cd
             to it before looking for the 'path' target.
2b17e0b26a93 Fix paths with different seperators being compared in the
             analyzer on Windows.
5d01a8cda53b Revert "Make RelativePath use abspath rather than realpath
             for the 'path' variable."
1f374df95de1 Make sure GYP supports compiling managed code.
cf3170e30578 Update gyp LINK_COMMANDS_AIX to support both 32-bit and
             64-bit files. * cmd_alink: Add -X32_64 option. *
             cmd_alink_thin: Add -X32_64 option.
01528c724483 Fallback to '.tbd' for system missing '.dylib'.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1358583003 .
2015-09-18 19:02:17 -04:00
Scott Graham
bf94f98ecc Roll mini_chromium to 302e4e7d9aa0a8d39ad62b193a4c8a8357ad9d0c
Pulls in "win: Don't omit frame pointers".

TBR=mark@chromium.org
BUG=crashpad:50

Review URL: https://codereview.chromium.org/1348883003 .
2015-09-16 14:35:28 -07:00
Scott Graham
4f3f1b68d5 Roll mini_chromium to 71c2f4d01e52aa0e2fb9bf6118f147905e50e284
Removes basictypes.h implicit_cast.

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/1345603002 .
2015-09-14 15:12:08 -07:00
Mark Mentovai
43a71b9302 Update mini_chromium to db01ece1d0dd.
This update includes:

db01ece1d0dd Remove strcasecmp() and strncasecmp()

BUG=chromium:472900

Review URL: https://codereview.chromium.org/1274773003 .
2015-08-05 16:41:49 -04:00
Jackie Quinn
797adb3206 Roll DEPS for mini_chromium for updates to base/posix/safe_strerror
Also updates includes and usage of safe_strerror.

BUG=499322
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1181043002.

Patch from Jackie Quinn <jyquinn@chromium.org>.
2015-06-11 20:25:49 -04:00
Mark Mentovai
7d454ae713 ThreadLogMessages: don’t check TLS slot initialization return value.
This updates Crashpad for https://codereview.chromium.org/1124493002/.

The mini_chromium update includes:

98264cf63f22 ThreadLocalStorage: remove the return value from slot
             initialization

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1129793004
2015-05-06 17:04:44 -04:00
Scott Graham
ff52791faf Get generate_dump compiling on Windows
Sort of works in that the process is opened, modules retrieved, etc.
but eventually CHECKs due to missing functionality in snapshot.

Follows https://codereview.chromium.org/1119783005/.

R=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/1120383003
2015-05-06 11:09:31 -07:00
Scott Graham
17b770ece4 win: get tools/crashpad_database_util mostly working
- Add public domain getopt implementation to third_party.
- Add timegm to compat/win.
- Add stub of strptime to compat/win.

Requires https://codereview.chromium.org/1119173003/ and
https://codereview.chromium.org/1117013006/.

Rather than working in wchar_t everywhere on Windows, convert
UTF16 command line arguments in wmain to UTF8, work primarily
in UTF8, and convert back when necessary to UTF16 for base::FilePath.
This avoids the need to genericize over all the standard C string
functions, getopt, etc. while still handling non-ASCII properly.

R=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/1119783005
2015-05-06 10:28:07 -07:00
Mark Mentovai
e95224bbe7 Add ThreadLogMessages and its test.
This updates mini_chromium to 91ea4908ffd74d9c886bd2f8ccbfae6d31c499af.
The last five commits listed here are required to support this change.
The mini_chromium update includes:

c1745a924c5c Fix paths to atomicops files in base.gyp from 2f02dcc73536
108e9247189c Add #include of <unistd.h> to close_nocancel.cc
6e4f98a9edf8 Add logging::SetLogMessageHandler()
4063fcb8f460 Add base::ThreadLocalStorage
4870f18a33a6 Add base::LazyInstance
0d31b1f3a289 Fix base/memory/aligned_memory.h for MSVC
91ea4908ffd7 base/logging.h: DCHECK() should always reference its
             condition

BUG=crashpad:26
TEST=crashpad_util_test ThreadLogMessages.*
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1041643003
2015-03-30 14:51:34 -04:00
Scott Graham
79ae055e50 Add Locking calls to file_io.h plus implementations and test
Towards removing use of open() with O_EXLOCK/O_SHLOCK in code
used on non-BSD.

Adds simple Thread abstraction to util/test.

Includes mini_chromium roll with:
56dd2883170d0df0ec89af0e7862af3f9aaa9be6 Fix import of atomicops for Windows
886592fd6677615c54c4156bb2f2edb5d547ba6c Export SystemErrorCodeToString

R=mark@chromium.org, rsesek@chromium.org
BUG=crashpad:1, crashpad:13

Review URL: https://codereview.chromium.org/1001673002
2015-03-20 15:45:54 -07:00
Mark Mentovai
8b4932e560 Update mini_chromium to 31e989ac0b03d50ebe71bfa13417c7f8b66db1b8.
cbbdc1b965ec  Fix include guards in base/atomicops*
8f3fade515f6  Clean up -Wunused-parameter warnings reachable by Crashpad
              clients
31e989ac0b03  Declare string16 traits’ move() correctly

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1021363002
2015-03-20 15:24:54 -04:00
Scott Graham
7fa250c9a2 Roll mini_chromium to 2f02dcc735362f33618655ebe663b8abdf85e8bc
Includes
2f02dcc735362f33618655ebe663b8abdf85e8bc Pull in base/atomicops.h from chromium

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/1005383003
2015-03-19 16:08:39 -07:00
Mark Mentovai
1e12b471e3 Update mini_chromium to 6c49a5924dea1e0bd71d568f371c08d754d8aeb8.
c503b8bc1e03  Suppress unused Debug_x64 and Release_x64 configurations
              on non-Windows
6c49a5924dea  Switch between x86 and x86_64 with the target_arch GYP
              variable

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1022493002
2015-03-18 11:27:36 -04:00
Robert Sesek
36ad2d0ee5 Roll mini_chromium to b3d221e85747.
BUG=crashpad:14
R=mark@chromium.org

Review URL: https://codereview.chromium.org/997993002
2015-03-11 14:08:33 -04:00
Mark Mentovai
55f8f29ace Update mini_chromium to 6d162c334672176a62c213d2183b848760644a7b,
picking up:

e7847b381703  10.10 compatibility for base::mac::ScopedLaunchData
6d162c334672  common.gypi: sync compiler options with Chromium

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/991953003
2015-03-09 15:26:30 -04:00
Mark Mentovai
bc401f6aac util/mac: Provide wrappers for <launch.h> functions deprecated in 10.10.
The 10.10 SDK deprecates <launch.h>, but this file is still useful and
is used by util/mac/launchd.* and util/mac/service_management.*. Wrap
the <launch.h> functions in versions that ignore the deprecation
warnings.

BUG=crashpad:10
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/989733003
2015-03-06 22:27:25 -05:00
Scott Graham
05213fd733 Roll mini_chromium to 8773bfd3a0006ee8795b296b6f772e08b7d518c5
Includes:
- win: Default build to x64

TBR=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/981413002
2015-03-06 16:10:41 -08:00
Scott Graham
84eb68bae6 Roll mini_chromium to aa3673adb3ba19303a73e406b3765ce5622a5089
Includes:
win: disable C4996 warning about deprecated functions

TBR=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/971823003
2015-03-02 13:15:05 -08:00
Scott Graham
619cc5f3df roll mini_chromium to fb514aa4270ded201e841de6c2f45c72eafb236c
Includes

fb514aa4270ded201e841de6c2f45c72eafb236c Add MSVS_ warning suppression macros
a89b5f1a7ef7b218925b5d553e1b6ab4eac6cf7f Pull ALLOW_UNUSED_LOCAL/_TYPE and remove ALLOW_UNUSED

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/902893002
2015-02-05 09:34:46 -08:00
Scott Graham
2289339777 Roll mini_chromium to 99f91222f4c99b1420ca8cc76d4effc9a6204da0
Includes:

99f91222f4c99b1420ca8cc76d4effc9a6204da0 Pull in ALIGNAS, define WIN32_LEAN_AND_MEAN
b16178f53bae86cef24c971de40cca1470a61374 Fix compile error in StringPiece

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/893203003
2015-02-03 11:26:29 -08:00
Scott Graham
070ea9bfd7 roll mini_chromium to 45cbbb054ccef2e77d5233aa95c5f2742a23dec1
Includes:
45cbbb054ccef2e77d5233aa95c5f2742a23dec1 Add FilePath::FinalExtension and RemoveFinalExtension

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/860863002
2015-01-20 10:22:02 -08:00
Scott Graham
c4a5f7de28 Roll mini_chromium to 3ce1cc29260d5b49ac21d96454a778c02f583172
Includes:

3ce1cc29260d5b49ac21d96454a778c02f583172 Pull in base/format_macros.h from Chromium, unmodified
028fa7ca08fe98ae215589a53dae03c498b45bff win: Add advapi32 to link, required for rand_util.cc "SystemFunction036"

R=mark@chromium.org
TBR=rsesek@chromium.org

Review URL: https://codereview.chromium.org/837703003
2015-01-15 09:59:09 -08:00
Scott Graham
cd4a2f83e6 Roll mini_chromium to 836497baf21c5fbb7876573dc1dadef4c023a87d
Includes:
836497baf21c5fbb7876573dc1dadef4c023a87d win: Default to /SUBSYSTEM:CONSOLE

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/844443003
2015-01-06 17:01:07 -08:00
Scott Graham
4e8a78c182 Roll mini_chromium to 4d84318dbcdf46b543ab4556736cf8a9ae3ced18
Includes:
4d84318dbcdf46b543ab4556736cf8a9ae3ced18 win: Disable C4201, nameless struct/union warning
864f44f98bb8e6869b1243de9b2ebd3f50a03a21 Exclude _test suffixed files too

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/817093002
2014-12-19 15:02:54 -08:00
Scott Graham
26c6f19927 Roll mini_chromium to 43b7cd397e5f239e59700831430b703d9a4a3b4f
Includes:
43b7cd397e5f239e59700831430b703d9a4a3b4f win: Fix for logging.h ERROR, again
a83f160101c6b054bdcfe81dea62340c7d933778 win: implement sys_byteorder.h

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/817443002
2014-12-18 09:29:46 -08:00
Mark Mentovai
3d84a738d0 Update GYP to svn r2015 (32ca1cd8e010).
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/813873002
2014-12-17 16:03:58 -05:00
Mark Mentovai
9d2c1cffa2 Update mini_chromium to 222feaf3d302.
This picks up:

222feaf3d302 Update README
e38cddb83571 Lock: don’t require NativeThreadType to be a pointer type
8c599712d10c Include What You Use: <string.h> for memmove() and memcpy()
ef991f44ed63 Linux: always build in C++11 mode

BUG=crashpad:6
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/812133002
2014-12-17 16:01:35 -05:00
Mark Mentovai
86cf286350 Update mini_chromium to 158694255c7a.
This picks up:

158694255c7a win: undef ERROR, causing failing LOGs
3a981db6e6df MSVC: Disable “warning C4702: unreachable code”.
e87cd9d4dff5 Tidy string16.h after
             https://codereview.chromium.org/809563003/

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/812683002
2014-12-16 17:12:30 -05:00
Scott Graham
086714261a Roll mini_chromium to 2ef83a609517f284096f7e8296b0915d634c3ca7
Pick up build fix.

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/804853004
2014-12-15 16:46:46 -08:00
Scott Graham
7941e7f955 Roll mini_chromium to 463f840...
To pull in string16 changes.

TBR=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/811613002
2014-12-15 16:31:15 -08:00
Scott Graham
5c59a1fa18 Roll mini_chromium to 001bf11...
And another roll to get to mini_chromium to HEAD.

R=mark@chromium.org
TBR=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/799923005
2014-12-12 12:23:42 -08:00
Scott Graham
af07f4022b Move string16 and char16 in to base::
Needs to include roll with https://codereview.chromium.org/803593002/ included.

R=mark@chromium.org

Review URL: https://codereview.chromium.org/804593002
2014-12-12 11:06:09 -08:00
Scott Graham
1c4084fc2d Roll mini_chromium to 9427a67...
To pick up progress on compiling base on Windows.

TBR=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/790343004
2014-12-11 16:31:40 -08:00
Scott Graham
f721df692e Revert 'Roll mini_chromium DEPS to a1fa3c5...'
mini_chromium rev broken, will fix and re-roll.

TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/797553003
2014-12-11 14:41:51 -08:00
Scott Graham
c46dd63762 Roll mini_chromium DEPS to a1fa3c5...
Want to roll the mini_chromium changes in little chunks as the bot
doesn't otherwise build them, to avoid leaving something broken
for a while.

R=mark@chromium.org
TBR=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/796113002
2014-12-11 14:33:34 -08:00
Mark Mentovai
85c9318597 Add ChildPortHandshake and its test.
ChildPortHandshake is the most generic system yet to allow child
processes to provide their parents with Mach rights. These are
ordinarily expected to be send rights to the children’s own task ports,
or send rights to servers that the children hold receive rights to.

This updates DEPS to pull mini_chromium 1d3523dbda93, which includes
base::mac::ScopedMachPortSet.

TEST=util_test ChildPortHandshake.*
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/756603003
2014-11-25 14:56:05 -05:00
Mark Mentovai
d0212ebaee Update gtest and gmock to the latest versions.
In b6a0183ccec7, gtest and gmock were held back at older versions with
limited C++11 support, because the then-current heads of each did not
work well in environments with C++11 language support but pre-C++11
library support. This is the environment that Chrome code for Mac builds
in. All necessary patches for this have been merged upstream, and this
has been corrected in the current released versions of gtest and gmock.

TEST=*
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/731473007
2014-11-19 11:37:26 -05:00
Mark Mentovai
0a4ea0b52d minidump: Change the ownership model.
All minidump objects now own their all of their children, rather than
having them maintain weak pointers and requiring callers to maintain
ownership.

The only weak object in the entire tree now is the “extra memory” added
to a MinidumpMemoryListWriter by its AddExtraMemory() method. Extra
memory aliases objects owned elsewhere in the tree, typically by a
MinidumpThreadWriter as stack memory. Non-“extra” memory added to a
MinidumpMemoryListWriter by its AddMemory() method is strongly owned.

Many objects are now deleted through base pointers, and in those cases,
the base classes now have public virtual destructors. The ultimate base,
MinidumpWritable, is still protected to guard against direct
instantiation and deletion, and thus its destructor does not need to be
virtual.

This updates mini_chromium to eeb3b6a4f020 specifically for that
revision, which includes necessary updates to scoped_ptr. It also picks
up:

eeb3b6a4f020 Update base/move.h and base/memory/scoped_ptr.h to match
67ad2efafaba More porting to Windows
be27a006421e AUTHORS: Fix link post-git migration flag day.
05f5b1503230 Add codereview.settings to mini_chromium.
a32c2b199811 Beginnings of Windows support in mini_chromium

TEST=minidump_test
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/674153002
2014-10-27 15:01:39 -04:00
Mark Mentovai
fee5d8aea9 Add uint128_struct and its test.
This will be used in the upcoming Minidump context structures.

This also updates mini_chromium to ba9b15f1b6a7 to pick up:

ba9b15f1b6a7 Make bit_cast available in C++11 mode.

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/583283003
2014-09-22 15:46:00 -04:00
Mark Mentovai
4517d7c866 Update mini_chromium to get close$NOCANCEL, and update GYP to keep up.
Update mini_chromium to 313bd83d6d9d, picking up:

313bd83d6d9d Use close$NOCANCEL on Mac, as in Chrome r23369.
15a69caf735f Add some things from base/synchronization:
             ConditionVariable and Lock.

Also, udpate GYP to 46282cedf40f (r1977), picking up:

r1977 android: Add a way to override build system variables.
r1976 android: Don't emit useless info into generated makefiles.
r1975 Fix indentation for emacs and add missing keyword.
r1974 Changes ninja generator to only output empty names if not already
      output
r1973 Changes the ninja generator to output phony targets for
      uninteresting targets
r1972 Makes matching of build files work when absolute
r1971 Support for custom NM/readelf binaries in your toolchain.
r1970 android: Support host multilib builds.
r1969 Makes analyzer output names of all executable target types
r1968 android: Make buildbot able to use a custom manifest.
r1967 ninja win: don't expect pdb to be generated when
      GenerateDebugInformation: false
r1966 Makes the analyzer output the set of targets needing a build
r1965 Removes old way to specify files to look for
r1964 Provide a way to suppress implicit MIDL generation rules for
      actions
r1963 Style changes for analyzer __ -> _ and lots of single newlines to
      double newlines.
r1962 Changes for analyzer
r1961 Pull in relevant targets when using xcode-ninja
r1960 Guard against configurations without 'xcode_settings'
r1959 Updates analyzer to output to a file

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/590033002
2014-09-22 13:18:38 -04:00
Mark Mentovai
b6a0183cce gtest, gmock: pull older versions via DEPS that don’t require C++11
library support.

When building with support for Mac OS X 10.6, C++11 library support is
not available, because Mac OS X uses libc++ for C++11 support, and Mac
OS X 10.6 does not provide libc++ as a runtime library. gtest and gmock
have a hard time distinguishing between C++11 language and library
support (which is not really their fault, having one but not the other
is an odd situation). The currently-released trunk versions of gtest and
gmock do not work in this configuration. I’ve submitted patches upstream
to fix this, but they may take a while to make it to the released
verions. For now, it’s fine to roll gtest and gmock back to versions
from December 2013 that do work cleanly with C++11 language support but
only C++03 library support.

TEST=Compile and run all tests in both 10.6 and native builds
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/572613002
2014-09-15 15:09:42 -04:00
Mark Mentovai
01f9e396b8 Include <limits.h> in util/file/file_writer.cc because it uses IOV_MAX.
This also updates mini_chromium to abd6e3792f4f.

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/469093002
2014-08-14 09:58:31 -07:00
Mark Mentovai
3cad76870c Update mini_chromium to bd605a3773f5.
bd605a3773f5 Fix RandBytesAsString().

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/416323004
2014-08-03 17:57:41 -04:00
Mark Mentovai
995012534e Introduce MinidumpWritable, its dependencies, and their tests.
MinidumpWritable is the base class for all minidump-writing operations.

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
Mark Mentovai
fbcd680b50 Initial commit of Crashpad.
This commit contains the basic structure of the project:
 - LICENSE and related files.
 - DEPS to check dependencies out into third_party.
 - README.crashpad files and .gyp files to accompany third_party
   dependencies.
 - Infrastructure to run GYP as a gclient hook.
 - codereview.settings to enable Rietveld code review.
 - Assorted other administrative and dot-files.

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/426403002
2014-07-30 23:24:58 -04:00