3 Commits

Author	SHA1	Message	Date
Mark Mentovai	20e5aba1af	URL cleanups: switch to HTTPS, fix dead ones, use canonical ones ... Change-Id: I4b247d7fae1a212350f8ffcf2bf5ba1fa730f5c1 Reviewed-on: https://chromium-review.googlesource.com/780339 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>	2017-11-20 22:23:39 +00:00
Scott Graham	a02ba24006	Convert from scoped_ptr to std::unique_ptr ... Follows https://codereview.chromium.org/1911823002/ but fixes includes that were messed up there. Change-Id: Ic4bad7d095ee6f5a1c9f8ca2d11ac9e67d55a626 Reviewed-on: https://chromium-review.googlesource.com/340497 Reviewed-by: Robert Sesek <rsesek@chromium.org>	2016-04-25 19:16:26 +00:00
Mark Mentovai	5be8ce4ea0	Get module versions and types from in-memory images ... Don't call GetFileVersionInfo(), which calls LoadLibrary() to be able to access the module's resources. Loading modules from the crashy process into the handler process can cause trouble. The Crashpad handler definitely doesn't want to run arbitrary modules' module initializer code. Since the VS_FIXEDFILEINFO needed is already in memory in the remote process' address space, just access it from there. BUG=crashpad:78 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1475023004 .	2015-12-01 17:06:37 -05:00