Remove a few unnecessary semicolons.

Patch by Nico Weber <thakis@chromium.org>, originally
https://crrev.com/c/1463405.

Bug: chromium:926235
Change-Id: I7e0ba822aa8dd104768d7ad6e603539576ae96a9
Reviewed-on: https://chromium-review.googlesource.com/c/1463744
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
This commit is contained in:
Mark Mentovai 2019-02-11 10:59:14 -05:00 committed by Commit Bot
parent 152aa8d1f9
commit ff5a25e11f
8 changed files with 20 additions and 21 deletions

View File

@ -42,7 +42,7 @@ class MinidumpUserStreamWriter::SnapshotContentsWriter final
return snapshot_->Read(this); return snapshot_->Read(this);
} }
size_t GetSize() const override { return snapshot_ ? snapshot_->Size() : 0; }; size_t GetSize() const override { return snapshot_ ? snapshot_->Size() : 0; }
bool MemorySnapshotDelegateRead(void* data, size_t size) override { bool MemorySnapshotDelegateRead(void* data, size_t size) override {
return writer_->Write(data, size); return writer_->Write(data, size);

View File

@ -160,29 +160,29 @@ bool CrashpadInfoReader::Initialize(const ProcessMemoryRange* memory,
return GET_MEMBER(member); \ return GET_MEMBER(member); \
} }
DEFINE_GETTER(TriState, CrashpadHandlerBehavior, crashpad_handler_behavior); DEFINE_GETTER(TriState, CrashpadHandlerBehavior, crashpad_handler_behavior)
DEFINE_GETTER(TriState, DEFINE_GETTER(TriState,
SystemCrashReporterForwarding, SystemCrashReporterForwarding,
system_crash_reporter_forwarding); system_crash_reporter_forwarding)
DEFINE_GETTER(TriState, DEFINE_GETTER(TriState,
GatherIndirectlyReferencedMemory, GatherIndirectlyReferencedMemory,
gather_indirectly_referenced_memory); gather_indirectly_referenced_memory)
DEFINE_GETTER(uint32_t, DEFINE_GETTER(uint32_t,
IndirectlyReferencedMemoryCap, IndirectlyReferencedMemoryCap,
indirectly_referenced_memory_cap); indirectly_referenced_memory_cap)
DEFINE_GETTER(VMAddress, ExtraMemoryRanges, extra_memory_ranges); DEFINE_GETTER(VMAddress, ExtraMemoryRanges, extra_memory_ranges)
DEFINE_GETTER(VMAddress, SimpleAnnotations, simple_annotations); DEFINE_GETTER(VMAddress, SimpleAnnotations, simple_annotations)
DEFINE_GETTER(VMAddress, AnnotationsList, annotations_list); DEFINE_GETTER(VMAddress, AnnotationsList, annotations_list)
DEFINE_GETTER(VMAddress, DEFINE_GETTER(VMAddress,
UserDataMinidumpStreamHead, UserDataMinidumpStreamHead,
user_data_minidump_stream_head); user_data_minidump_stream_head)
#undef DEFINE_GETTER #undef DEFINE_GETTER
#undef GET_MEMBER #undef GET_MEMBER

View File

@ -49,8 +49,8 @@
#endif // OS_FUCHSIA #endif // OS_FUCHSIA
extern "C" { extern "C" {
__attribute__((visibility("default"))) void __attribute__((visibility("default"))) void ElfImageReaderTestExportedSymbol() {
ElfImageReaderTestExportedSymbol(){}; }
} // extern "C" } // extern "C"
namespace crashpad { namespace crashpad {

View File

@ -25,7 +25,7 @@ namespace crashpad {
class MinidumpStream { class MinidumpStream {
public: public:
MinidumpStream(uint32_t stream_type, std::vector<uint8_t> data) MinidumpStream(uint32_t stream_type, std::vector<uint8_t> data)
: stream_type_(stream_type), data_(data){}; : stream_type_(stream_type), data_(data) {}
uint32_t stream_type() const { return stream_type_; } uint32_t stream_type() const { return stream_type_; }
const std::vector<uint8_t>& data() const { return data_; } const std::vector<uint8_t>& data() const { return data_; }

View File

@ -26,7 +26,7 @@ namespace test {
namespace internal { namespace internal {
struct MultiprocessInfo; struct MultiprocessInfo;
}; } // namespace internal
//! \brief Manages a multiprocess test. //! \brief Manages a multiprocess test.
//! //!

View File

@ -72,8 +72,7 @@ TEST(MultiprocessExec, MultiprocessExecSimpleChild) {
TestMultiprocessExec exec; TestMultiprocessExec exec;
exec.SetChildTestMainFunction("SimpleMultiprocess"); exec.SetChildTestMainFunction("SimpleMultiprocess");
exec.Run(); exec.Run();
}; }
CRASHPAD_CHILD_TEST_MAIN(SimpleMultiprocessReturnsNonZero) { CRASHPAD_CHILD_TEST_MAIN(SimpleMultiprocessReturnsNonZero) {
return 123; return 123;
@ -96,7 +95,7 @@ TEST(MultiprocessExec, MultiprocessExecSimpleChildReturnsNonZero) {
exec.SetExpectedChildTermination( exec.SetExpectedChildTermination(
Multiprocess::TerminationReason::kTerminationNormal, 123); Multiprocess::TerminationReason::kTerminationNormal, 123);
exec.Run(); exec.Run();
}; }
#if !defined(OS_WIN) #if !defined(OS_WIN)

View File

@ -210,7 +210,7 @@ ParseResult ParseMapsLine(DelimitedFileReader* maps_file_reader,
class SparseReverseIterator : public MemoryMap::Iterator { class SparseReverseIterator : public MemoryMap::Iterator {
public: public:
SparseReverseIterator(const std::vector<const MemoryMap::Mapping*>& mappings) SparseReverseIterator(const std::vector<const MemoryMap::Mapping*>& mappings)
: mappings_(mappings), riter_(mappings_.rbegin()){}; : mappings_(mappings), riter_(mappings_.rbegin()) {}
SparseReverseIterator() : mappings_(), riter_(mappings_.rend()) {} SparseReverseIterator() : mappings_(), riter_(mappings_.rend()) {}

View File

@ -32,10 +32,10 @@ namespace {
bool ConvertStringToNumber(const base::StringPiece& input, type* value) { \ bool ConvertStringToNumber(const base::StringPiece& input, type* value) { \
return function(input, value); \ return function(input, value); \
} }
MAKE_ADAPTER(int, base::StringToInt); MAKE_ADAPTER(int, base::StringToInt)
MAKE_ADAPTER(unsigned int, base::StringToUint); MAKE_ADAPTER(unsigned int, base::StringToUint)
MAKE_ADAPTER(int64_t, base::StringToInt64); MAKE_ADAPTER(int64_t, base::StringToInt64)
MAKE_ADAPTER(uint64_t, base::StringToUint64); MAKE_ADAPTER(uint64_t, base::StringToUint64)
#undef MAKE_ADAPTER #undef MAKE_ADAPTER
} // namespace } // namespace