From f9b3a18f3f44a775689f42d5aec77fe97bc79108 Mon Sep 17 00:00:00 2001 From: Scott Graham Date: Thu, 5 Jan 2017 13:44:55 -0800 Subject: [PATCH] Use DEPS hooks to get gn binaries from buildtools Otherwise: [2d68949...]D:\src\crashpad\crashpad>gn gen out\Debug gn.py: Could not find gn executable at: D:\src\crashpad\buildtools\win\gn.exe I have no idea why these binaries aren't just checked into buildtools, but anyway. BUG=crashpad:79 Change-Id: If2f21a7e7f795910809de7d3595ab6a5ffee9dc7 Reviewed-on: https://chromium-review.googlesource.com/424847 Reviewed-by: Mark Mentovai --- DEPS | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/DEPS b/DEPS index 520a7624..77428536 100644 --- a/DEPS +++ b/DEPS @@ -51,7 +51,6 @@ hooks = [ '--no_resume', '--no_auth', '--bucket=chromium-clang-format', - '--output=buildtools/mac/clang-format', '--sha1_file', 'buildtools/mac/clang-format.sha1', ], @@ -65,11 +64,36 @@ hooks = [ '--no_resume', '--no_auth', '--bucket=chromium-clang-format', - '--output=buildtools/win/clang-format.exe', '--sha1_file', 'buildtools/win/clang-format.exe.sha1', ], }, + { + 'name': 'gn_mac', + 'pattern': '.', + 'action': [ + 'download_from_google_storage', + '--platform=^darwin$', + '--no_resume', + '--no_auth', + '--bucket=chromium-gn', + '--sha1_file', + 'buildtools/mac/gn.sha1', + ], + }, + { + 'name': 'gn_win', + 'pattern': '.', + 'action': [ + 'download_from_google_storage', + '--platform=^win32$', + '--no_resume', + '--no_auth', + '--bucket=chromium-gn', + '--sha1_file', + 'buildtools/win/gn.exe.sha1', + ], + }, { 'name': 'gyp', 'pattern': '\.gypi?$',