3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix build failure on Linux/amd64

Browse Source 
This is necessary to roll Crashpad in Chromium.  Fixes the following:

[5984/6587] CXX obj/third_party/crashpad/crashpad/client/client_test/crashpad_client_linux_test.o
FAILED: obj/third_party/crashpad/crashpad/client/client_test/crashpad_client_linux_test.o
python3 ../../build/toolchain/clang_code_coverage_wrapper.py --target-os=linux --files-to-instrument...(too long)
../../third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc:522:20: error: code will never be executed [-Werror,-Wunreachable-code]
struct utsname uname_info;
^~~~~~~~~~
1 error generated.

Bug: chromium:1260217
Change-Id: Ie63881ed82faec84e8d45bb30dfc8ef10cfdbd6d
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4028794
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
This commit is contained in:
Tom Anderson 2022-11-16 00:07:44 +00:00 committed by Crashpad LUCI CQ
parent fca8871ca3
commit f742c1aa4a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/crashpad_client_linux_test.cc
View File

@ -517,8 +517,7 @@ TEST_P(StartHandlerForSelfTest, StartHandlerInChild) {
if (Options().crash_type == CrashType::kSegvWithTagBits) {
#if !defined(ARCH_CPU_ARM64)
GTEST_SKIP() << "Testing for tag bits only exists on aarch64.";
#endif // !defined(ARCH_CPU_ARM64)
#else
struct utsname uname_info;
ASSERT_EQ(uname(&uname_info), 0);
ASSERT_NE(uname_info.release, nullptr);
@ -532,6 +531,7 @@ TEST_P(StartHandlerForSelfTest, StartHandlerInChild) {
GTEST_SKIP() << "Linux kernel v" << uname_info.release
<< " does not support SA_EXPOSE_TAGBITS";
}
#endif // !defined(ARCH_CPU_ARM64)
}
StartHandlerForSelfInChildTest test(Options());