3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-27 15:32:10 +08:00
Code Issues Projects Releases Wiki Activity

doc: Document the try server and commit queue

Browse Source 
Bug: crashpad:162
Change-Id: I9b5dd8c281117c24d79ce6b81269c87d42a21e13
Reviewed-on: https://chromium-review.googlesource.com/452438
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Mark Mentovai 2017-03-09 12:25:24 -05:00 committed by Commit Bot
parent a47a512ea6
commit f590383096
1 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
doc/developing.md
View File

@ -278,10 +278,25 @@ committing your changes locally with `git commit`. You can then upload a new
patch set with `git cl upload` and let your reviewer know you’ve addressed the patch set with `git cl upload` and let your reviewer know you’ve addressed the
feedback. feedback.
The most recently uploaded patch set on a review may be tested on a [try
server](https://dev.chromium.org/developers/testing/try-server-usage) by running
`git cl try` or by clicking the “CQ Dry Run” button in Gerrit. These set the
“Commit-Queue: +1” label. This does not mean that the patch will be committed,
but the try server and commit queue share infrastructure and a Gerrit label. The
patch will be tested on try bots in a variety of configurations. Status
information will be available on Gerrit.
### Landing Changes ### Landing Changes
After code review is complete and “Code-Review: +1” has been received from all After code review is complete and “Code-Review: +1” has been received from all
reviewers, project members can commit the patch themselves: reviewers, the patch can be submitted to Crashpad’s [commit
queue](https://dev.chromium.org/developers/testing/commit-queue) by clicking the
“Submit to CQ” button in Gerrit. This sets the “Commit-Queue: +2” label, which
tests the patch on the try server before landing it.
Although the commit queue is recommended, if needed, project members can bypass
the commit queue and land patches without testing by using the “Submit” button
in Gerrit or by committing via `git cl land`:
``` ```
$ cd ~/crashpad/crashpad $ cd ~/crashpad/crashpad
@ -289,15 +304,6 @@ $ git checkout work_branch
$ git cl land $ git cl land
``` ```
Alternatively, patches can be committed by clicking the “Submit” button in the
Gerrit UI.
Crashpad does not currently have a [commit
queue](https://dev.chromium.org/developers/testing/commit-queue), so
contributors who are not project members will have to ask a project member to
commit the patch for them. Project members can commit changes on behalf of
external contributors by clicking the “Submit” button in the Gerrit UI.
### External Contributions ### External Contributions
Copyright holders must complete the [Individual Contributor License Copyright holders must complete the [Individual Contributor License