3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-19 18:03:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace Rietveld with Gerrit in the developer documentation

Browse Source 
Also, update a few links for good measure.

Change-Id: I47113a4f324e4ad6ba02aa46bae821eefd4d98ea
Reviewed-on: https://chromium-review.googlesource.com/406347
Reviewed-by: Robert Sesek <rsesek@chromium.org>
This commit is contained in:
Mark Mentovai 2016-11-01 14:55:40 -04:00
parent e7bd798af4
commit e616638c9d
1 changed files with 28 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
doc/developing.ad
View File

@ -38,7 +38,7 @@ present in the `$PATH` environment variable:
* Chromium’s * Chromium’s
https://dev.chromium.org/developers/how-tos/depottools[depot_tools]. https://dev.chromium.org/developers/how-tos/depottools[depot_tools].
* http://git-scm.com/[Git]. This is provided by Xcode on Mac OS X and by * https://git-scm.com/[Git]. This is provided by Xcode on Mac OS X and by
depot_tools on Windows. depot_tools on Windows.
* https://www.python.org/[Python]. This is provided by the operating system on * https://www.python.org/[Python]. This is provided by the operating system on
Mac OS X, and by depot_tools on Windows. Mac OS X, and by depot_tools on Windows.
@ -69,8 +69,8 @@ $ *cd ~/crashpad*
$ *fetch crashpad* $ *fetch crashpad*
---- ----
`fetch crashpad` performs the initial `gclient sync`, establishing a `fetch crashpad` performs the initial `git clone` and `gclient sync`,
fully-functional local checkout. establishing a fully-functional local checkout.
=== Subsequent Checkouts === Subsequent Checkouts
@ -84,10 +84,10 @@ $ *gclient sync*
== Building == Building
Crashpad uses https://gyp.gsrc.io/[GYP] to generate Crashpad uses https://gyp.gsrc.io/[GYP] to generate
https://martine.github.io/ninja/[Ninja] build files. The build is described by https://ninja-build.org/[Ninja] build files. The build is described by `.gyp`
`.gyp` files throughout the Crashpad source code tree. The files throughout the Crashpad source code tree. The `build/gyp_crashpad.py`
`build/gyp_crashpad.py` script runs GYP properly for Crashpad, and is also script runs GYP properly for Crashpad, and is also called when you run `fetch
called when you run `fetch crashpad`, `gclient sync`, or `gclient runhooks`. crashpad`, `gclient sync`, or `gclient runhooks`.
The Ninja build files and build output are in the `out` directory. Both debug- The Ninja build files and build output are in the `out` directory. Both debug-
and release-mode configurations are available. The examples below show the debug and release-mode configurations are available. The examples below show the debug
@ -246,9 +246,9 @@ process].
=== Code Review === Code Review
A code review must be conducted for every change to Crashpad’s source code. Code A code review must be conducted for every change to Crashpad’s source code. Code
review is conducted on https://codereview.chromium.org/[Chromium’s Rietveld] review is conducted on https://chromium-review.googlesource.com/[Chromium’s
system, and all code reviews must be sent to an appropriate reviewer, with a Cc Gerrit] system, and all code reviews must be sent to an appropriate reviewer,
sent to with a Cc sent to
https://groups.google.com/a/chromium.org/group/crashpad-dev[crashpad-dev]. The https://groups.google.com/a/chromium.org/group/crashpad-dev[crashpad-dev]. The
`codereview.settings` file specifies this environment to `git-cl`. `codereview.settings` file specifies this environment to `git-cl`.
@ -266,14 +266,18 @@ $ *git commit*
$ *git cl upload* $ *git cl upload*
---- ----
Uploading a patch to Rietveld does not automatically request a review. You must The https://polygerrit.appspot.com/[PolyGerrit interface] to Gerrit, undergoing
select a reviewer and mail your request to them (with a Cc to crashpad-dev) from active development, is recommended. To switch from the classic GWT-based Gerrit
the Rietveld issue page after running `git cl upload`. If you have lost track of UI to PolyGerrit, click the PolyGerrit link in a Gerrit review page’s footer.
the issue page, `git cl issue` will remind you of its URL. Alternatively, you
can request review when uploading to Rietveld by using `git cl upload
--send-mail`
Git branches maintain their association with Rietveld issues, so if you need to Uploading a patch to Gerrit does not automatically request a review. You must
select a reviewer on the Gerrit review page after running `git cl upload`. This
action notifies your reviewer of the code review request. If you have lost track
of the review page, `git cl issue` will remind you of its URL. Alternatively,
you can request review when uploading to Gerrit by using `git cl upload
--send-mail`.
Git branches maintain their association with Gerrit reviews, so if you need to
make changes based on review feedback, you can do so on the correct Git branch, make changes based on review feedback, you can do so on the correct Git branch,
committing your changes locally with `git commit`. You can then upload a new committing your changes locally with `git commit`. You can then upload a new
patch set with `git cl upload` and let your reviewer know you’ve addressed the patch set with `git cl upload` and let your reviewer know you’ve addressed the
@ -281,8 +285,8 @@ feedback.
=== Landing Changes === Landing Changes
After code review is complete and “LGTM” (“looks good to me”) has been received After code review is complete and “Code-Review: +1”) has been received from all
from all reviewers, project members can commit the patch themselves: reviewers, project members can commit the patch themselves:
[subs="verbatim,quotes"] [subs="verbatim,quotes"]
---- ----
@ -291,19 +295,14 @@ $ *git checkout work_branch*
$ *git cl land* $ *git cl land*
---- ----
Alternatively, patches can be committed by clicking the “Submit” button in the
Gerrit UI.
Crashpad does not currently have a Crashpad does not currently have a
https://dev.chromium.org/developers/testing/commit-queue[commit queue], so https://dev.chromium.org/developers/testing/commit-queue[commit queue], so
contributors that are not project members will have to ask a project member to contributors who are not project members will have to ask a project member to
commit the patch for them. Project members can commit changes on behalf of commit the patch for them. Project members can commit changes on behalf of
external contributors by patching the change into a local branch and landing it: external contributors by clicking the “Submit” button in the Gerrit UI.
[subs="verbatim,quotes"]
----
$ *cd ~/crashpad/crashpad*
$ *git checkout -b for_external_contributor origin/master*
$ *git cl patch 12345678* _# 12345678 is the Rietveld issue number_
$ *git cl land -c \'External Contributor <external@contributor.org>'*
----
=== External Contributions === External Contributions