From e0a79bec5e1a8b5e7f700b09164156e1fc44f8de Mon Sep 17 00:00:00 2001 From: Mark Mentovai Date: Wed, 13 Aug 2014 15:27:33 -0700 Subject: [PATCH] =?UTF-8?q?MinidumpMemoryWriter=20test:=20Don=E2=80=99t=20?= =?UTF-8?q?suffix=20uint64=5Ft=20constants.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It’s not necessary. TEST=minidump_test MinidumpMemoryWriter R=rsesek@chromium.org Review URL: https://codereview.chromium.org/467323003 --- minidump/minidump_memory_writer_test.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/minidump/minidump_memory_writer_test.cc b/minidump/minidump_memory_writer_test.cc index f275d8ad..3e469874 100644 --- a/minidump/minidump_memory_writer_test.cc +++ b/minidump/minidump_memory_writer_test.cc @@ -187,7 +187,7 @@ TEST(MinidumpMemoryWriter, OneMemoryRegion) { MinidumpFileWriter minidump_file_writer; MinidumpMemoryListWriter memory_list_writer; - const uint64_t kBaseAddress = 0xfedcba9876543210ull; + const uint64_t kBaseAddress = 0xfedcba9876543210; const uint64_t kSize = 0x1000; const uint8_t kValue = 'm'; @@ -223,10 +223,10 @@ TEST(MinidumpMemoryWriter, TwoMemoryRegions) { MinidumpFileWriter minidump_file_writer; MinidumpMemoryListWriter memory_list_writer; - const uint64_t kBaseAddress1 = 0x00c0ffeeull; + const uint64_t kBaseAddress1 = 0xc0ffee; const uint64_t kSize1 = 0x0100; const uint8_t kValue1 = '6'; - const uint64_t kBaseAddress2 = 0xfac00facull; + const uint64_t kBaseAddress2 = 0xfac00fac; const uint64_t kSize2 = 0x0200; const uint8_t kValue2 = '!'; @@ -325,7 +325,7 @@ TEST(MinidumpMemoryWriter, ExtraMemory) { // memory writer a child of the memory list writer. MinidumpFileWriter minidump_file_writer; - const uint64_t kBaseAddress1 = 0x0000000000001000ull; + const uint64_t kBaseAddress1 = 0x1000; const uint64_t kSize1 = 0x0400; const uint8_t kValue1 = '1'; TestMemoryStream test_memory_stream(kBaseAddress1, kSize1, kValue1); @@ -335,7 +335,7 @@ TEST(MinidumpMemoryWriter, ExtraMemory) { minidump_file_writer.AddStream(&test_memory_stream); - const uint64_t kBaseAddress2 = 0x0000000000002000ull; + const uint64_t kBaseAddress2 = 0x2000; const uint64_t kSize2 = 0x0400; const uint8_t kValue2 = 'm';