From dec23bef576966dc03f60179d39cc32d5414ddfb Mon Sep 17 00:00:00 2001 From: Joshua Peraza Date: Tue, 27 Feb 2018 15:29:38 -0800 Subject: [PATCH] win gn: reintroduce flags to disable warnings These flags were moved to mini_chromium's build/BUILD.gn, but that configuration is not present when building in chromium. Change-Id: I0d03c7461869882cf2ee7544ecd3d100eb189160 Reviewed-on: https://chromium-review.googlesource.com/940436 Reviewed-by: Scott Graham Reviewed-by: Mark Mentovai Commit-Queue: Joshua Peraza --- handler/BUILD.gn | 2 ++ util/BUILD.gn | 2 ++ 2 files changed, 4 insertions(+) diff --git a/handler/BUILD.gn b/handler/BUILD.gn index c817393b..b3370fca 100644 --- a/handler/BUILD.gn +++ b/handler/BUILD.gn @@ -241,6 +241,8 @@ if (crashpad_is_win) { "win/crashy_signal.cc", ] + cflags = [ "/wd4702" ] # Unreachable code. + deps = [ "../client", "../third_party/mini_chromium:base", diff --git a/util/BUILD.gn b/util/BUILD.gn index 3bf59081..bb3a9e48 100644 --- a/util/BUILD.gn +++ b/util/BUILD.gn @@ -430,6 +430,8 @@ static_library("util") { "winhttp.lib", ] + cflags = [ "/wd4201" ] # nonstandard extension used: nameless struct/union. + if (current_cpu == "x86") { asmflags = [ "/safeseh" ] }