Fix Chromium Roll.

- Fix -Wundeclared-selector in Chromium roll.
- Convert TEST to TEST_F in crashpad_client_ios_test.mm

Also rolls mini_chromim 731e08f06..641fcf9bb (3 commits)
  2020-04-14 mark Mark static const class/struct members as constexpr
  2020-04-09 justincohen Add PlatformTest to mini_chromium.
  2020-04-09 jperaza Replace ScopedClearErrno with ScopedClearLastError

Change-Id: Ib8ac742eb97359be47e1ff01ae6f10518761a302
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2144452
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Justin Cohen 2020-04-14 10:13:14 -04:00 committed by Commit Bot
parent e5dbfa3363
commit de43cd3723
3 changed files with 12 additions and 5 deletions

2
DEPS
View File

@ -42,7 +42,7 @@ deps = {
'7bde79cc274d06451bf65ae82c012a5d3e476b5a',
'crashpad/third_party/mini_chromium/mini_chromium':
Var('chromium_git') + '/chromium/mini_chromium@' +
'bbf1307928bb7a9d1eda6be576283c8093b2775b',
'641fcf9bbc1277e8153ac7e86d5b8f9340b1bfdd',
'crashpad/third_party/libfuzzer/src':
Var('chromium_git') + '/chromium/llvm-project/compiler-rt/lib/fuzzer.git@' +
'fda403cf93ecb8792cb1d061564d89a6553ca020',

View File

@ -15,16 +15,20 @@
#include "client/crashpad_client.h"
#import <Foundation/Foundation.h>
#include <vector>
#include "gtest/gtest.h"
#include "testing/platform_test.h"
namespace crashpad {
namespace test {
namespace {
using CrashpadIOSClient = PlatformTest;
// TODO(justincohen): This is a placeholder.
TEST(CrashpadIOSClient, DumpWithoutCrash) {
TEST_F(CrashpadIOSClient, DumpWithoutCrash) {
CrashpadClient client;
client.StartCrashpadInProcessHandler();
client.DumpWithoutCrash();
@ -34,7 +38,7 @@ TEST(CrashpadIOSClient, DumpWithoutCrash) {
// it's sometimes easier and faster to run as a gtest. However, there's no
// way to correctly run this as a gtest. Leave the test here, disabled, for use
// during development only.
TEST(CrashpadIOSClient, DISABLED_ThrowNSException) {
TEST_F(CrashpadIOSClient, DISABLED_ThrowNSException) {
CrashpadClient client;
client.StartCrashpadInProcessHandler();
[NSException raise:@"GtestNSException" format:@"ThrowException"];
@ -44,10 +48,10 @@ TEST(CrashpadIOSClient, DISABLED_ThrowNSException) {
// it's sometimes easier and faster to run as a gtest. However, there's no
// way to correctly run this as a gtest. Leave the test here, disabled, for use
// during development only.
TEST(CrashpadIOSClient, DISABLED_ThrowException) {
TEST_F(CrashpadIOSClient, DISABLED_ThrowException) {
CrashpadClient client;
client.StartCrashpadInProcessHandler();
std::vector<int> empty_vector = {};
std::vector<int> empty_vector;
empty_vector.at(42);
}

View File

@ -102,7 +102,10 @@
}
- (void)crashUnreocgnizedSelectorAfterDelay {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wundeclared-selector"
[self performSelector:@selector(does_not_exist) withObject:nil afterDelay:1];
#pragma clang diagnostic pop
}
- (void)recurse {