3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove a NOTREACHED() after a __builtin_trap()

Browse Source 
__builtin_trap() is already noreturn, so no need to put a
NOTREACHED() after it.

No behavior change.

Bug: chromium:393924694
Change-Id: Ib93b429d8ef7cfe8fb59c4b9e9b8afced06b2ac2
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6298671
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Nico Weber 2025-02-24 11:54:07 -05:00 committed by Crashpad LUCI CQ
parent 85ecbd2a77
commit db25cdc030
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
client/crashpad_client_linux_test.cc
View File

@ -24,7 +24,6 @@
#include <unistd.h> #include <unistd.h>
#include "base/check_op.h" #include "base/check_op.h"
#include "base/notreached.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "client/annotation.h" #include "client/annotation.h"
#include "client/annotation_list.h" #include "client/annotation_list.h"
@ -764,8 +763,6 @@ class StartHandlerForChildTest : public Multiprocess {
CHECK(test_state_.InstallHandler()); CHECK(test_state_.InstallHandler());
__builtin_trap(); __builtin_trap();
NOTREACHED();
} }
StartHandlerForClientTest test_state_; StartHandlerForClientTest test_state_;