From d4c3de1afa52c3f9aa19c603929d6f896788fd2a Mon Sep 17 00:00:00 2001 From: Justin Cohen Date: Thu, 25 Mar 2021 09:10:26 -0400 Subject: [PATCH] Fix some spacing and typos in ios documentation. Change-Id: I401c597c3c81c257d25e9e8a5e542521f52142dd Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2785784 Reviewed-by: Mark Mentovai Commit-Queue: Justin Cohen --- doc/ios_overview_design.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/ios_overview_design.md b/doc/ios_overview_design.md index be23d09a..943d7a5d 100644 --- a/doc/ios_overview_design.md +++ b/doc/ios_overview_design.md @@ -47,7 +47,7 @@ In conjunction with Crashpad’s existing minidump writer and structural limitations of the minidump format, it is not possible to write a minidump immediately from the crash handler. Instead, an intermediate dump is written when a handler would normally write a minidump (such as during an exception or a -forced dump without crashing). The intermediate dump file will be converted to +forced dump without crashing). The intermediate dump file will be converted to a minidump on the next run (or when the application decides it's safe to do so). During Crashpad initialization, the handler gathers basic system information @@ -76,7 +76,7 @@ On iOS, everything must happen in-process. Once started, the client will automatically handle exceptions and capture the crashed process state in an intermediate dump file. Converting that intermediate dump file into a minidump is likely not safe to do from within a crashed process, and uploading a minidump -is definitely unsafe to do at crash time. Applications are expected to process +is definitely unsafe to do at crash time. Applications are expected to process intermediate dumps into pending minidumps and begin processing pending minidumps, possibly for upload, at suitable times following the next application restart. @@ -90,15 +90,15 @@ suitable. After converting, a minidump will be written to the Crashpad database, similar to how other platforms write a minidump on exception handling. If uploading is enabled, this minidump will also be immediately uploaded. New intermediate dumps generated by exceptions or by -`CRASHPAD_SIMULATE_CRASH_AND_DEFER_PROCESSING` will will not be processed until +`CRASHPAD_SIMULATE_CRASH_AND_DEFER_PROCESSING` will not be processed until the next call to `ProcessIntermediateDumps`. Conversely, `CRASHPAD_SIMULATE_CRASH` can be called when the client has no performance or -stability concerns. In this case, intermediate dumps are automatically -converted to minidumps and immediately eligable for uploading. +stability concerns. In this case, intermediate dumps are automatically +converted to minidumps and immediately eligible for uploading. ### `StartProcesingPendingReports` For similar reasons, applications may choose the correct time to begin uploading -pending reports, such as when ideal network conditions exist. By default, -clients start with uploading disabled. Applications should call this API when +pending reports, such as when ideal network conditions exist. By default, +clients start with uploading disabled. Applications should call this API when it is determined that it is appropriate to do so (such as on a few seconds after startup, or when network connectivity is appropriate).