3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

win xp: Don't use ICU_REJECT_USERPWD with WinHttpCrackUrl

Browse Source 
Fails on XP with ERROR_INVALID_PARAMETER (undocumented). Not overly
important that we reject embedded user/passwords in the URL for this
use case.

R=mark@chromium.org
BUG=crashpad:50

Review URL: https://codereview.chromium.org/1339793002 .
This commit is contained in:
Scott Graham 2015-09-11 13:23:59 -07:00
parent 3a886267aa
commit ccf9f98519
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/net/http_transport_win.cc
View File

@ -114,8 +114,10 @@ bool HTTPTransportWin::ExecuteSynchronously(std::string* response_body) {
url_components.dwUrlPathLength = 1;
url_components.dwExtraInfoLength = 1;
std::wstring url_wide(base::UTF8ToUTF16(url()));
// dwFlags = ICU_REJECT_USERPWD fails on XP. See "Community Additions" at:
// https://msdn.microsoft.com/en-us/library/aa384092.aspx
if (!WinHttpCrackUrl(
url_wide.c_str(), 0, ICU_REJECT_USERPWD, &url_components)) {
url_wide.c_str(), 0, 0, &url_components)) {
LogErrorWinHttpMessage("WinHttpCrackUrl");
return false;
}