3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-26 06:31:50 +08:00
Code Issues Projects Releases Wiki Activity

ios: Update exception test for Chromium release builds.

Browse Source 
After https://crrev.com/c/5375084, Chromium __libcpp_verbose_abort is
handled differently for official non-dcheck builds. This change fixes
the test expectation for release non-official builds.

Bug: 330168249
Change-Id: Iceb6d327f9e93fd366cc07abe27eefd1adf06472
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5378380
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
This commit is contained in:
Justin Cohen 2024-03-18 12:47:58 -04:00 committed by Crashpad LUCI CQ
parent 6bf5e1b5c5
commit ccd20652bc
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/ios/crash_type_xctest.mm
View File

@ -177,7 +177,10 @@ bool IsMacOSVersion143OrGreaterAndiOS16OrLess() {
[rootObject_ crashException];
// After https://reviews.llvm.org/D141222 exceptions call
// __libcpp_verbose_abort, which Chromium sets to `brk 0` in release.
#if defined(CRASHPAD_IS_IN_CHROMIUM) && defined(NDEBUG)
// After https://crrev.com/c/5375084, Chromium does not set `brk 0` for local
// release builds and official DCHECK builds.
#if defined(CRASHPAD_IS_IN_CHROMIUM) && defined(NDEBUG) && \
defined(OFFICIAL_BUILD) && !defined(DCHECK_ALWAYS_ON)
[self verifyCrashReportException:SIGABRT];
#else
[self verifyCrashReportException:EXC_SOFT_SIGNAL];