From cc0b7deef27d8e56b1fb7b871e66af89991d711d Mon Sep 17 00:00:00 2001 From: Scott Graham Date: Fri, 21 Oct 2016 16:11:52 -0700 Subject: [PATCH] Get VS2013 compilation working again for Crashpad Follow up #1 to https://chromium-review.googlesource.com/c/400015/, still pending further discussion on details of registration. R=mark@chromium.org BUG=chromium:567850,chromium:656800 Change-Id: Idfee3a3241d7cfe418fbf9e40f17f35e5dbefac9 Reviewed-on: https://chromium-review.googlesource.com/401182 Reviewed-by: Mark Mentovai --- util/win/initial_client_data.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/util/win/initial_client_data.h b/util/win/initial_client_data.h index f686959e..37f0964a 100644 --- a/util/win/initial_client_data.h +++ b/util/win/initial_client_data.h @@ -108,7 +108,13 @@ class InitialClientData { HANDLE client_process_; bool is_valid_; +#if _MSC_VER < 1900 + // The default copy and assignment constructors are fine, as we don't take + // ownership of the handles. They also shouldn't be required for how we use + // this class, however, VS2013 seems to think they are. +#else DISALLOW_COPY_AND_ASSIGN(InitialClientData); +#endif // _MSC_VER < 1900 }; } // namespace crashpad