diff --git a/client/crashpad_client_linux.cc b/client/crashpad_client_linux.cc index 74f15403..00a83fa0 100644 --- a/client/crashpad_client_linux.cc +++ b/client/crashpad_client_linux.cc @@ -58,24 +58,31 @@ std::vector BuildAppProcessArgs( const std::map& annotations, const std::vector& arguments, int socket) { - std::vector argv; #if defined(ARCH_CPU_64_BITS) - argv.push_back("/system/bin/app_process64"); + static constexpr char kAppProcess[] = "/system/bin/app_process64"; #else - argv.push_back("/system/bin/app_process32"); + static constexpr char kAppProcess[] = "/system/bin/app_process32"; #endif + + std::vector argv; + argv.push_back(kAppProcess); argv.push_back("/system/bin"); argv.push_back("--application"); argv.push_back(class_name); - std::vector handler_argv = BuildHandlerArgvStrings( - base::FilePath(), database, metrics_dir, url, annotations, arguments); + std::vector handler_argv = + BuildHandlerArgvStrings(base::FilePath(kAppProcess), + database, + metrics_dir, + url, + annotations, + arguments); if (socket != kInvalidFileHandle) { handler_argv.push_back(FormatArgumentInt("initial-client-fd", socket)); } - argv.insert(argv.end(), handler_argv.begin() + 1, handler_argv.end()); + argv.insert(argv.end(), handler_argv.begin(), handler_argv.end()); return argv; }