From c6d912dac10862f60fbf48e4a4e49cb4caf391e5 Mon Sep 17 00:00:00 2001 From: Chris Davis Date: Tue, 14 Jan 2025 13:03:11 -0800 Subject: [PATCH] Add STARTF_FORCEOFFFEEDBACK to prevent busy cursor on process launch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When starting or restarting Chromium on Windows, we see the busy cursor briefly. This is because crashpad does not specify STARTF_FORCEOFFFEEDBACK in the CreateProcess call. This is similar to other changes in Chromium for child processes to avoid the busy cursor. Bug: 389978731 Change-Id: Ib95cd3b6ce13e3170324e63b43e46a376affc7c8 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6173930 Reviewed-by: Will Harris Commit-Queue: Chris Davis Reviewed-by: Peter Boström Reviewed-by: Mark Mentovai Reviewed-by: Will Harris --- client/crashpad_client_win.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/client/crashpad_client_win.cc b/client/crashpad_client_win.cc index c10df2b0..93cc406e 100644 --- a/client/crashpad_client_win.cc +++ b/client/crashpad_client_win.cc @@ -438,7 +438,8 @@ bool StartHandlerProcess( BOOL rv; DWORD creation_flags; STARTUPINFOEX startup_info = {}; - startup_info.StartupInfo.dwFlags = STARTF_USESTDHANDLES; + startup_info.StartupInfo.dwFlags = + STARTF_USESTDHANDLES | STARTF_FORCEOFFFEEDBACK; startup_info.StartupInfo.hStdInput = GetStdHandle(STD_INPUT_HANDLE); startup_info.StartupInfo.hStdOutput = GetStdHandle(STD_OUTPUT_HANDLE); startup_info.StartupInfo.hStdError = GetStdHandle(STD_ERROR_HANDLE);