3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

[fuchsia][arm64][snapshot] remove NOTREACHEDs

Browse Source 
we now run this code on arm64 devices in debug mode

Bug: crashpad:196
Bug: fuchsia:DX-712
Change-Id: Iea1975c5bd4cab3d503ca371ab731e25962fb255
Tested: /system/test/crashpad_tests on arm64 device in debug mode
Reviewed-on: https://chromium-review.googlesource.com/c/1352097
Commit-Queue: Francois Rousseau <frousseau@google.com>
Reviewed-by: Scott Graham <scottmg@chromium.org>
This commit is contained in:
Francois Rousseau 2018-11-27 10:46:33 -08:00 committed by Commit Bot
parent 3ca0713430
commit c56557ae4a
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
snapshot/fuchsia/system_snapshot_fuchsia.cc
View File

@ -73,7 +73,7 @@ uint32_t SystemSnapshotFuchsia::CPURevision() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.Revision();
#else
NOTREACHED(); // TODO(scottmg): https://crashpad.chromium.org/bug/196.
// TODO(fuchsia/DX-712): Read actual revision.
return 0;
#endif
}
@ -88,7 +88,7 @@ std::string SystemSnapshotFuchsia::CPUVendor() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.Vendor();
#else
NOTREACHED(); // TODO(scottmg): https://crashpad.chromium.org/bug/196.
// TODO(fuchsia/DX-712): Read actual vendor.
return std::string();
#endif
}
@ -106,7 +106,7 @@ uint32_t SystemSnapshotFuchsia::CPUX86Signature() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.Signature();
#else
NOTREACHED(); // TODO(scottmg): https://crashpad.chromium.org/bug/196.
NOTREACHED();
return 0;
#endif
}
@ -116,7 +116,7 @@ uint64_t SystemSnapshotFuchsia::CPUX86Features() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.Features();
#else
NOTREACHED(); // TODO(scottmg): https://crashpad.chromium.org/bug/196.
NOTREACHED();
return 0;
#endif
}
@ -126,7 +126,7 @@ uint64_t SystemSnapshotFuchsia::CPUX86ExtendedFeatures() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.ExtendedFeatures();
#else
NOTREACHED(); // TODO(scottmg): https://crashpad.chromium.org/bug/196.
NOTREACHED();
return 0;
#endif
}
@ -135,7 +135,7 @@ uint32_t SystemSnapshotFuchsia::CPUX86Leaf7Features() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.Leaf7Features();
#else
NOTREACHED(); // TODO(scottmg): https://crashpad.chromium.org/bug/196.
NOTREACHED();
return 0;
#endif
}
@ -145,7 +145,7 @@ bool SystemSnapshotFuchsia::CPUX86SupportsDAZ() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.SupportsDAZ();
#else
NOTREACHED(); // TODO(scottmg): https://crashpad.chromium.org/bug/196.
NOTREACHED();
return false;
#endif
}
@ -191,7 +191,7 @@ bool SystemSnapshotFuchsia::NXEnabled() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.NXEnabled();
#else
NOTREACHED(); // TODO(scottmg): https://crashpad.chromium.org/bug/196.
// TODO(fuchsia/DX-712): Read actual NX bit value.
return false;
#endif
}