mac: Provide a larger thread state buffer for AVX-512 on 10.13

Crashpad doesn’t use AVX-512, but when receiving replies to exceptions
forwarded to ReportCrash, may see buffers large enough to contain
AVX-512 thread state. This can result in messages like
“UniversalExceptionRaise: (ipc/rcv) msg too large (0x10004004)”.

I386_THREAD_STATE_MAX has increased from 224 to 614 in the 10.13 SDK,
meaning that the maximum supported size for old_state and new_state in
[mach_]exception_raise_state[_identity]() has increased from 896 to
2,456 bytes. This constant defines the size of the buffer that these
MIG-generated routines will work with. By providing this definition in
compat, the buffer size is increased when building with older SDKs.

Note that on the “send” side, the size of the message given to
mach_msg() will be trimmed to include only the valid part of the state
area based on the stateCnt field, so increasing the value to 614 here
won’t result Crashpad sending messages this large. That would be a
potential interoperability concern with older OS versions.

Bug: crashpad:185, crashpad:190
Change-Id: Ia46091ae46fd6227a17f59eb4bc00914be471aa7
Reviewed-on: https://chromium-review.googlesource.com/541515
Reviewed-by: Robert Sesek <rsesek@chromium.org>

compat/compat.gyp

@@ -23,6 +23,7 @@
       'sources': [
         'mac/AvailabilityMacros.h',
         'mac/kern/exc_resource.h',
+        'mac/mach/i386/thread_state.h',
         'mac/mach/mach.h',
         'mac/mach-o/getsect.cc',
         'mac/mach-o/getsect.h',

compat/mac/mach/i386/thread_state.h

@@ -0,0 +1,28 @@
+// Copyright 2017 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef CRASHPAD_COMPAT_MAC_MACH_I386_THREAD_STATE_H_
+#define CRASHPAD_COMPAT_MAC_MACH_I386_THREAD_STATE_H_
+
+#include_next <mach/i386/thread_state.h>
+
+// 10.13 SDK
+//
+// This was defined as 244 in the 10.7 through 10.12 SDKs, and 144 previously.
+#if I386_THREAD_STATE_MAX < 614
+#undef I386_THREAD_STATE_MAX
+#define I386_THREAD_STATE_MAX (614)
+#endif
+
+#endif  // CRASHPAD_COMPAT_MAC_MACH_I386_THREAD_STATE_H_

compat/mac/mach/mach.h

@@ -93,6 +93,20 @@
 #define x86_AVX_STATE 18
 #endif
 
+// 10.13 SDK
+
+#ifndef x86_AVX512_STATE32
+#define x86_AVX512_STATE32 19
+#endif
+
+#ifndef x86_AVX512_STATE64
+#define x86_AVX512_STATE64 20
+#endif
+
+#ifndef x86_AVX512_STATE
+#define x86_AVX512_STATE 21
+#endif
+
 #endif  // defined(__i386__) || defined(__x86_64__)
 
 // <mach/thread_status.h>

util/mach/mig.py

@@ -111,6 +111,10 @@ def main(args):
   parser = argparse.ArgumentParser()
   parser.add_argument('--developer-dir', help='Path to Xcode')
   parser.add_argument('--sdk', help='Path to SDK')
+  parser.add_argument('--include',
+                      default=[],
+                      action='append',
+                      help='Additional include directory')
   parser.add_argument('defs')
   parser.add_argument('user_c')
   parser.add_argument('server_c')
@@ -124,10 +128,12 @@ def main(args):
              '-header', parsed.user_h,
              '-sheader', parsed.server_h,
             ]
-  if parsed.sdk is not None:
-    command.extend(['-isysroot', parsed.sdk])
   if parsed.developer_dir is not None:
     os.environ['DEVELOPER_DIR'] = parsed.developer_dir
+  if parsed.sdk is not None:
+    command.extend(['-isysroot', parsed.sdk])
+  for include in parsed.include:
+    command.extend(['-I' + include])
   command.append(parsed.defs)
   subprocess.check_call(command)
   FixUserImplementation(parsed.user_c)

util/util.gyp

@@ -285,7 +285,11 @@
                 '<(INTERMEDIATE_DIR)/util/mach/<(RULE_INPUT_ROOT)Server.h',
               ],
               'action': [
-                'python', '<@(_inputs)', '<(RULE_INPUT_PATH)', '<@(_outputs)'
+                'python',
+                '<@(_inputs)',
+                '<(RULE_INPUT_PATH)',
+                '<@(_outputs)',
+                '--include=../compat/mac'
               ],
               'process_outputs_as_sources': 1,
             },