From c3f4e2d8eb35b30494c478cd370f77916aa8e187 Mon Sep 17 00:00:00 2001 From: Scott Graham Date: Fri, 9 Oct 2015 16:28:19 -0700 Subject: [PATCH] Ensure _NT_SYMBOL_PATH is set for bot runs in cdb test Getting closer... Some tests passed on the last run, but the ones that rely on having ntdll symbols fail on the bot. With `_NT_SYMBOL_PATH` set, cdb will be able to download the PDBs so will be able to dump data for `ntdll!_PEB`, etc. R=mark@chromium.org BUG=crashpad:46 Review URL: https://codereview.chromium.org/1402643002 . --- snapshot/win/end_to_end_test.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/snapshot/win/end_to_end_test.py b/snapshot/win/end_to_end_test.py index 9d8ab27f..48c58a76 100644 --- a/snapshot/win/end_to_end_test.py +++ b/snapshot/win/end_to_end_test.py @@ -195,6 +195,12 @@ def main(args): print >>sys.stderr, 'could not find cdb' return 1 + # Make sure we can download Windows symbols. + if not os.environ.get('_NT_SYMBOL_PATH'): + symbol_dir = MakeTempDir() + os.environ['_NT_SYMBOL_PATH'] = ( + 'SRV*' + symbol_dir + '*https://msdl.microsoft.com/download/symbols') + pipe_name = r'\\.\pipe\end-to-end_%s_%s' % ( os.getpid(), str(random.getrandbits(64)))