3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Read annotation objects from the client when producing snapshots.

Browse Source 
This wires up the annotation objects system of the client to the
snapshot production and minidump writing facilities.

Bug: crashpad:192
Change-Id: If7bb7625b140d71a15b84729372cbd0fd4bc63ef
Reviewed-on: https://chromium-review.googlesource.com/749870
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
This commit is contained in:
Robert Sesek 2017-11-01 19:09:29 -04:00 committed by Commit Bot
parent 79e2dd843e
commit b6a3d91342
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
snapshot/mac/module_snapshot_mac.cc
View File

@ -187,7 +187,9 @@ std::map<std::string, std::string> ModuleSnapshotMac::AnnotationsSimpleMap()
std::vector<AnnotationSnapshot> ModuleSnapshotMac::AnnotationObjects() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
return {};
MachOImageAnnotationsReader annotations_reader(
process_reader_, mach_o_image_reader_, name_);
return annotations_reader.AnnotationsList();
}
std::set<CheckedRange<uint64_t>> ModuleSnapshotMac::ExtraMemoryRanges() const {

4
snapshot/win/module_snapshot_win.cc
View File

@ -192,7 +192,9 @@ std::map<std::string, std::string> ModuleSnapshotWin::AnnotationsSimpleMap()
std::vector<AnnotationSnapshot> ModuleSnapshotWin::AnnotationObjects() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
return {};
PEImageAnnotationsReader annotations_reader(
process_reader_, pe_image_reader_.get(), name_);
return annotations_reader.AnnotationsList();
}
std::set<CheckedRange<uint64_t>> ModuleSnapshotWin::ExtraMemoryRanges() const {