3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify MinidumpModuleWriter’s module name requirement implementation.

Browse Source 
TEST=minidump_test MinidumpModuleWriter*
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/633163002
This commit is contained in:
Mark Mentovai 2014-10-07 17:31:43 -04:00
parent 40602fab1f
commit b677bc4ec0
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
minidump/minidump_module_writer.cc
View File

@ -250,13 +250,12 @@ void MinidumpModuleWriter::SetFileFlagsAndMask(uint32_t file_flags,
bool MinidumpModuleWriter::Freeze() { bool MinidumpModuleWriter::Freeze() {
DCHECK_EQ(state(), kStateMutable); DCHECK_EQ(state(), kStateMutable);
CHECK(name_);
if (!MinidumpWritable::Freeze()) { if (!MinidumpWritable::Freeze()) {
return false; return false;
} }
CHECK(name_);
name_->RegisterRVA(&module_.ModuleNameRva); name_->RegisterRVA(&module_.ModuleNameRva);
if (codeview_record_) { if (codeview_record_) {
@ -281,11 +280,10 @@ size_t MinidumpModuleWriter::SizeOfObject() {
std::vector<internal::MinidumpWritable*> MinidumpModuleWriter::Children() { std::vector<internal::MinidumpWritable*> MinidumpModuleWriter::Children() {
DCHECK_GE(state(), kStateFrozen); DCHECK_GE(state(), kStateFrozen);
DCHECK(name_);
std::vector<MinidumpWritable*> children; std::vector<MinidumpWritable*> children;
if (name_) { children.push_back(name_.get());
children.push_back(name_.get());
}
if (codeview_record_) { if (codeview_record_) {
children.push_back(codeview_record_); children.push_back(codeview_record_);
} }