3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

ios: Expose EnableUploading in CrashpadClient.

Browse Source 
This method should be called when an application is ready to start
uploading any pending reports.

Bug: crashpad: 31
Change-Id: I70948fc4dfd8ee509d313b27a50fc4314baf5ce8
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2698179
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
This commit is contained in:
Justin Cohen 2021-02-16 22:38:31 -05:00 committed by Commit Bot
parent c7ec0a84cc
commit b4bcc4df25
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
client/crashpad_client.h
View File

@ -472,10 +472,9 @@ class CrashpadClient {
//!
//! A handler must have already been installed before calling this method.
//! This method should be called when an application is ready to start
//! processing previously created intermediate dumps and begin uploading.
//! Processing will block, so this should not be called on the main UI thread.
//! No intermediate dumps will be processed (and therefore no minidumps will
//! uploaded) until this method (or DumpWithoutCrash) is called.
//! processing previously created intermediate dumps. Processing will block,
//! so this should not be called on the main UI thread. No intermediate dumps
//! will be processed until this method is called.
//!
//! \param[in] annotations Process annotations to set in each crash report.
//! Useful when adding crash annotations detected on the next run after a
@ -483,6 +482,12 @@ class CrashpadClient {
void ProcessIntermediateDumps(
const std::map<std::string, std::string>& annotations = {});
//! \brief Requests that the handler begin in-process uploading of any
//! pending reports.
//!
//! A handler must have already been installed before calling this method.
void EnableUploading();
// TODO(justincohen): This method is purely for bringing up iOS interfaces.
//! \brief Requests that the handler capture a dump even though there hasn't
//! been a crash.

5
client/crashpad_client_ios.cc
View File

@ -233,6 +233,11 @@ void CrashpadClient::ProcessIntermediateDumps(
crash_handler->ProcessIntermediateDumps(annotations);
}
// static
void CrashpadClient::EnableUploading() {
// TODO(justincohen): Start the CrashReportUploadThread.
}
// static
void CrashpadClient::DumpWithoutCrash(NativeCPUContext* context) {
CrashHandler* crash_handler = CrashHandler::Get();