3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use EXPECT_STREQ(a, b) when a and b are both const char*

Browse Source 
While not strictly asan-related, this bug was found while running tests
under asan. Evidently, strings are pooled differently in that build
configuration.

TEST=crashpad_util_test ExceptionPorts.*
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1291573004 .
This commit is contained in:
Mark Mentovai 2015-08-19 18:47:51 -04:00
parent 6645a69240
commit b1d7833600
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
util/mach/exception_ports_test.cc
View File

@ -361,7 +361,7 @@ class TestExceptionPorts : public MachMultiprocess,
// Get an ExceptionPorts object for the task and each of its threads.
ExceptionPorts task_ports(ExceptionPorts::kTargetTypeTask, ChildTask());
EXPECT_EQ("task", task_ports.TargetTypeName());
EXPECT_STREQ("task", task_ports.TargetTypeName());
// Hopefully the threads returned by task_threads() are in order, with the
// main thread first and the other thread second. This is currently always
@ -381,8 +381,8 @@ class TestExceptionPorts : public MachMultiprocess,
main_thread);
ExceptionPorts other_thread_ports(ExceptionPorts::kTargetTypeThread,
other_thread);
EXPECT_EQ("thread", main_thread_ports.TargetTypeName());
EXPECT_EQ("thread", other_thread_ports.TargetTypeName());
EXPECT_STREQ("thread", main_thread_ports.TargetTypeName());
EXPECT_STREQ("thread", other_thread_ports.TargetTypeName());
if (set_type_ == kSetOutOfProcess) {
// Test ExceptionPorts::SetExceptionPorts() being called from
@ -587,7 +587,7 @@ TEST(ExceptionPorts, HostExceptionPorts) {
base::mac::ScopedMachSendRight host(mach_host_self());
ExceptionPorts explicit_host_ports(ExceptionPorts::kTargetTypeHost, host);
EXPECT_EQ("host", explicit_host_ports.TargetTypeName());
EXPECT_STREQ("host", explicit_host_ports.TargetTypeName());
std::vector<ExceptionPorts::ExceptionHandler> handlers;
bool rv = explicit_host_ports.GetExceptionPorts(
@ -600,7 +600,7 @@ TEST(ExceptionPorts, HostExceptionPorts) {
ExceptionPorts implicit_host_ports(ExceptionPorts::kTargetTypeHost,
HOST_NULL);
EXPECT_EQ("host", implicit_host_ports.TargetTypeName());
EXPECT_STREQ("host", implicit_host_ports.TargetTypeName());
rv = implicit_host_ports.GetExceptionPorts(
ExcMaskAll() | EXC_MASK_CRASH, &handlers);