From b03c11533c1487cc7daf3f74daf6d797288d4c22 Mon Sep 17 00:00:00 2001
From: Joshua Peraza <jperaza@chromium.org>
Date: Wed, 15 Dec 2021 10:59:57 -0800
Subject: [PATCH] Remove unnecessary lines in CaptureMemoryDelegate

Change-Id: I172c5bf9f399791a9bfecd26553450a2ed30315b
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3342502
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
---
 snapshot/linux/capture_memory_delegate_linux.cc | 14 ++++++--------
 snapshot/win/capture_memory_delegate_win.cc     | 14 ++++++--------
 2 files changed, 12 insertions(+), 16 deletions(-)

diff --git a/snapshot/linux/capture_memory_delegate_linux.cc b/snapshot/linux/capture_memory_delegate_linux.cc
index bf4c7b8e..918e572d 100644
--- a/snapshot/linux/capture_memory_delegate_linux.cc
+++ b/snapshot/linux/capture_memory_delegate_linux.cc
@@ -62,14 +62,12 @@ void CaptureMemoryDelegateLinux::AddNewMemorySnapshot(
   snapshots_->push_back(std::make_unique<internal::MemorySnapshotGeneric>());
   internal::MemorySnapshotGeneric* snapshot = snapshots_->back().get();
   snapshot->Initialize(process_reader_->Memory(), range.base(), range.size());
-  if (budget_remaining_) {
-    if (!base::IsValueInRangeForNumericType<int64_t>(range.size())) {
-      *budget_remaining_ = 0;
-    } else {
-      int64_t temp = *budget_remaining_;
-      temp -= range.size();
-      *budget_remaining_ = base::saturated_cast<uint32_t>(temp);
-    }
+  if (!base::IsValueInRangeForNumericType<int64_t>(range.size())) {
+    *budget_remaining_ = 0;
+  } else {
+    int64_t temp = *budget_remaining_;
+    temp -= range.size();
+    *budget_remaining_ = base::saturated_cast<uint32_t>(temp);
   }
 }
 
diff --git a/snapshot/win/capture_memory_delegate_win.cc b/snapshot/win/capture_memory_delegate_win.cc
index 3d3cdd54..43067caa 100644
--- a/snapshot/win/capture_memory_delegate_win.cc
+++ b/snapshot/win/capture_memory_delegate_win.cc
@@ -60,14 +60,12 @@ void CaptureMemoryDelegateWin::AddNewMemorySnapshot(
   snapshots_->push_back(std::make_unique<internal::MemorySnapshotGeneric>());
   internal::MemorySnapshotGeneric* snapshot = snapshots_->back().get();
   snapshot->Initialize(process_reader_->Memory(), range.base(), range.size());
-  if (budget_remaining_) {
-    if (!base::IsValueInRangeForNumericType<int64_t>(range.size())) {
-      *budget_remaining_ = 0;
-    } else {
-      int64_t temp = *budget_remaining_;
-      temp -= range.size();
-      *budget_remaining_ = base::saturated_cast<uint32_t>(temp);
-    }
+  if (!base::IsValueInRangeForNumericType<int64_t>(range.size())) {
+    *budget_remaining_ = 0;
+  } else {
+    int64_t temp = *budget_remaining_;
+    temp -= range.size();
+    *budget_remaining_ = base::saturated_cast<uint32_t>(temp);
   }
 }